From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH] ARM: dts: sun8i: a83t: Add missing cooling device properties for CPUs Date: Thu, 28 Mar 2019 16:04:36 +0800 Message-ID: References: <20190327004837.10384-1-megous@megous.com> Reply-To: wens-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20190327004837.10384-1-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: =?UTF-8?Q?Ond=C5=99ej_Jirman?= Cc: linux-sunxi , Rob Herring , Mark Rutland , Maxime Ripard , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Allwinner sunXi SoC support" , open list List-Id: devicetree@vger.kernel.org On Wed, Mar 27, 2019 at 8:49 AM megous via linux-sunxi wrote: > > From: Ondrej Jirman > > This is inspired by the similar patch for H3. Original description > applies, and is copied below: > > The cooling device properties, like "#cooling-cells" and > "dynamic-power-coefficient", should either be present for all the CPUs > of a cluster or none. If these are present only for a subset of CPUs of > a cluster then things will start falling apart as soon as the CPUs are > brought online in a different order. For example, this will happen > because the operating system looks for such properties in the CPU node > it is trying to bring up, so that it can register a cooling device. > > Add such missing properties. > > Fix other missing properties (clocks, clock-names) as well to make it all > work. Could you split this out into a separate patch? It actually touches more lines than the primary part of your patch. ChenYu