From: Chen-Yu Tsai <wens@csie.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-clk <linux-clk@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH v4 3/6] clk: sunxi-ng: add support for Allwinner A64 DE2 CCU
Date: Tue, 2 Jan 2018 16:09:57 +0800 [thread overview]
Message-ID: <CAGb2v65DiLg8QyT=BRHGJXUYLibP=wzYCj8ZW3hpWsF2miO2sA@mail.gmail.com> (raw)
In-Reply-To: <20171230113043.30237-4-icenowy@aosc.io>
On Sat, Dec 30, 2017 at 7:30 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Allwinner A64's DE2 needs to claim a section of SRAM (SRAM C) to work.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> Changes in v4:
> - Use a struct to maintain both ccu desc and quirks as Chen-Yu Tsai
> suggested.
This made the patch slightly messy. Could you split it into two patches?
The first just adds the struct (without the sram_needed field) and migrates
everything to that. This patch should mention it is preperation for the
next patch, which adds the a field to the struct (otherwise it makes no
sense and just looks like churn.) The second patch will add the .sram_needed
field and support for the A64 DE2 CCU.
Thanks
ChenYu
next prev parent reply other threads:[~2018-01-02 8:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 11:30 [PATCH v4 0/6] Allwinner H3/H5/A64(DE2) SimpleFB support (Part 2) Icenowy Zheng
[not found] ` <20171230113043.30237-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-12-30 11:30 ` [PATCH v4 1/6] ARM: sunxi: h3/h5: add simplefb nodes Icenowy Zheng
2018-01-02 8:11 ` [linux-sunxi] " Chen-Yu Tsai
[not found] ` <CAGb2v64V7KYw5W95-E=b=Li13ZFXy7JakK4+Dx1dsrXXSJZ+wg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-02 8:14 ` Icenowy Zheng
2018-01-02 8:31 ` Jernej Škrabec
2018-01-03 2:47 ` [linux-sunxi] " Chen-Yu Tsai
2017-12-30 11:30 ` [PATCH v4 2/6] dt-bindings: add binding for A64 DE2 CCU SRAM Icenowy Zheng
2017-12-30 11:30 ` [PATCH v4 3/6] clk: sunxi-ng: add support for Allwinner A64 DE2 CCU Icenowy Zheng
2018-01-02 8:09 ` Chen-Yu Tsai [this message]
2017-12-30 11:30 ` [PATCH v4 5/6] arm64: allwinner: a64: add simplefb for A64 SoC Icenowy Zheng
[not found] ` <20171230113043.30237-6-icenowy-h8G6r0blFSE@public.gmane.org>
2018-01-02 8:30 ` Chen-Yu Tsai
2017-12-30 11:30 ` [PATCH v4 4/6] arm64: allwinner: a64: add DE2 CCU " Icenowy Zheng
2017-12-30 11:30 ` [PATCH v4 6/6] arm64: allwinner: a64: add HDMI regulator to all DTs' simplefb_hdmi Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v65DiLg8QyT=BRHGJXUYLibP=wzYCj8ZW3hpWsF2miO2sA@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).