Re: [PATCH v2 5/6] ARM: dts: axp209: Add ac_power_supply child node to the ax209 node

[Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>]

Hi,

On Sun, May 1, 2016 at 4:57 PM, Michael Haas <haas-bdq14YP6qtSV9CzYT+GlPGD2FQJk+8+b@public.gmane.org> wrote:
> Add a node representing the ac power supply part of the axp209 pmic.
>
> Signed-off-by: Michael Haas <haas-bdq14YP6qtSV9CzYT+GlPGD2FQJk+8+b@public.gmane.org>
> ---
>  arch/arm/boot/dts/axp209.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> index 051ab3b..9046f0a 100644
> --- a/arch/arm/boot/dts/axp209.dtsi
> +++ b/arch/arm/boot/dts/axp209.dtsi
> @@ -94,4 +94,10 @@
>                 compatible = "x-powers,axp202-usb-power-supply";
>                 status = "disabled";
>         };
> +
> +       ac_power_supply: ac_power_supply {

Please keep them alphabetically sorted.

> +               compatible = "x-powers,axp202-ac-power-supply";
> +               status = "disabled";

I see no reason why we shouldn't just enable it by default.
It is almost always going to be used. Same for the VBUS power supply.

> +       };
> +

Extra line here.


ChenYu

>  };
> --
> 2.8.0
>