devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	dri-devel
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-clk <linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Re: [RFC PATCH 01/11] dt-bindings: update the binding for Allwinner H3 TVE support
Date: Sat, 20 May 2017 10:01:41 +0800	[thread overview]
Message-ID: <CAGb2v66DOZbppAOT6yLaxyLSmSQ3t9RT-ESHaNq1vs=Fwbv93Q@mail.gmail.com> (raw)
In-Reply-To: <ED64A56C-4FD3-4878-B67E-1501F20C7B8D-h8G6r0blFSE@public.gmane.org>

On Sat, May 20, 2017 at 2:06 AM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote:
>
>
> 于 2017年5月20日 GMT+08:00 上午2:02:15, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 写到:
>>On Thu, May 18, 2017 at 12:43:44AM +0800, Icenowy Zheng wrote:
>>> -On SoCs other than the A33 and V3s, there is one more clock
>>required:
>>> +For the following compatibles:
>>> +   * allwinner,sun5i-a13-tcon
>>> +   * allwinner,sun6i-a31-tcon
>>> +   * allwinner,sun6i-a31s-tcon
>>> +   * allwinner,sun8i-a33-tcon
>>> +   * allwinner,sun8i-v3s-tcon
>>> +there is one more clock and one more property required:
>>> + - clocks:
>>> +   - 'tcon-ch0': The clock driving the TCON channel 0
>>> + - clock-output-names: Name of the pixel clock created
>>> +
>>> +For the following compatibles:
>>> +   * allwinner,sun5i-a13-tcon
>>> +   * allwinner,sun6i-a31-tcon
>>> +   * allwinner,sun6i-a31s-tcon
>>> +   * allwinner,sun8i-h3-tcon0
>>> +there is one more clock required:
>>>     - 'tcon-ch1': The clock driving the TCON channel 1
>>
>>Putting ID's in the compatible name is usually a bad idea. What is the
>>difference between the two? Only that the second one doesn't have a
>>clock?
>
> Yes.
>
>>
>>That seems highly unlikely. How does it generate the pixel clock
>>frequency?
>
> Yes it seems impossible, but it's also the fact.
>
> There's only one CLK_TCON in H3/5, which is for TCON0.
>
> It's possible that lcd-ch1 clk is CLK_TVE, but it's still a weird situation --
> Although we have a lcd-ch1 clock, we cannot touch it, otherwise
> the TVE will refuse to work (the TVE can only work under 216MHz).

Assuming the TV encoder is like the old one, then it never had a
separate module clock. Instead its timing signals are fed from the
TCON. So CLK_TVE is likely the clock for TCON1 here.

ChenYu

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2017-05-20  2:01 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 16:43 [RFC PATCH 00/11] Support for H3 Composite Output support Icenowy Zheng
     [not found] ` <20170517164354.16399-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-17 16:43   ` [RFC PATCH 01/11] dt-bindings: update the binding for Allwinner H3 TVE support Icenowy Zheng
     [not found]     ` <20170517164354.16399-2-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 18:02       ` Maxime Ripard
     [not found]         ` <20170519180215.7lc7duueu74pt4kz-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-19 18:06           ` Icenowy Zheng
     [not found]             ` <ED64A56C-4FD3-4878-B67E-1501F20C7B8D-h8G6r0blFSE@public.gmane.org>
2017-05-20  2:01               ` Chen-Yu Tsai [this message]
2017-05-17 16:43   ` [RFC PATCH 02/11] drm: sun4i: add support for H3 mixers Icenowy Zheng
     [not found]     ` <20170517164354.16399-3-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 17:47       ` Maxime Ripard
     [not found]         ` <20170519174729.q5qk2vqlibzx3zrv-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-19 17:49           ` Icenowy Zheng
     [not found]             ` <695DFDD0-1925-433C-AB88-B90EE461C203-h8G6r0blFSE@public.gmane.org>
2017-05-19 18:00               ` Jernej Škrabec
2017-05-17 16:43   ` [RFC PATCH 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2 Icenowy Zheng
     [not found]     ` <20170517164354.16399-4-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 17:57       ` Maxime Ripard
     [not found]         ` <20170519175753.sygqnwopk7tuv35n-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-19 18:00           ` Icenowy Zheng
     [not found]             ` <ECF29F56-DF18-4E3C-9C85-B29F89BD4228-h8G6r0blFSE@public.gmane.org>
2017-05-24  8:14               ` Maxime Ripard
2017-06-04 14:19                 ` icenowy
2017-05-17 16:43   ` [RFC PATCH 04/11] drm: sun4i: add support for H3's TCON0/1 Icenowy Zheng
2017-05-17 16:43   ` [RFC PATCH 05/11] drm: sun4i: add compatible for H3 display engine Icenowy Zheng
2017-05-17 16:43   ` [RFC PATCH 06/11] drm: sun4i: add color space correction support for DE2 mixer Icenowy Zheng
     [not found]     ` <20170517164354.16399-7-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-17 20:14       ` Jernej Škrabec
2017-05-17 16:43   ` [RFC PATCH 07/11] drm: sun4i: add support for the TV encoder in H3 SoC Icenowy Zheng
     [not found]     ` <20170517164354.16399-8-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 18:03       ` Maxime Ripard
     [not found]         ` <20170519180330.7hpfkdqk3r2x3kn5-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-19 18:08           ` Icenowy Zheng
     [not found]             ` <3FCDBC05-20A1-460C-A21B-8C3E9C776768-h8G6r0blFSE@public.gmane.org>
2017-05-19 18:23               ` Jernej Škrabec
2017-05-20  1:37                 ` Chen-Yu Tsai
     [not found]                   ` <CAGb2v66aD=G+V75N-_nYo=dGqhxpKhadM84h9G-B34=dnDwCbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-22 17:55                     ` Jernej Škrabec
2017-05-23 12:53                       ` Maxime Ripard
2017-05-23 12:56                         ` [linux-sunxi] " Icenowy Zheng
2017-05-23 13:00                         ` icenowy
     [not found]                           ` <98c3572beee0a81755994b4bdc508b18-h8G6r0blFSE@public.gmane.org>
2017-05-24  7:30                             ` Maxime Ripard
     [not found]                               ` <20170524073019.bl6rojc2srrigalp-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-24  8:25                                 ` [linux-sunxi] " Icenowy Zheng
     [not found]                                   ` <98558BA2-BC99-4D0A-A045-571C643875C5-h8G6r0blFSE@public.gmane.org>
2017-05-24 15:23                                     ` Jernej Škrabec
2017-05-31 18:43                                     ` Maxime Ripard
     [not found]                                       ` <20170531184306.hzu2em35vr4qi4un-ZC1Zs529Oq4@public.gmane.org>
2017-06-01 14:11                                         ` icenowy-h8G6r0blFSE
     [not found]                                           ` <715e6ab52d8aa0032c9759393ace20dc-h8G6r0blFSE@public.gmane.org>
2017-06-02 22:21                                             ` Maxime Ripard
2017-06-04 14:29                               ` [linux-sunxi] " icenowy
     [not found]                                 ` <861ead704cc7d1bc0983d0f01138f190-h8G6r0blFSE@public.gmane.org>
2017-06-07  7:58                                   ` Maxime Ripard
2017-05-17 16:43   ` [RFC PATCH 08/11] clk: sunxi-ng: allow CLK_DE to set CLK_PLL_DE for H3 Icenowy Zheng
2017-05-17 16:43   ` [RFC PATCH 09/11] clk: sunxi-ng: export " Icenowy Zheng
2017-05-17 16:43   ` [RFC PATCH 10/11] ARM: sun8i: h3: add display engine pipeline for TVE Icenowy Zheng
     [not found]     ` <20170517164354.16399-11-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-17 20:19       ` [linux-sunxi] " Jernej Škrabec
2017-05-19 18:06       ` Maxime Ripard
     [not found]         ` <20170519180616.vzrlu2avuucsjkiu-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-19 18:10           ` Icenowy Zheng
2017-05-24  8:19             ` [linux-sunxi] " Maxime Ripard
2017-05-24  5:24       ` Chen-Yu Tsai
     [not found]         ` <CAGb2v64nVA=hHjXkVNMN68vQizMBE6vyYfaE895b0L6umv_Ycw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-24  5:28           ` [linux-sunxi] " Icenowy Zheng
     [not found]             ` <299627EE-8D9C-451A-9F74-0C5037D19DCC-h8G6r0blFSE@public.gmane.org>
2017-05-24  5:34               ` Chen-Yu Tsai
     [not found]                 ` <CAGb2v64-3TYDgCBhGFNDqvoTa1ch=j3k__rnbB80dsFQn3JsKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-24  5:36                   ` Icenowy Zheng
2017-05-17 16:43   ` [RFC PATCH 11/11] [DO NOT MERGE] ARM: sun8i: h3: enable TV output on Orange Pi PC Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGb2v66DOZbppAOT6yLaxyLSmSQ3t9RT-ESHaNq1vs=Fwbv93Q@mail.gmail.com' \
    --to=wens-jday2fn1rrm@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=icenowy-h8G6r0blFSE@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).