From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH RFC] arm64: dts: allwinner: a64: teres-i: Enable audio Date: Tue, 12 Feb 2019 16:34:46 +0800 Message-ID: References: <20190201113743.10058-1-harald@ccbib.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190201113743.10058-1-harald@ccbib.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Harald Geyer Cc: Mark Rutland , devicetree , info@olimex.com, Maxime Ripard , Mark Brown , Vasily Khoruzhick , Rob Herring , ibu@radempa.de, linux-arm-kernel List-Id: devicetree@vger.kernel.org On Fri, Feb 1, 2019 at 7:37 PM Harald Geyer wrote: > > The TERES-I has internal speakers (left, right), internal microphone > and a headset combo jack (headphones + mic). > > The headphone lines are multiplexed with the debug console. > The headphone and mic detect lines of the A64 are connected properly, > but AFAIK currently unsupported by the driver. > > Signed-off-by: Harald Geyer > --- > Hi all, > > a couple of issues make this patch RFC: > > hpvcc-supply vs. cpvdd-supply: > On the A64 manual the pin is called CPVDD and the binding documents > requires a cpvdd-supply property. However in the actual driver and > devicetrees so far hpvcc-supply is used. This is a very new binding, > so we have the luxury to decide either way, I think. Any input from > the devicetree maintainers would be appreciated. Sorry about the screw-up. I'll send out patches fixing this once I test them. The preferred name is CPVDD, as that is what the datasheet uses. ChenYu