From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH] arm64: dts: allwinner: properly connect USB PHY to port 0 Date: Mon, 24 Jun 2019 16:25:47 +0800 Message-ID: References: <20190620010127.12071-1-andre.przywara@arm.com> Reply-To: wens-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20190620010127.12071-1-andre.przywara-5wv7dgnIgG8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Andre Przywara Cc: Maxime Ripard , linux-arm-kernel , linux-sunxi , Mark Rutland , Rob Herring , devicetree List-Id: devicetree@vger.kernel.org On Thu, Jun 20, 2019 at 9:02 AM Andre Przywara wrote: > > In recent Allwinner SoCs the first USB host controller (HCI0) shares > the first PHY with the MUSB controller. Probably to make this sharing > work, we were avoiding to declare this in the DT. This has two > shortcomings: > - U-Boot (which uses the same .dts) cannot use this port without a PHY > linked, so we were loosing one USB port there. > - It requires the MUSB driver to be enabled and loaded, although we > don't actually use it. > > For those (64-bit) boards which use an USB-A socket for HCI0/MUSB, add > a "phys" property pointing to the USB PHY 0. > > This makes it work in U-Boot, also improves compatiblity when no MUSB > driver is loaded (for instance in distribution installers). > > Signed-off-by: Andre Przywara > --- > Hi, > > I have the feeling this belongs into the .dtsi, but cant't tell for sure > how this interacts with the MUSB driver. If need be, we can always pull > this up later, I guess. Have you tried if gadget mode and switching between gadget/host mode on an otg port still works? AFAICT that would be the main thing to worry about. ChenYu