From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 3/8] mfd: axp20x: probe axp20x_adc driver for AXP813 Date: Thu, 7 Dec 2017 17:14:30 +0800 Message-ID: References: <302c93023d8c4a54cafe321d912df484e39727b7.1512396054.git-series.quentin.schulz@free-electrons.com> <20171205080855.arr7vlgnxoxmyedd@flea.lan> <2021a653-d01e-f46f-2438-0760f579e0dc@free-electrons.com> <41fcadb9-4fa9-65e8-5ef3-5844bcba1b1d@free-electrons.com> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <41fcadb9-4fa9-65e8-5ef3-5844bcba1b1d-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Quentin Schulz Cc: Chen-Yu Tsai , Maxime Ripard , Sebastian Reichel , Rob Herring , Mark Rutland , Russell King , Jonathan Cameron , Lee Jones , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "open list:THERMAL" , devicetree , linux-kernel , linux-arm-kernel , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Icenowy Zheng , linux-sunxi , Thomas Petazzoni List-Id: devicetree@vger.kernel.org On Thu, Dec 7, 2017 at 5:03 PM, Quentin Schulz wrote: > Hi Chen-Yu, > > On 07/12/2017 09:54, Chen-Yu Tsai wrote: >> On Thu, Dec 7, 2017 at 4:51 PM, Quentin Schulz >> wrote: >>> Hi Maxime, >>> >>> On 05/12/2017 09:08, Maxime Ripard wrote: >>>> On Mon, Dec 04, 2017 at 03:12:49PM +0100, Quentin Schulz wrote: >>>>> This makes the axp20x_adc driver probe with platform device id >>>>> "axp813-adc". >>>>> >>>>> Signed-off-by: Quentin Schulz >>>>> --- >>>>> drivers/mfd/axp20x.c | 4 +++- >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >>>>> index 2468b43..42e54d1 100644 >>>>> --- a/drivers/mfd/axp20x.c >>>>> +++ b/drivers/mfd/axp20x.c >>>>> @@ -878,7 +878,9 @@ static struct mfd_cell axp813_cells[] = { >>>>> .resources = axp803_pek_resources, >>>>> }, { >>>>> .name = "axp20x-regulator", >>>>> - } >>>>> + }, { >>>>> + .name = "axp813-adc", >>>>> + }, >>>> >>>> Any particular reason you're not adding it to the DT? >>>> >>> >>> No, no particular reason. It's just the way it is currently for AXP209 >>> and AXP22x so did the same for AXP813. >>> >>> I'll add DT "support" in next version for all AXPs supported by this >>> driver. Or is it worthy of a small separate patch series? >> >> IIRC there's no DT support because there's no need to reference >> it in the device tree. >> > > No current need but that does not mean there won't be a need later for > drivers to map IIO channels from the ADC driver (i.e. some components > wired to GPIOs of the PMIC for example). Hmm... Why would you map the IIO channels from the ADC? I thought those were all accessible from userspace? However, proper muxing of the GPIO pin to the ADC function makes sense. ChenYu