Re: [PATCH 4/6] ARM: sun8i: a83t: Add device node for DMA controller

[Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>]

On Mon, May 22, 2017 at 3:18 PM, Code Kipper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 22 May 2017 at 08:25, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote:
>> The A83T SoC has a DMA controller that supports 8 DMA channels
>> to and from various peripherals.
>>
>> Add a device node for it.
>>
>> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/sun8i-a83t.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> index e12dd7170b8f..47196feda26b 100644
>> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> @@ -163,6 +163,15 @@
>>                 #size-cells = <1>;
>>                 ranges;
>>
>> +               dma: dma-controller@1c02000 {
>> +                       compatible = "allwinner,sun8i-a83t-dma";
>> +                       reg = <0x01c02000 0x1000>;
>> +                       interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
>> +                       clocks = <&ccu 21>;
>> +                       resets = <&ccu 7>;
> Hi Wens,
> these should be ccu defines, otherwise everything else looks great.

Correct. Since the CCU bindings was just introduced, I'm saving all the macros
for v4.13-rc2.

ChenYu

> Great Work,
> CK
>> +                       #dma-cells = <1>;
>> +               };
>> +
>>                 ccu: clock@1c20000 {
>>                         compatible = "allwinner,sun8i-a83t-ccu";
>>                         reg = <0x01c20000 0x400>;
>> --
>> 2.11.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
>> For more options, visit https://groups.google.com/d/optout.