Re: [PATCH 4/5] arm64: dts: allwinner: a523: Add UART1 pins

[Chen-Yu Tsai <wens@kernel.org>]

On Fri, Jun 20, 2025 at 9:55 PM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Fri, 20 Jun 2025 01:30:06 +0800
> Chen-Yu Tsai <wens@kernel.org> wrote:
>
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > UART1 is normally used to connect to the Bluetooth side of a Broadcom
> > WiFi+BT combo chip. The connection uses 4 pins.
> >
> > Add pinmux nodes for UART1, one for the RX/TX pins, and one for the
> > RTS/CTS pins.
>
> Interestingly there is only one possible set of pins for UART1, so the
> naming is correct. Which would also mean we can insert the pinctrl-0
> property in the UART DT node in the .dtsi file already.

I'd leave it to the user, since it's possible to use it in either 2 pin
or 4 pin configuration.

> Regardless, checked against the manual:
>
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Thanks!
ChenYu

>
> Cheers,
> Andre
>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > index 30613a0b1124..6f62201fd739 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > @@ -168,6 +168,20 @@ uart0_pb_pins: uart0-pb-pins {
> >                               allwinner,pinmux = <2>;
> >                               function = "uart0";
> >                       };
> > +
> > +                     /omit-if-no-ref/
> > +                     uart1_pins: uart1-pins {
> > +                             pins = "PG6", "PG7";
> > +                             function = "uart1";
> > +                             allwinner,pinmux = <2>;
> > +                     };
> > +
> > +                     /omit-if-no-ref/
> > +                     uart1_rts_cts_pins: uart1-rts-cts-pins {
> > +                             pins = "PG8", "PG9";
> > +                             function = "uart1";
> > +                             allwinner,pinmux = <2>;
> > +                     };
> >               };
> >
> >               ccu: clock-controller@2001000 {
>