From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 2/4] drivers: soc: sunxi: fix error processing on base address when claiming Date: Fri, 18 Aug 2017 14:21:07 +0800 Message-ID: References: <20170809085627.32687-1-icenowy@aosc.io> <20170809085627.32687-3-icenowy@aosc.io> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170809085627.32687-3-icenowy-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org Hi, On Wed, Aug 9, 2017 at 4:56 PM, Icenowy Zheng wrote: > When claiming SRAM, if the base is set to an error, it means that the > SRAM controller has been probed, but failed to remap the controller > memory zone. If the base is zero, thus the SRAM controller should be not > probed at all, and it should return -EPROBE_DEFER. However, currently we > returned -EPROBE_DEFER in the former situation, and ignored the latter > situation (which will lead to the kernel to panic). > > Fix the behavior on abnormal base address processing when claiming. Could you describe how you actually ran into this? The failure seems unlikely for a properly written device tree. Thanks ChenYu