From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 05/15] ARM: dts: sun5i: reference-design-tablet: Remove mention of q8
Date: Sat, 9 Jul 2016 11:53:06 +0800 [thread overview]
Message-ID: <CAGb2v67S9s5PifX4JOjp6DK57Q3aVRrKMdf7y75vna2rdrASFA@mail.gmail.com> (raw)
In-Reply-To: <1467993956-19535-6-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Sat, Jul 9, 2016 at 12:05 AM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Remove all mention of q8 from sun5i-reference-design-tablet.dtsi.
>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi b/arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi
> index e78452c..20cc940 100644
> --- a/arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi
> +++ b/arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi
> @@ -98,7 +98,7 @@
>
> &mmc0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_q8>;
> + pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> vmmc-supply = <®_vcc3v0>;
> bus-width = <4>;
> cd-gpios = <&pio 6 0 GPIO_ACTIVE_HIGH>; /* PG0 */
> @@ -118,7 +118,7 @@
> allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> };
>
> - mmc0_cd_pin_q8: mmc0_cd_pin@0 {
> + mmc0_cd_pin: mmc0_cd_pin@0 {
We could name this mmc0_cd_pin_reference_design and put it in
sun5i-a13.dtsi. We already do this for A10/A20.
This works equally well though.
Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> allwinner,pins = "PG0";
> allwinner,function = "gpio_in";
> allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-09 3:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 16:05 [PATCH 00/15] ARM: dts: sunxi: Add reference-design-tablet.dtsi files + 2 new tablets Hans de Goede
[not found] ` <1467993956-19535-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-08 16:05 ` [PATCH 01/15] ARM: dts: sunxi: Rename sunxi-q8-common.dtsi sunxi-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05 ` [PATCH 02/15] ARM: dts: sun5i: Move q8 display bits to sun5i-a13-q8-tablet.dts Hans de Goede
2016-07-08 16:05 ` [PATCH 03/15] ARM: dts: sun5i: Rename sun5i-q8-common.dtsi sun5i-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05 ` [PATCH 04/15] ARM: dts: sun5i: reference-design-tablet: Set lradc vref to avcc Hans de Goede
2016-07-08 16:05 ` [PATCH 05/15] ARM: dts: sun5i: reference-design-tablet: Remove mention of q8 Hans de Goede
[not found] ` <1467993956-19535-6-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-09 3:53 ` Chen-Yu Tsai [this message]
[not found] ` <CAGb2v67S9s5PifX4JOjp6DK57Q3aVRrKMdf7y75vna2rdrASFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-09 9:28 ` Hans de Goede
2016-07-08 16:05 ` [PATCH 06/15] ARM: dts: sun5i: Use sun5i-reference-design-tablet.dtsi for dit4350 dts Hans de Goede
2016-07-08 16:05 ` [PATCH 07/15] ARM: dts: sun5i: Use sun5i-reference-design-tablet.dtsi for utoo p66 dts Hans de Goede
2016-07-08 16:05 ` [PATCH 08/15] ARM: dts: Copy sun8i-q8-common.dtsi sun8i-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05 ` [PATCH 09/15] ARM: dts: sun8i: reference-design-tablet: Add drivevbus-supply Hans de Goede
2016-07-08 16:05 ` [PATCH 10/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for polaroid mid2809pxe04 Hans de Goede
2016-07-08 16:05 ` [PATCH 11/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for gt90h dts Hans de Goede
2016-07-08 16:05 ` [PATCH 12/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for ga10h dts Hans de Goede
2016-07-08 16:05 ` [PATCH 13/15] ARM: dts: sun8i: Add dt node for rtl8703as wifi chip on ga10h Hans de Goede
[not found] ` <1467993956-19535-14-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-11 6:39 ` Maxime Ripard
2016-07-11 12:36 ` Hans de Goede
[not found] ` <f5f0a0d0-96a8-e9ad-7b4d-b8f19999f0e9-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-13 7:18 ` Maxime Ripard
2016-07-08 16:05 ` [PATCH 14/15] ARM: dts: sun8i: Add dts file for Polaroid MID2407PXE03 tablet Hans de Goede
2016-07-08 16:05 ` [PATCH 15/15] ARM: dts: sun8i: Add dts file for inet86dz board Hans de Goede
2016-07-11 6:39 ` [PATCH 00/15] ARM: dts: sunxi: Add reference-design-tablet.dtsi files + 2 new tablets Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v67S9s5PifX4JOjp6DK57Q3aVRrKMdf7y75vna2rdrASFA@mail.gmail.com \
--to=wens-jday2fn1rrm@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).