Re: [PATCH v2 03/10] drm/hisilicon: Add hisilicon DRM master driver

From: Xinliang Liu <xinliang.liu@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>, Linuxarm <linuxarm@huawei.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Wei Xu <xuwei5@hisilicon.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	zourongrong@huawei.com, Yiping Xu <xuyiping@hisilicon.com>,
	Jonathan Corbet <corbet@lwn.net>, Wang Fei <w.f@huawei.com>,
	lijianhua@huawei.com,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Bintian Wang <bintian.wang@huawei.com>,
	Chen Feng <puck.chen@hisilicon.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Andy Green <andy.green@linaro.org>,
	"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>,
	Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: Re: [PATCH v2 03/10] drm/hisilicon: Add hisilicon DRM master driver
Date: Sat, 5 Dec 2015 09:25:25 +0800	[thread overview]
Message-ID: <CAGd==06=v52p+NeHUH_0WHBTmaN4QMtswY7B+T3LaS8qOSyc6A@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+cr7sQ1eus8Yi-mCMDq9PCZbFTSoPqt9P4a_m-JGKo0g@mail.gmail.com>

On 4 December 2015 at 00:21, Rob Herring <robh@kernel.org> wrote:
> On Sat, Nov 28, 2015 at 4:38 AM, Xinliang Liu <xinliang.liu@linaro.org> wrote:
>> Add DRM master driver for hi6220 SoC which used in HiKey board.
>> Add dumb buffer feature.
>> Add prime dmabuf feature.
>>
>> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>> Signed-off-by: Andy Green <andy.green@linaro.org>
>> ---
>
>> +static int hisi_gem_cma_dumb_create(struct drm_file *file,
>> +                                   struct drm_device *dev,
>> +                                   struct drm_mode_create_dumb *args)
>> +{
>> +       int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8);
>
> BTW, is args->bpp supposed to be bits or bytes? I'm using your dumb bo
> support in drm_gralloc which does bytes as that is what
> gralloc_drm_get_bpp returns. The virtio-gpu driver does bits. I'm
> guessing bits is correct.

yes, it is bits. And pitch is bytes.

>
> Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel