devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Barry Song <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCHv2 3/3] picoxcell: add the DTS for the PC7302 board
Date: Fri, 23 Sep 2011 10:31:54 +0800	[thread overview]
Message-ID: <CAGsJ_4wniCS+85Hs7-vbaUyEL-yKEBnbgDOFPm0+THh6PMfCdw@mail.gmail.com> (raw)
In-Reply-To: <20110915121512.GG3089-apL1N+EY0C9YtYNIL7UdTEEOCMrvLtNR@public.gmane.org>

2011/9/15 Jamie Iles <jamie@jamieiles.com>:
> On Thu, Sep 15, 2011 at 08:32:02AM -0300, Benjamin Herrenschmidt wrote:
>> On Wed, 2011-08-24 at 15:41 +0100, Jamie Iles wrote:
>>
>> > +   chosen {
>> > +           bootargs = "console=ttyS0,115200 earlyprintk loglevel=9 root=ubi0:rootfs rw rootfstype=ubifs ubi.mtd=5,2048";
>> > +           linux,stdout-path = &uart0;
>> > +   };
>>
>> Hrm... we don't normally put the bootargs in the device-tree.
>>
>> Either you have a way to pass it from a previous firmware (which
>> can then slap it into the device-tree at runtime), or you
>> can have a way to compile it in the kernel image but the device-tree
>> isn't the right place for it.
>
> OK, that's fair enough.  A few other ARM platforms (tegra, prima2 and
> zynq) have bootargs in the chosen node and that's where I got it from,
> but our bootloader has fdt support so this can easily be removed.

some powerpc platforms also do that:

asp834x-redboot.dts:		bootargs = "console=ttyS0,38400
root=/dev/mtdblock3 rootfstype=jffs2";
gamecube.dts:		bootargs = "root=/dev/gcnsda2 rootwait udbg-immortal";
prpmc2800.dts:		bootargs = "ip=on";
rainier.dts:		bootargs = "console=ttyS0,115200";
sequoia.dts:		bootargs = "console=ttyS0,115200";
virtex440-ml507.dts:		bootargs = "console=ttyS0 root=/dev/ram";
virtex440-ml510.dts:		bootargs = "console=ttyS0 root=/dev/ram";
wii.dts:		bootargs = "root=/dev/mmcblk0p2 rootwait udbg-immortal";

if we have no bootargs in bootloader, kernel will use that one in DT.

>
> Thanks,
>
> Jamie

-barry
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

  parent reply	other threads:[~2011-09-23  2:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 14:41 [PATCHv2 0/3] Initial support for Picochip picoxcell Jamie Iles
2011-08-24 14:41 ` [PATCHv2 2/3] picoxcell: add the DTS for pc3x2 and pc3x3 devices Jamie Iles
2011-09-01  6:30   ` Barry Song
     [not found] ` <1314196906-20709-1-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
2011-08-24 14:41   ` [PATCHv2 1/3] picoxcell: support for Picochip picoxcell devices Jamie Iles
2011-08-24 14:41   ` [PATCHv2 3/3] picoxcell: add the DTS for the PC7302 board Jamie Iles
2011-09-01  6:36     ` Barry Song
2011-09-01  7:58       ` Jamie Iles
     [not found]     ` <1314196906-20709-4-git-send-email-jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
2011-09-15 11:32       ` Benjamin Herrenschmidt
2011-09-15 12:15         ` Jamie Iles
     [not found]           ` <20110915121512.GG3089-apL1N+EY0C9YtYNIL7UdTEEOCMrvLtNR@public.gmane.org>
2011-09-23  2:31             ` Barry Song [this message]
     [not found]               ` <CAGsJ_4wniCS+85Hs7-vbaUyEL-yKEBnbgDOFPm0+THh6PMfCdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-23  2:48                 ` Benjamin Herrenschmidt
2011-09-15  8:43   ` [PATCHv2 0/3] Initial support for Picochip picoxcell Jamie Iles
2011-09-26  9:20   ` Jamie Iles
     [not found]     ` <20110926092008.GC3372-apL1N+EY0C9YtYNIL7UdTEEOCMrvLtNR@public.gmane.org>
2011-09-26 14:42       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGsJ_4wniCS+85Hs7-vbaUyEL-yKEBnbgDOFPm0+THh6PMfCdw@mail.gmail.com \
    --to=21cnbao-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).