devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mithil <bavishimithil@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Lopez Cruz" <misael.lopez@ti.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema
Date: Wed, 22 May 2024 23:00:40 +0530	[thread overview]
Message-ID: <CAGzNGRnsmRWzimUX5tEC2-Y44aa4i9Lbdp8YJ+oneV4ujs4qBA@mail.gmail.com> (raw)
In-Reply-To: <e384272a-4dfe-4653-8983-6426f8803c84@kernel.org>

> Binding needs to be adapted to match DTS or DTS has to be fixed to match
> binding, depending which one is correct. Mention any changes done in the
> binding which deviate from pure conversion of TXT->DT schema.
The DTS is correct so will base the example on that (and get a better
changelog in the next version)
So the checks will be 1) dt_bindings_check and 2) dtbs_check

> https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY
Noted, but here I'd assume omap2plus_defconfig would be more relevant.

arch/arm/boot/dts/ti/omap/omap4-duovero-parlor.dtb: mcpdm@0:
'ti,hwmods' is a required property
        from schema $id:
http://devicetree.org/schemas/sound/ti,omap4-mcpdm.yaml#
We already have ti,hwmods still its asking for it?

arch/arm/boot/dts/ti/omap/omap4-duovero-parlor.dtb: mcpdm@0:
'dma-names', 'dmas', 'reg-names' do not match any of the regexes:
'pinctrl-[0-9]+'
        from schema $id:
http://devicetree.org/schemas/sound/ti,omap4-mcpdm.yaml#
It also requires a pinctrl subnode which isnt used anywhere, the
parent node of mcpdm that is mcpdm_module has a pinctrl how would we
go about implementing that?

-- 
Best Regards,
Mithil

  reply	other threads:[~2024-05-22 17:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  7:52 [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Mighty
2024-05-22  8:42 ` Krzysztof Kozlowski
2024-05-22 13:46   ` Mithil
2024-05-22 14:15     ` Krzysztof Kozlowski
2024-05-22 13:56 ` Péter Ujfalusi
2024-05-22 14:16   ` Krzysztof Kozlowski
2024-05-22 14:43     ` Péter Ujfalusi
2024-05-22 15:22       ` Krzysztof Kozlowski
2024-05-22 16:01         ` Péter Ujfalusi
2024-05-22 16:42           ` Krzysztof Kozlowski
2024-05-22 17:02             ` Mithil
2024-05-22 17:07               ` Mithil
2024-05-22 17:07               ` Krzysztof Kozlowski
2024-05-22 17:30                 ` Mithil [this message]
2024-05-22 17:47                   ` Mithil
2024-05-22 18:49                     ` Péter Ujfalusi
2024-05-22 18:39                 ` Péter Ujfalusi
2024-05-23  6:08                   ` Krzysztof Kozlowski
2024-05-22 17:05             ` DT schema bindings conversion mentorships (was Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema) Krzysztof Kozlowski
2024-05-22 17:47               ` Javier Carrasco
2024-05-23  6:12                 ` Krzysztof Kozlowski
2024-05-22 18:36               ` Conor Dooley
2024-05-23 12:33                 ` Daniel Baluta
2024-05-23 12:30               ` Daniel Baluta
2024-05-23 16:24                 ` Rob Herring
2024-05-23 16:31                   ` Javier Carrasco
2024-05-22 14:22   ` [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Rob Herring
2024-05-22 14:39     ` Péter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGzNGRnsmRWzimUX5tEC2-Y44aa4i9Lbdp8YJ+oneV4ujs4qBA@mail.gmail.com \
    --to=bavishimithil@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=misael.lopez@ti.com \
    --cc=peter.ujfalusi@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).