From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E16522488B for ; Tue, 1 Jul 2025 08:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751359734; cv=none; b=TxrmOuASC9RG3ixHttRVq/z4YOev010nwFI4yi3lVbPyedWbYQx4+yq1w9oBT4tzCMJQMLqKV0ju9MQGVtBZwRchlJRqRwpqtFCbySJI9DPKMOwUCxsJY0dBnOtvz/pLGBTzkAAxzcsySHZgVOMoEUNLg7rCtssrXV2eTz5YDQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751359734; c=relaxed/simple; bh=DGBHFGIQFj3DI57v/KergKc6+HMEaz+DP4HpyZ/MxtE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=CW5+AqVb5dfqsh8cejjAJSHZzxWd6YYGjWcokO3U7TUaRTvJrwq5wQUNR3P+H+KGdJqFddfDbiPVM9Qa7O2X5O9RQEjimDHU1hyrfH+JKsBjcZ3F9fscX2AnlHa5Jbt+SeVyANC6GnPwa2b5QiqHOL2fApikvJscySObZZPlOqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=EvZITTKY; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="EvZITTKY" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-71173646662so31287087b3.2 for ; Tue, 01 Jul 2025 01:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1751359732; x=1751964532; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ham4MleQtpYSqIWPo8fq/MuoFtt+t8Ya59SZXOm39+s=; b=EvZITTKYDl5uL1ve1wLJnipv0bkLmS0L6fx3chyv8BvSs70JiIxRsLqL1cVwFUWFZm ebyxm0YSMkZtuTns9B0jtC757l7bd1gJM8CIOVMI3gO2+pg9X4Z5yAKrn4g9UXc+9IyC CT4t/PFh87odls6yrrlbaGp6E3rr73GVlhSdbbWtkSIGnrpi2DsQ8BIGzfJmialYSVNd 1gYU4eKxe7vPsnBZ894SqyXviLAZH8SvsByGStG4vued3wd6wH8DiNcWWKWf1RMt02rv rKZa3L/9r6Ikb76GXd4f6tnKn5/YlGWXqCVEAbmm8bYvPzF3A4ewfOtj5O/MXM2QMhAC mAXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751359732; x=1751964532; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ham4MleQtpYSqIWPo8fq/MuoFtt+t8Ya59SZXOm39+s=; b=JJbr7eRcvSY4EGzSOQElUy5swbW/g79HIvxhY0mxWy0H1xJj0QTJTvDA2T7/MsEWw9 oe1sZJvm9JFOoC8g8sM7r1xcHjDwUupHrKo6XCiR8/yfhatGTJfIqDuxT3obEpfC1nq8 6Q2NHYgsM3IoXiP+zOQ1HhpVHsLufOQ6cJLMajnN8CGr8FDhDNiL14OhnsNwvJ8Wk5SL /q/SWd2BuFkrCve5EenhpWx6wGFmO+4a6qAhAlJOwnrlM8uuCzu4XMXl6CaJ9BJzP1N/ CDHsWCDzDS6XomMK50vOIRGKyU9euwR1q4hFfnJBJDs5VHqVOfCw+RnLWCsfD6UJcOGT 4lRQ== X-Forwarded-Encrypted: i=1; AJvYcCUCTfoLdq61lmUBe5khCnWJ1U6wmVVxSAHCvZi7vGD9XPH2K1lxzUMBczUFBIa/Wtyxq2nVeNDrJR4E@vger.kernel.org X-Gm-Message-State: AOJu0Yz4HKUAnUOJhU7WRsv+5cANmjC4zP7sMDAmwQ/O1krMRMkYRmQC W19m+E/I4nnRe3JmacraQ1GTp8CVZI34muVmW+n1vBs0Ps1ncR9ueJDptbaQ/dH/xh9rsK5P+DT W/wuG96XOKM1Bh7T23cDVqvS+nxAJz8hf3j42FQ4F3w== X-Gm-Gg: ASbGncsF2vjFdDMri2j8ut1FGx3WyuUADgTA5UxeQ266eaAKMeCudOko9P1KbJweWL4 DYYyTwYszeq33dRY8oBaSBsarmZgMu8qluG5LqARTUINNrB9VuDL7QUNWX+jeJs8072PFB2Qlw1 le6PixtAAaFU5xoUMFvpzc4lV/05eTg5njzjGq0eaOQ0IXIcIL X-Google-Smtp-Source: AGHT+IExwbxuXz67r7i2U0Hj9e39nnEuFRzklLDURAXbWXk0DV903xSBiVjsaBHg1u3FdNeBklfefUYYXWQaY3P289M= X-Received: by 2002:a05:690c:45ca:b0:70e:29af:844a with SMTP id 00721157ae682-71517196047mr247551697b3.18.1751359731954; Tue, 01 Jul 2025 01:48:51 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250701-working_dma_0701_v2-v2-0-ab6ee9171d26@riscstar.com> <20250701-working_dma_0701_v2-v2-7-ab6ee9171d26@riscstar.com> In-Reply-To: From: Guodong Xu Date: Tue, 1 Jul 2025 16:48:41 +0800 X-Gm-Features: Ac12FXzG_24euqC2ksqQUMdli-9vCkce_uhDVNzQHQHTjfNnkSCnW6ua-Xfs0vo Message-ID: Subject: Re: [PATCH v2 7/8] riscv: dts: spacemit: Enable PDMA0 on Banana Pi F3 and Milkv Jupiter To: Krzysztof Kozlowski Cc: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , =?UTF-8?Q?Duje_Mihanovi=C4=87?= , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Alex Elder , Vivian Wang , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 1, 2025 at 3:36=E2=80=AFPM Krzysztof Kozlowski wrote: > > On 01/07/2025 07:37, Guodong Xu wrote: > > Enable the PDMA0 on the SpacemiT K1-based Banana Pi F3 and Milkv Jupite= r > > boards by setting its status to "okay". > > > > Signed-off-by: Guodong Xu > > --- > > v2: added pdma0 enablement on Milkv Jupiter > > --- > > arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 4 ++++ > > arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/ris= cv/boot/dts/spacemit/k1-bananapi-f3.dts > > index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..39133450e07f2cb9cb2247d= c0284851f8c55031b 100644 > > --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > > +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > > @@ -45,3 +45,7 @@ &uart0 { > > pinctrl-0 =3D <&uart0_2_cfg>; > > status =3D "okay"; > > }; > > + > > +&pdma0 { > > > Does not look like placed according to DTS coding style. What sort of > ordering Spacemit follows? > Agreed. We should establish a consistent ordering rule for SpacemiT board DTS files. According to the coding style documentation, there are two acceptable approaches for ordering node references in board DTS files: "When extending nodes in the board DTS via &label, the entries shall be ordered either alpha-numerically or by keeping the order from DTSI, where the choice depends on the subarchitecture." Refer to Documentation/devicetree/bindings/dts-coding-style.rst My preference would be alphabetical ordering for easy maintainability. Howe= ver, I'd like to hear Yixun's perspective on this before we standardize the approach across both board DTS files, BPI-F3 and MilkV Juptier. Thanks. Guodong > > > Best regards, > Krzysztof