From: Alexandru Ardelean <alex@shruggie.ro>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, krzysztof.kozlowski+dt@linaro.org,
perex@perex.cz, tiwai@suse.com, steffen.aschbacher@stihl.de
Subject: Re: [PATCH 2/4] ASoC: codecs: tas5720: add support for TAS5720A-Q1 (automotive) variant
Date: Sat, 28 Jan 2023 10:17:46 +0200 [thread overview]
Message-ID: <CAH3L5QrvuRuSi_5dOHSrhe6mK0ZTM3e7BzCUfR_Dx8uxkBKdhQ@mail.gmail.com> (raw)
In-Reply-To: <Y9E7a/erXV/xd3lz@sirena.org.uk>
On Wed, Jan 25, 2023 at 4:23 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Sun, Jan 15, 2023 at 09:33:45PM +0200, Alexandru Ardelean wrote:
>
> > static int tas5720_mute_soc_component(struct snd_soc_component *component, int mute)
> > {
> > + unsigned int reg, mask, val;
> > int ret;
> >
> > - ret = snd_soc_component_update_bits(component, TAS5720_DIGITAL_CTRL2_REG,
> > - TAS5720_MUTE, mute ? TAS5720_MUTE : 0);
> > + switch (tas5720->devtype) {
> > + case TAS5720A_Q1:
>
> This doesn't build:
My bad.
Will fix
>
> /build/stage/linux/sound/soc/codecs/tas5720.c:217:17: error: ‘tas5720’ undeclare
> d (first use in this function); did you mean ‘TAS5720’?
> 217 | switch (tas5720->devtype) {
> | ^~~~~~~
> | TAS5720
> /build/stage/linux/sound/soc/codecs/tas5720.c:217:17: note: each undeclared iden
> tifier is reported only once for each function it appears in
> /build/stage/linux/sound/soc/codecs/tas5720.c:214:33: error: unused variable ‘va
> l’ [-Werror=unused-variable]
> 214 | unsigned int reg, mask, val;
> | ^~~
> cc1: all warnings being treated as errors
next prev parent reply other threads:[~2023-01-28 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 19:33 [PATCH 1/4] ASoC: codecs: tas5720: split a tas5720_mute_soc_component() function Alexandru Ardelean
2023-01-15 19:33 ` [PATCH 2/4] ASoC: codecs: tas5720: add support for TAS5720A-Q1 (automotive) variant Alexandru Ardelean
2023-01-25 14:23 ` Mark Brown
2023-01-28 8:17 ` Alexandru Ardelean [this message]
2023-01-15 19:33 ` [PATCH 3/4] ASoC: tas5720: set bit 7 in ANALOG_CTRL_REG for TAS5720A-Q1 during probe Alexandru Ardelean
2023-01-15 19:33 ` [PATCH 4/4] ASoC: dt-bindings: add entry for TAS5720A-Q1 driver Alexandru Ardelean
2023-01-16 8:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH3L5QrvuRuSi_5dOHSrhe6mK0ZTM3e7BzCUfR_Dx8uxkBKdhQ@mail.gmail.com \
--to=alex@shruggie.ro \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=steffen.aschbacher@stihl.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).