From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A168C7619A for ; Wed, 22 Mar 2023 10:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjCVKlt (ORCPT ); Wed, 22 Mar 2023 06:41:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbjCVKls (ORCPT ); Wed, 22 Mar 2023 06:41:48 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD42461300 for ; Wed, 22 Mar 2023 03:41:45 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id d17so8057242wrb.11 for ; Wed, 22 Mar 2023 03:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679481704; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=skDnyQLe1JXdCg1sNQHqpeJHAlfAsnOpU7qQyP4hHOg=; b=GSamitR5gd+/UzbyXSgYPJV7PmQ5ceiqB2gRsLSYfgDBbvjxo2QYvkSXKnM5bEzeSD B7qXr4fCsv+cghc+QYyE/3ZBGrikeib607wQYkwUA47N5hn21hj8KNbODFSyOaowLCmt HPHZBYlYCXTcUyVZ51+0NsjdpDgw7A/Tw/Y8OL9NlKo6n2sc0ETcGhA3FBmN7xAfKzNU KUllCOt9xplQPWUCSboOZAIt8Hya1qLXR85iWUcCUu5sBpXnug3XV3C3hAgfzRUbLSQj KJlYcQsLqyxICGLivSBKQIgkLAnul/X98QbqzEz7QGxQnLBuY/Vieh5YC+LIVRXfF01E THBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679481704; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=skDnyQLe1JXdCg1sNQHqpeJHAlfAsnOpU7qQyP4hHOg=; b=7h6dPCllRgVsqyab4ZBf2fBwGTIr6SpR7BIr4XBAtHYHsoXG8jbqhd0J6pbcX8v42h TwODuYVY2Ftui6gXHtDqUnaB3chZ6Vc09UyCkmKdtoM0iMFK1I4PATY2DHhLidJKNADO hPxjr0XITvG0Fgyk4YUa67xpZ3zmwN1lnIuOaMlOizSKH7IO4htVwOar9Q5CLqHPF86I hq91rlHcubsJOeKaIn/4JxN915ojwJjV1MYJS8zzw8Jr7BKZ33HqwOqUDyrhkiwbxf+d vsAG9f3HSGxrMLXgsN4Z+lC86376Shpze+OAhHshVG/nlPcA8lcxMzV+TGP4h0wiOgo8 +uAA== X-Gm-Message-State: AO0yUKVypRWTWLVYp/4+XSMykiaH2gVluqsmBnM3h7r5CRhplGyQgIKh dhKNDVk0+0kcGS+Cri8mvuRvkSxfS16IE+GIMptMGg== X-Google-Smtp-Source: AK7set8wAPw5tK+KOLu3l95YMhBqfO34Pi6ONEtsWZgiwe84T8NwsFpmq2fBkotWjwqz/Ud4m6hn17Aj50DyVc2GhAM= X-Received: by 2002:a5d:6641:0:b0:2d0:58f9:a69 with SMTP id f1-20020a5d6641000000b002d058f90a69mr1153282wrw.4.1679481704118; Wed, 22 Mar 2023 03:41:44 -0700 (PDT) MIME-Version: 1.0 References: <20230321190118.3327360-1-bhupesh.sharma@linaro.org> <20230321190118.3327360-3-bhupesh.sharma@linaro.org> In-Reply-To: From: Bhupesh Sharma Date: Wed, 22 Mar 2023 16:11:32 +0530 Message-ID: Subject: Re: [PATCH 2/5] arm64: dts: qcom: sm6115: Add Crypto Engine support To: Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, andersson@kernel.org, bhupesh.linux@gmail.com, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, konrad.dybcio@linaro.org, vladimir.zapolskiy@linaro.org, rfoss@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 22 Mar 2023 at 02:09, Stephan Gerhold wrote: > > On Wed, Mar 22, 2023 at 12:31:15AM +0530, Bhupesh Sharma wrote: > > Add crypto engine (CE) and CE BAM related nodes and definitions to > > 'sm6115.dtsi'. > > > > Signed-off-by: Bhupesh Sharma > > --- > > arch/arm64/boot/dts/qcom/sm6115.dtsi | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > index c56738633431..b2d2cdde41fa 100644 > > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > @@ -664,6 +664,32 @@ usb_1_hsphy: phy@1613000 { > > status = "disabled"; > > }; > > > > + cryptobam: dma-controller@1b04000 { > > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > > + reg = <0x0 0x01b04000 0x0 0x24000>; > > + interrupts = ; > > + #dma-cells = <1>; > > + qcom,ee = <0>; > > + qcom,controlled-remotely; > > + num-channels = <8>; > > + qcom,num-ees = <2>; > > + iommus = <&apps_smmu 0x84 0x11>, > > + <&apps_smmu 0x86 0x11>, > > + <&apps_smmu 0x94 0x11>, > > + <&apps_smmu 0x96 0x11>; > > + }; > > + > > + crypto: crypto@1b3a000 { > > + compatible = "qcom,sm6115-qce", "qcom,sm8150-qce", "qcom,qce"; > > + reg = <0x0 0x01b3a000 0x0 0x6000>; > > + dmas = <&cryptobam 6>, <&cryptobam 7>; > > + dma-names = "rx", "tx"; > > + iommus = <&apps_smmu 0x84 0x11>, > > + <&apps_smmu 0x86 0x11>, > > + <&apps_smmu 0x94 0x11>, > > + <&apps_smmu 0x96 0x11>; > > If you apply the 0x11 mask to the stream ID then the last two items here > are identical to the first two (0x94 & ~0x11 = 0x84). Why are they > needed? They look redundant to me. Thanks, I will check them out and fix them in v2. Regards.