devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] arm64: dts: imx8mm-beacon: Enable Digitial Microphone
Date: Thu, 2 Mar 2023 07:28:28 -0600	[thread overview]
Message-ID: <CAHCN7xKKtCp52XVHd8_-+EvPvsx9hewsEdce=hsLov-0TY9dZA@mail.gmail.com> (raw)
In-Reply-To: <20220718053721.GB7333@pengutronix.de>

On Mon, Jul 18, 2022 at 12:37 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> Hi Adam,
>
> On Sun, Jul 17, 2022 at 01:09:58PM -0500, Adam Ford wrote:
> > There is a PDM microphone port on the baseboard which is connected to the
> > micfil controller.  Create a new sound card to support this interface.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > index 03266bd90a06..16444954f873 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > @@ -98,7 +98,7 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> >               enable-active-high;
> >       };
> >
> > -     sound {
> > +     sound-codec {
> >               compatible = "fsl,imx-audio-wm8962";
> >               model = "wm8962-audio";
> >               audio-cpu = <&sai3>;
> > @@ -111,6 +111,18 @@ sound {
> >                       "AMIC", "MICBIAS",
> >                       "IN3R", "AMIC";
> >       };
> > +
> > +     sound-micfil {
> > +             compatible = "fsl,imx-audio-card";
> > +             model = "imx-audio-micfil";
> > +             pri-dai-link {
> > +                     link-name = "micfil hifi";
> > +                     format = "i2s";
> > +                     cpu {
> > +                             sound-dai = <&micfil>;
> > +                     };
> > +             };
> > +     };
>
> Note the micfil works well with the simple-audio-card driver which might
> be an alternative here.

Sascha,

Sorry to resurrect an old thread.

I tried using the simple-audio-card, but it doesn't present me with an
audio card.  I don't get errors, but I don't get a card either.  Can
you point me to an example where someone did this?  I added debug code
to the simple-audio-card and I migrated an existing card, and I see
the debug code for the wm8962 CODEC, but not the micfil.  The Micfil
works just fine with the imx-audio-card, but I don't mind using the
simple-audio-card if it makes more sense.

adam
>
> Sascha
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2023-03-02 13:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-17 18:09 [PATCH] arm64: dts: imx8mm-beacon: Enable Digitial Microphone Adam Ford
2022-07-17 18:09 ` [PATCH 1/6] arm64: dts: imx8mn-beacon: " Adam Ford
2022-07-19  5:57   ` Ahmad Fatoum
2022-07-19 19:17     ` Adam Ford
2022-07-17 18:09 ` [PATCH 2/6] arm64: dts: imx8mn-beacon: Enable SPDIF Sound card Adam Ford
2022-07-17 18:09 ` [PATCH 3/6] arm64: dts: Associate easrc to the audio CODEC Adam Ford
2022-07-17 18:09 ` [PATCH 4/6] arm64: dts: imx8mm-beacon: Enable Digitial Microphone Adam Ford
2022-07-18  5:37   ` Sascha Hauer
2022-07-18 15:44     ` Adam Ford
2023-03-02 13:28     ` Adam Ford [this message]
2022-07-17 18:09 ` [PATCH 5/6] arm64: dts: imx8mm-beacon: Enable SPDIF Sound card Adam Ford
2022-07-17 18:10 ` [PATCH 6/6] arm64: defconfig: Enable imx-audio-card Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHCN7xKKtCp52XVHd8_-+EvPvsx9hewsEdce=hsLov-0TY9dZA@mail.gmail.com' \
    --to=aford173@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).