From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8426C433DF for ; Fri, 21 Aug 2020 06:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB63B207DA for ; Fri, 21 Aug 2020 06:10:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n/dLDodq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726002AbgHUGKP (ORCPT ); Fri, 21 Aug 2020 02:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgHUGKK (ORCPT ); Fri, 21 Aug 2020 02:10:10 -0400 Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8C23C061386 for ; Thu, 20 Aug 2020 23:10:09 -0700 (PDT) Received: by mail-vs1-xe43.google.com with SMTP id b26so280028vsa.13 for ; Thu, 20 Aug 2020 23:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6CmmgnaEzkt8llRqb27IcigQQKm5dN+mhMmyEDhAUQk=; b=n/dLDodqrSi2QB2NGxsN6yXv5Tg9CpKMDa66Um9hF+QjroPOw64gYF4gqU5woqMZtJ R+scaji4pRdg3ma/nDLaVbAN45CvPK0Lg4t1CCGsuWYChQaeeP/3NKBoDcLPMym+3VA/ 06dyXDJubrHzRGJhLGSTaOt9c1iJ4lRkpRu8mQLABuuQKDVlst69zZAgW5AqI0PUuAfD DXVYvnV0Qg7OgA3QcJgY1soIJkG5NLVQXkKbr51wM2ntqJGV9uAwtCIB7mKGfmBX8dPe 7A+ucfhGHlbbzP+Ige6COlCwpnrebTI2oImQqSyUzj50/wdcpV63M2rmL//XogsOosiz 8mqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6CmmgnaEzkt8llRqb27IcigQQKm5dN+mhMmyEDhAUQk=; b=U2bKDGiuB4sUc7zCYlHlzCQ87pqU/FDg0i0IfXK0WXaTmwN9IePdwEbGMhgOhRwTbw 7ijfWSBbdpNx4i3BcugFZQc5qJ738sydzrXAwAKeWM+Kc63gxlCDLECNDMLYAwTJmoN+ gLLCb36hL0QIHZiTYzBPyuVPqyn/Yx+CoMI4ypaa0r1MnH2pE+j/cvesyVBQvqJjQZfe 9Ke2/YNFopkM4bExQsFPrKXHfVKdJ+l80B7D6ThG8skqbjIecN8gagQ7A6iZj/4xjRbo 3jbBAQvXjZz2zJxoCEk2ohinRz+BaI9hHZ6OPbMn0LS4lRoeZ9zRre0P4vCZeRjtpo0T Hsow== X-Gm-Message-State: AOAM533fKPUpfooQR+vx+dZiAsOt5tYA2FzcE1wdKw5G4WWblkE5zCsR dFqPQ0nFiL/GMsB5aIgjaRFRnLLZGiDIvK5lU8rqol2I29pSOPKm X-Google-Smtp-Source: ABdhPJwqFMWt/HO4S1xxju+gQabMi09PJBxALNIfHrK5+TejL/lt4JhT2+ouM8Vp9voSiNYAA0oWGbAXgLK4YJCVsPk= X-Received: by 2002:a67:f897:: with SMTP id h23mr826426vso.9.1597990209107; Thu, 20 Aug 2020 23:10:09 -0700 (PDT) MIME-Version: 1.0 References: <20200715064909.9161-1-andy.tang@nxp.com> <20200715064909.9161-2-andy.tang@nxp.com> In-Reply-To: <20200715064909.9161-2-andy.tang@nxp.com> From: Amit Kucheria Date: Fri, 21 Aug 2020 11:39:58 +0530 Message-ID: Subject: Re: [PATCH 2/2 v2] arm64: dts: ls208xa: add more thermal zone support To: Yuantian Tang Cc: Shawn Guo , Li Yang , Rob Herring , lakml , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 15, 2020 at 12:25 PM wrote: > > From: Yuantian Tang > > There are 7 thermal zones in ls208xa soc. Add the other thermal zone > nodes to enable them. > > Signed-off-by: Yuantian Tang Reviewed-by: Amit Kucheria > --- > v2: > - remove useless alert trip > - add cooling-map to core cluster zones. > > .../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 141 ++++++++++++++++-- > 1 file changed, 132 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > index 41102dacc2e1..cc36c969dd9d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > @@ -79,20 +79,62 @@ > }; > > thermal-zones { > - cpu_thermal: cpu-thermal { > + ddr-controller1 { > polling-delay-passive = <1000>; > polling-delay = <5000>; > + thermal-sensors = <&tmu 1>; > > + trips { > + ddr-ctrler1-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + > + ddr-controller2 { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 2>; > + > + trips { > + ddr-ctrler2-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + > + ddr-controller3 { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 3>; > + > + trips { > + ddr-ctrler3-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + > + core-cluster1 { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > thermal-sensors = <&tmu 4>; > > trips { > - cpu_alert: cpu-alert { > - temperature = <75000>; > + core_cluster1_alert: core-cluster1-alert { > + temperature = <85000>; > hysteresis = <2000>; > type = "passive"; > }; > - cpu_crit: cpu-crit { > - temperature = <85000>; > + > + core-cluster1-crit { > + temperature = <95000>; > hysteresis = <2000>; > type = "critical"; > }; > @@ -100,14 +142,95 @@ > > cooling-maps { > map0 { > - trip = <&cpu_alert>; > + trip = <&core_cluster1_alert>; > cooling-device = > <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > - <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + core-cluster2 { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 5>; > + > + trips { > + core_cluster2_alert: core-cluster2-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + core-cluster2-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&core_cluster2_alert>; > + cooling-device = > <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > - <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + core-cluster3 { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 6>; > + > + trips { > + core_cluster3_alert: core-cluster3-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + core-cluster3-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&core_cluster3_alert>; > + cooling-device = > <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > - <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + core-cluster4 { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + thermal-sensors = <&tmu 7>; > + > + trips { > + core_cluster4_alert: core-cluster4-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + core-cluster4-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&core_cluster4_alert>; > + cooling-device = > <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > }; > -- > 2.17.1 >