From mboxrd@z Thu Jan 1 00:00:00 1970 From: Naveen Krishna Ch Subject: Re: [PATCH 1/3 v6] spi: s3c64xx: fix broken "cs_gpios" usage in the driver Date: Tue, 15 Jul 2014 09:33:21 +0530 Message-ID: References: <1405316506-27855-1-git-send-email-ch.naveen@samsung.com> <1405316506-27855-2-git-send-email-ch.naveen@samsung.com> <20140714172524.GH6800@sirena.org.uk> <20140714191533.GH6800@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140714191533.GH6800@sirena.org.uk> Sender: linux-samsung-soc-owner@vger.kernel.org To: Mark Brown Cc: Naveen Krishna Chatradhi , "linux-arm-kernel@lists.infradead.org" , spi-devel-general@lists.sourceforge.net, "linux-samsung-soc@vger.kernel.org" , grant.likely@secretlab.ca, jaswinder.singh@linaro.org, Kukjin Kim , cpgs@samsung.com, devicetree@vger.kernel.org, Tomasz Figa List-Id: devicetree@vger.kernel.org Hello Mark, On 15 July 2014 00:45, Mark Brown wrote: > On Tue, Jul 15, 2014 at 12:31:32AM +0530, Naveen Krishna Ch wrote: > >> in this case spi-s3c64xx.c will continue to ignore the generic SPI "cs-gpios" >> implementation. > >> I'm willing to implement any suggestion to fix this issue. > > The problem isn't what you're trying to do, the problem is verifying > that it has been done correctly - making sure that everything has been > accounted for in the change itself. Understand your concern. I will try to get it tested on as many platforms. -- Thanks for your review. (: Naveen :)