From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A5FECAAD5 for ; Tue, 30 Aug 2022 20:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbiH3UEP (ORCPT ); Tue, 30 Aug 2022 16:04:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231894AbiH3UD7 (ORCPT ); Tue, 30 Aug 2022 16:03:59 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF9C80511; Tue, 30 Aug 2022 13:02:46 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id n4so6976186qvt.7; Tue, 30 Aug 2022 13:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=sKUb5B3iNP9JffwnPezxUr8DBbsDdDXj2jgeVcIymz0=; b=A3OmI/NAKUxctLonPwyddHe16W4iMUhmCzfz5d7ui4tHfPU2KAupuIYIvihNmubfCx U3vHOuKN0gXyrem202xA4EJJil22adqKJnpSLAQ+/vEzVns0fiAbnF0StHMOqRYoyPlX p6MavOBNcnjfa2GrBNhEvPqowEdehgx5CSO5AQWshTW+tcES+lUq3iJ4oasuX972OtxP JML0J+IljDep1TmtJea9Z+lYqrmsvFmX5qoTxyZuPCGtNdLlI7qrQpFa1nPyZV8IKnUi EbFgOs8hJpOVeSTa/GoTXEyphH1U4KQWqo+dhrel8Qc5uKR05gZBZGfA+f2RckGKVzXy I0Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=sKUb5B3iNP9JffwnPezxUr8DBbsDdDXj2jgeVcIymz0=; b=y4el+/MB/tFSi2K+JlgCXLBjzmEyTZk4nhbWHBpP7S556tx5jD71wwAiR7hU/J+f0i 1V9E+7GelegvlBEwBF+fH+O/nRjGxUQNfTrjlQ9HJbYybIcpxNAfvKeXbwSzPogIQYvt 97XP+itJkgVHbBhjC1m6HihN1ndZUV3PslQAsTF6wM4B1haHOVf1jXEL9GOqkFask3FL 8ek4wiVQb3UK7KOtRHzzFSdRtBwv83FUSIvN6TfRenJOC+3rszqAWtkgbELREt/ejfp5 j4b68/TYoHASU0aIuAjUBYrHyriw9psZh3gYvmRl7RCk9crzpuBzw+3uWirNXLq9GApN csUA== X-Gm-Message-State: ACgBeo18LMqEVGz8Cltd2rLVrtPyGyWagQnLdTQ99/W8xL+d0PXAMMgz iMc02Wd406cWPh0mGKfNOLvBS3NSz1exYgoc83c= X-Google-Smtp-Source: AA6agR6Q1ZPykvZNTAf+ebF6H58KCUdYQ+AG5QbdDvM+SLqBqlhLVQsL5sAJCupIpLaWn9he2SzgKpwrDmEvMkESArI= X-Received: by 2002:a05:6214:2022:b0:497:2c03:61 with SMTP id 2-20020a056214202200b004972c030061mr16994102qvf.11.1661889763980; Tue, 30 Aug 2022 13:02:43 -0700 (PDT) MIME-Version: 1.0 References: <20220830110709.2037302-1-o.rempel@pengutronix.de> <20220830110709.2037302-3-o.rempel@pengutronix.de> In-Reply-To: <20220830110709.2037302-3-o.rempel@pengutronix.de> From: Andy Shevchenko Date: Tue, 30 Aug 2022 23:02:08 +0300 Message-ID: Subject: Re: [PATCH v1 3/3] iio: adc: tsc2046: silent spi_device_id warning To: Oleksij Rempel Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Linux Kernel Mailing List , linux-iio , devicetree Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 30, 2022 at 2:19 PM Oleksij Rempel wrote: > > Add spi_device_id to silent following warning: > SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc Missed period. ... > - dcfg = device_get_match_data(dev); Why remove this and duplicate the check below with the inverted conditional? > + if (!dev_fwnode(dev)) { > + const struct spi_device_id *id; > + > + id = spi_get_device_id(spi); > + dcfg = (const struct tsc2046_adc_dcfg *)id->driver_data; > + } else { > + dcfg = device_get_match_data(dev); > + } if (!dcfg) { ...try SPI ID... } if (!dfg) return -E... -- With Best Regards, Andy Shevchenko