From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Hawkins, Nick" <nick.hawkins@hpe.com>
Cc: "Verdun, Jean-Marie" <verdun@hpe.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] gpio: gxp: Add HPE GXP GPIO
Date: Thu, 8 Jun 2023 20:15:09 +0300 [thread overview]
Message-ID: <CAHp75VcCJoTSPFOcQ5FKTi=EuUTvwzxus1n+nuowPxa0WagQeQ@mail.gmail.com> (raw)
In-Reply-To: <B5D811E0-714D-45E5-818A-8AD18905AC29@hpe.com>
On Thu, Jun 8, 2023 at 5:58 PM Hawkins, Nick <nick.hawkins@hpe.com> wrote:
> > > Is there any documents available describing how regmap_gpio
> > > populates the GPIO lines? Does it automatically go through and add lines
> > > for each successful regmap_read and bits per byte?
>
> > Nope, it assumes one bit per register or something different if xlate
> > callback is defined. This is my understanding. That said, it might be
> > that this is a limitation which does not allow you to switch to that
> > library.
>
> Thank you for this feedback. After exploring the gpio_regmap it seems
> it does not fit my needs. Some of the GPIOs are a combination of
> several bits in a byte. For instance the Health LED or Identify LED have
> more than 2 states. If acceptable I believe the gxp-gpio-pl.c file should
> not use the gpio_regmap.
Yes, just mention this reasoning in the cover letter.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-08 17:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 1:42 [PATCH v3 0/5] ARM: Add GPIO support nick.hawkins
2023-06-06 1:42 ` [PATCH v3 1/5] dt-bindings: gpio: Add HPE GXP GPIO nick.hawkins
2023-06-06 9:30 ` Krzysztof Kozlowski
2023-06-06 1:42 ` [PATCH v3 2/5] gpio: gxp: " nick.hawkins
2023-06-06 9:22 ` andy.shevchenko
2023-06-06 18:51 ` Hawkins, Nick
2023-06-06 21:15 ` Andy Shevchenko
2023-06-07 16:07 ` Hawkins, Nick
2023-06-07 16:30 ` Andy Shevchenko
2023-06-07 20:45 ` Hawkins, Nick
2023-06-08 10:22 ` Andy Shevchenko
2023-06-08 14:58 ` Hawkins, Nick
2023-06-08 17:15 ` Andy Shevchenko [this message]
2023-06-06 1:42 ` [PATCH v3 3/5] dt-bindings: hwmon: hpe,gxp-fan-ctrl: remove fn2 and pl registers nick.hawkins
2023-06-06 9:30 ` Krzysztof Kozlowski
2023-06-06 1:42 ` [PATCH v3 4/5] hwmon: (gxp_fan_ctrl) Provide fan info via gpio nick.hawkins
2023-06-06 14:18 ` Guenter Roeck
2023-06-07 16:18 ` Hawkins, Nick
2023-06-06 1:42 ` [PATCH v3 5/5] MAINTAINERS: hpe: Add GPIO nick.hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcCJoTSPFOcQ5FKTi=EuUTvwzxus1n+nuowPxa0WagQeQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).