From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: linux-spi <linux-spi@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support
Date: Mon, 21 Dec 2020 19:24:42 +0200 [thread overview]
Message-ID: <CAHp75VcVDCL1VnUzmAmcDJ3deveXy-S8C4gaiKJGAts3V8FjSA@mail.gmail.com> (raw)
In-Reply-To: <CY4PR03MB29666C090DF4E882DFB5AA12F9C00@CY4PR03MB2966.namprd03.prod.outlook.com>
On Mon, Dec 21, 2020 at 5:19 PM Ardelean, Alexandru
<alexandru.Ardelean@analog.com> wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Monday, December 21, 2020 4:37 PM
> > On Mon, Dec 21, 2020 at 4:34 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
...
> > One nit, though...
> >
> > > > - "setup: can not select dual and quad at the same time\n");
> > > > + "setup: can not select any two of dual, quad and no-rx/tx "
> > > > + "at the same time\n");
> >
> > Can we avoid splitting string literals which are assumed to be on one line when
> > printed?
>
> It ends up at about 96 cols, but it's within limits.
> The patch may have been written before the new 100 col-width limit.
JFYI: string literals do not have limits (neither 80, nor 100).
It's a special category.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-12-21 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 14:19 [PATCH v5 1/3] spi: uapi: unify SPI modes into a single spi.h header Alexandru Ardelean
2020-12-21 14:19 ` [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support Alexandru Ardelean
2020-12-21 14:34 ` Andy Shevchenko
2020-12-21 14:36 ` Andy Shevchenko
2020-12-21 15:19 ` Ardelean, Alexandru
2020-12-21 17:24 ` Andy Shevchenko [this message]
2020-12-21 14:19 ` [PATCH v5 3/3] spi: dt-bindings: document zero value for spi-{rx,tx}-bus-width properties Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcVDCL1VnUzmAmcDJ3deveXy-S8C4gaiKJGAts3V8FjSA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Dragos.Bogdan@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).