From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB532C433E0 for ; Mon, 21 Dec 2020 18:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D33D22D49 for ; Mon, 21 Dec 2020 18:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbgLUSVX (ORCPT ); Mon, 21 Dec 2020 13:21:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgLUSVW (ORCPT ); Mon, 21 Dec 2020 13:21:22 -0500 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A082CC0613D3; Mon, 21 Dec 2020 10:21:07 -0800 (PST) Received: by mail-qv1-xf2b.google.com with SMTP id bd6so4834102qvb.9; Mon, 21 Dec 2020 10:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YQyxMOAZavE8xWe7epnSrp7G2ojv5j6Sb/NY3BtEg90=; b=EhkwNlHmCF+mbmZdrC06M89+vsXiApYrR+/qS/L6MPLb/pvSjaFJYYH6awt8PTWae2 27kLcdkE1a9okCsXHPMMmOwv89vzgvOLKGPcwcNndBT6ty3MyRjqeONUGfwIaX3j6pPg tTT378bWBdGN+nexdiWHlZX3N6uW7HnFcPmAgWz00rN7X9ocjBiKW7K5dDyxK7wVTksI eK7i1ySXUkklSJDoI8C1kdArK8orMTInF7eZr5G7tSq/AzYCWcWpiHe8i05T/sOQATK/ Ext7ImN/q/UEMzSa8/kBGFX2ecNISWKqszhFzH1WnpjqRxu+jysmW4VH/tw3p4yA2tDQ Chww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YQyxMOAZavE8xWe7epnSrp7G2ojv5j6Sb/NY3BtEg90=; b=Xo4qvHJrfLzVTmc0cBIzz71XwJAIkH8ir+CKAUXFUj7mkOg2lMFu6HC6rmcQbZvQu9 uf7HLAtnJDjZCYXqcmU/a9SVXDcLp5CyUloMEYKs3Px1+3kLEesdvLpAJgGxT/JIGeRt voTREClL4ojEWKMQwYVxlYMfmtG1TSz8EPbldCbrGGghsINHs7KJ4RyCiPfg896jT2yP kFZRD1YtZbUaPnWMVq2mCMHIP63pnYx6ihUbfkqBmaIVGmQFEu30yCzgz6/DhXwFbrM5 9CZO56VUsshw5WloJN2SbKxIo7mvz/N126+cuq2sNZJqfeTacgpb7xGDHpO/hHP9C68Z VuhQ== X-Gm-Message-State: AOAM532flmMZbk+0NqXiajMs/7YCrT8/QN9mxYaL4nRifKkg5WFQW7gw Z1An7wQxAc4LB+a/k0U3zyXnfCYfiu4CzFyJdwhKfO/ANjg= X-Google-Smtp-Source: ABdhPJx5AWw3ZNb2YvJW/rtqH2L4WLH+VXv1atxRvPxfxaY9gK+sKEVMevoq/0sY9BZzty5UBI4aZ6NX7Oy6hWq0I6k= X-Received: by 2002:a17:902:e98c:b029:da:cb88:f11d with SMTP id f12-20020a170902e98cb02900dacb88f11dmr17381890plb.17.1608571434318; Mon, 21 Dec 2020 09:23:54 -0800 (PST) MIME-Version: 1.0 References: <20201221141906.48922-1-alexandru.ardelean@analog.com> <20201221141906.48922-2-alexandru.ardelean@analog.com> In-Reply-To: From: Andy Shevchenko Date: Mon, 21 Dec 2020 19:24:42 +0200 Message-ID: Subject: Re: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support To: "Ardelean, Alexandru" Cc: linux-spi , devicetree , Linux Kernel Mailing List , "Bogdan, Dragos" , Mark Brown , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 21, 2020 at 5:19 PM Ardelean, Alexandru wrote: > > -----Original Message----- > > From: Andy Shevchenko > > Sent: Monday, December 21, 2020 4:37 PM > > On Mon, Dec 21, 2020 at 4:34 PM Andy Shevchenko > > wrote: ... > > One nit, though... > > > > > > - "setup: can not select dual and quad at the same time\n"); > > > > + "setup: can not select any two of dual, quad and no-rx/tx " > > > > + "at the same time\n"); > > > > Can we avoid splitting string literals which are assumed to be on one line when > > printed? > > It ends up at about 96 cols, but it's within limits. > The patch may have been written before the new 100 col-width limit. JFYI: string literals do not have limits (neither 80, nor 100). It's a special category. -- With Best Regards, Andy Shevchenko