From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH v3 0/2] add support for Socionext SynQuacer I2C controller
Date: Tue, 27 Feb 2018 17:59:20 +0200 [thread overview]
Message-ID: <CAHp75Vc_AUD2b5m-6CzKhAWJDudyObGs_oUUiFRk_BQv2QT7Xg@mail.gmail.com> (raw)
In-Reply-To: <20180227110107.30259-1-ard.biesheuvel@linaro.org>
On Tue, Feb 27, 2018 at 1:01 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> Add a binding and a driver for the I2C IP found in the Socionext SynQuacer
> SoC, which is essentially a rebranded version of the Fujitsu F_I2C controller.
>
Thanks for an update!
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
P.S. clk_prepare_enable() may fail in ->probe() as well.
> v3:
> - incorporate more of Andy's review comments (#2), especially regarding the
> bus speed and clock source handling for ACPI
> - patch #1 unchanged.
>
> v2:
> - incorporate Andy's review comments (#2)
> - patch #1 unchanged.
>
> Ard Biesheuvel (2):
> dt-bindings: i2c: add binding for Socionext SynQuacer I2C
> i2c: add support for Socionext SynQuacer I2C controller
>
> Documentation/devicetree/bindings/i2c/i2c-synquacer.txt | 29 +
> drivers/i2c/busses/Kconfig | 10 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-synquacer.c | 787 ++++++++++++++++++++
> 4 files changed, 827 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-synquacer.txt
> create mode 100644 drivers/i2c/busses/i2c-synquacer.c
>
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-02-27 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 11:01 [PATCH v3 0/2] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-02-27 11:01 ` [PATCH v3 1/2] dt-bindings: i2c: add binding for Socionext SynQuacer I2C Ard Biesheuvel
2018-03-01 14:28 ` Rob Herring
2018-03-01 14:30 ` Ard Biesheuvel
2018-02-27 11:01 ` [PATCH v3 2/2] i2c: add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-02-27 15:59 ` Andy Shevchenko [this message]
2018-02-27 17:01 ` [PATCH v3 0/2] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc_AUD2b5m-6CzKhAWJDudyObGs_oUUiFRk_BQv2QT7Xg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).