From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested Date: Fri, 23 Mar 2018 18:32:37 +0200 Message-ID: References: <20180321165848.89751-1-swboyd@chromium.org> <20180321165848.89751-4-swboyd@chromium.org> <97380342-c3aa-5d34-7b22-f6ebbab4bafe@codeaurora.org> <1521804964.23017.96.camel@linux.intel.com> <152182210780.178046.13284917877743312593@swboyd.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: Andy Shevchenko , Linus Walleij , Timur Tabi , Stephen Boyd , Linux Kernel Mailing List , linux-arm Mailing List , devicetree , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Grant Likely , "open list:GPIO SUBSYSTEM" List-Id: devicetree@vger.kernel.org On Fri, Mar 23, 2018 at 6:31 PM, Andy Shevchenko wrote: > On Fri, Mar 23, 2018 at 6:21 PM, Stephen Boyd wrote: > >> bitmap_zero(chip->valid_mask, max_gpios); >> for (i = 0; i < len; i++) >> set_bit(tmp[i], chip->valid_mask); > > Looking to this code I just realized it would be nice to have > > {of,device}_property_read_bitmask() where bitmask_parse() is called. > > Since it related to change a binding, I would really take couple of > days to hear other opinions. > > In the above case, you need to supply a string, like > > "1-5,16,18,25" s/bitmask/bitmap/g -- With Best Regards, Andy Shevchenko