Re: [PATCH v2 0/7] Add support for magnetometer Yamaha YAS537

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Mon, Jun 13, 2022 at 3:16 AM Jakob Hauser <jahau@rocketmail.com> wrote:
>
> This patchset adds YAS537 variant to the already existing driver for
> Yamaha YAS magnetometers.
>
> Patch 1 is a fix on the current driver.
> Patches 2-6 are cleanups and refactoring.
> Patch 7 finally adds the YAS537 variant.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
for patches 2-6.
Patch 1 is already reviewed, patch 7 needs a bit more work.

> Changes in v2:
>  - Reordered the patchset by moving patch 4 v1 to patch 1 v2.
>  - Removed patch 6 v1 ("Remove redundant defaults on switch devid")
>  - Accordingly, added "default:" to each switch statement in patch 7.
>  - Moved renamings in patch 7 v1 into a separate new patch 6 v2. I added
>    the "Reviewed-by:" tag of Linus to both patches, hope that's ok, else
>    feel free to comment.
>  - Removed regmap reads and related debug dumps in patch 7 in function
>    yas537_dump_calibration(). As this function now applies to version 1
>    only, replaced switch statement by if clause.
>  - Also removed "hard_offsets" debug dumps in that function.
>  - Fixed typo "initialized" in commit message of patch 7.

> Jakob Hauser (7):
>   iio: magnetometer: yas530: Change data type of hard_offsets to signed
>   iio: magnetometer: yas530: Change range of data in volatile register
>   iio: magnetometer: yas530: Correct scaling of magnetic axes
>   iio: magnetometer: yas530: Correct temperature handling
>   iio: magnetometer: yas530: Change data type of calibration
>     coefficients
>   iio: magnetometer: yas530: Rename functions and registers
>   iio: magnetometer: yas530: Add YAS537 variant
>
>  drivers/iio/magnetometer/Kconfig         |   4 +-
>  drivers/iio/magnetometer/yamaha-yas530.c | 790 +++++++++++++++++++----
>  2 files changed, 684 insertions(+), 110 deletions(-)
>
> --
> 2.35.1
>


-- 
With Best Regards,
Andy Shevchenko