From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78009CCA47B for ; Tue, 5 Jul 2022 18:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbiGESsA (ORCPT ); Tue, 5 Jul 2022 14:48:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232494AbiGESrq (ORCPT ); Tue, 5 Jul 2022 14:47:46 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22DB31B788; Tue, 5 Jul 2022 11:47:42 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-31bf3656517so117869937b3.12; Tue, 05 Jul 2022 11:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OUn0Dl36fUybJsR7SVUxdhvipccFobY5Xd3Ct0RmvM0=; b=LLsUFpXOv4vADqi/Z+1WbsuyTzVjRaEjfscsAli3kLOpdNNF/fg1rSfF2x19nVWf1g wBBZGjk6janX3qenOpHKKrAyuolm9qLk6VYgRlX+X5STjfp1Q6Ljp7l/XcwiqEIj+g4s ADTspCsqtE6/53G2ibgsjcKGj3RLC6ZWil3g1UTA2xiEyWYzeBsUu2DzCDC96jhF85mM vXI2TZqF2eiCuhNyo2NTHM3Nqx+VPcGF95eGlPB9scw47wikb04gtdJA/WBpXWmMsyHq WsWCmpVj3HQEQ9hxPbnK7EGAoSVq43PIbeWe8AjAmstetcCc+Sr2YEyWE0wuqSzHqlu7 xfeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OUn0Dl36fUybJsR7SVUxdhvipccFobY5Xd3Ct0RmvM0=; b=KU2tzmn7zCGpY32IFrDdTe2Q/81nzgjXvoEkAq6jb5kw6YZdngswgdNQa3LBjmfllG PqDeudG4uiZAZ+eVwgOaW9M1l8mbHLO+ndVIF98aO8jeiSsXzuovCwSpKeXDCO+YGMes VJhK0SHuk7ZmXplaTUepTUb0tsuO57sPg5c3h+trxLWFdouAdpdmMiSzVybwcH7AYDt7 tGMVjKoh5m70RWasyrztiVIvzUx8WzrOnEW/BuVndo43/Bk4AToxwaQO8vC1TL9YNwKV owwkfhVU3oJafGk9IfQ3FzczbtR2lN9yyy3+FBG+yH19boQkcEnjzy2xBGEiBsIoyB7g zgFQ== X-Gm-Message-State: AJIora+kWtDHboVnorVOmEQMEJw+bpx6iOen2PvjlTgmCGJ0A/wZFKXy 3fNyFFTbbYcOLXcOJSAhqK2m0mZ+WJ8CgPslmFA= X-Google-Smtp-Source: AGRyM1s+scTvZUsz+EFhE5GHHFUPVEKSvgjXH4mEu2fWSfrxbb0l4gyvoFkcbtEYwWVD17SjWWeUkoZd6n8XmmBTeso= X-Received: by 2002:a81:8397:0:b0:31c:8a02:3f6d with SMTP id t145-20020a818397000000b0031c8a023f6dmr16817651ywf.486.1657046861338; Tue, 05 Jul 2022 11:47:41 -0700 (PDT) MIME-Version: 1.0 References: <20220705163136.2278662-1-vincent.knecht@mailoo.org> <20220705163136.2278662-5-vincent.knecht@mailoo.org> In-Reply-To: <20220705163136.2278662-5-vincent.knecht@mailoo.org> From: Andy Shevchenko Date: Tue, 5 Jul 2022 20:47:05 +0200 Message-ID: Subject: Re: [PATCH v3 4/6] leds: is31fl319x: Use non-wildcard names for vars, structs and defines To: Vincent Knecht Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Linux LED Subsystem , devicetree , Linux Kernel Mailing List , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, "H. Nikolaus Schaller" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 5, 2022 at 6:32 PM Vincent Knecht wrote: > > In order to add real support for is31fl3190, is31fl3191 and is31fl3193, > rename variant-dependent elements to not use 319X where needed. > > 3190 suffix is used for is31fl3190, is31fl3191 and is31fl3193 circuits. > 3196 suffix is used for is31fl3196 and is31fl3199. > > Those two groups have different register maps, current settings and even > a different interpretation of the software shutdown bit: > https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3191_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf > > Rename variables, structures and defines in preparation of the splitting. > No functional nor behaviour change. ... > +static bool is31fl3196_volatile_reg(struct device *dev, unsigned int reg) > { /* volatile registers are not cached */ This is a rather non-standard place for comments. Are you going to address this in the future? > } ... > +static const struct reg_default is31fl3196_reg_defaults[] = { > + { IS31FL3196_CONFIG1, 0x00}, > + { IS31FL3196_CONFIG2, 0x00}, > + { IS31FL3196_PWM(0), 0x00}, > + { IS31FL3196_PWM(1), 0x00}, > + { IS31FL3196_PWM(2), 0x00}, > + { IS31FL3196_PWM(3), 0x00}, > + { IS31FL3196_PWM(4), 0x00}, > + { IS31FL3196_PWM(5), 0x00}, > + { IS31FL3196_PWM(6), 0x00}, > + { IS31FL3196_PWM(7), 0x00}, > + { IS31FL3196_PWM(8), 0x00}, While at it, add a space before }. This seems in many places like this. Perhaps address the rest in a separate patch? > }; -- With Best Regards, Andy Shevchenko