From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
"Philip Howard" <phil@gadgetoid.com>,
"Sean Young" <sean@mess.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org,
"Vincent Whitchurch" <vincent.whitchurch@axis.com>
Subject: Re: [PATCH V4 2/2] pwm: Add GPIO PWM driver
Date: Tue, 27 Feb 2024 22:47:05 +0200 [thread overview]
Message-ID: <CAHp75VdLJi2eiFmwjskMmp2adG8k7zO5aDRb-5=4eQKHhB=PXg@mail.gmail.com> (raw)
In-Reply-To: <4a6d8417-402e-4d40-96c5-15c2f1dba887@gmx.net>
On Tue, Feb 27, 2024 at 10:25 PM Stefan Wahren <wahrenst@gmx.net> wrote:
>
> Hi,
>
> Am 27.02.24 um 17:41 schrieb Andy Shevchenko:
> > On Sun, Feb 04, 2024 at 11:08:51PM +0100, Stefan Wahren wrote:
> > ...
> >
> >> + if (gpiod_cansleep(gpwm->gpio)) {
> >> + return dev_err_probe(dev, -EINVAL,
> >> + "sleeping GPIO %d not supported\n",
> >> + desc_to_gpio(gpwm->gpio));
> > Do not use plain GPIO numbers.
> Uwe already complained this, but i didn't receive a reply on the
> question how do we provide a useful log message (reference to the
> affected GPIO) here? AFAIK the GPIO names are optional.
You have a firmware node path, also you may add a label to GPIO, but
it's unrelated to the message (as it's constant).
%pfw
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-27 20:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 22:08 [PATCH V4 0/2] pwm: Add GPIO PWM driver Stefan Wahren
2024-02-04 22:08 ` [PATCH V4 1/2] dt-bindings: pwm: Add pwm-gpio Stefan Wahren
2024-02-04 22:47 ` Linus Walleij
2024-02-05 5:58 ` Dhruva Gole
2024-02-05 7:44 ` Krzysztof Kozlowski
2024-02-05 9:15 ` Uwe Kleine-König
2024-02-05 11:58 ` Stefan Wahren
2024-02-04 22:08 ` [PATCH V4 2/2] pwm: Add GPIO PWM driver Stefan Wahren
2024-02-04 22:50 ` Linus Walleij
2024-02-05 6:11 ` Dhruva Gole
2024-02-05 7:16 ` Stefan Wahren
2024-02-05 10:09 ` Uwe Kleine-König
2024-02-05 12:21 ` Stefan Wahren
2024-02-27 15:32 ` Chris Morgan
2024-02-27 16:59 ` Stefan Wahren
2024-02-28 12:43 ` Phil Howard
2024-02-29 8:45 ` Sean Young
2024-02-29 8:57 ` Sean Young
2024-02-27 16:41 ` Andy Shevchenko
2024-02-27 20:24 ` Stefan Wahren
2024-02-27 20:47 ` Andy Shevchenko [this message]
2024-02-28 18:06 ` Stefan Wahren
2024-02-05 5:55 ` [PATCH V4 0/2] " Dhruva Gole
2024-02-05 7:08 ` Stefan Wahren
2024-02-05 13:06 ` Phil Howard
2024-05-27 8:22 ` Linus Walleij
2024-05-27 8:44 ` Stefan Wahren
2024-05-27 9:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdLJi2eiFmwjskMmp2adG8k7zO5aDRb-5=4eQKHhB=PXg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=angelo.compagnucci@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=phil@gadgetoid.com \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vincent.whitchurch@axis.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).