Re: [PATCH v2 1/6] iio: adc: mp2629: fix wrong comparison of channel

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Tue, Jun 14, 2022 at 9:42 PM Saravanan Sekar <sravanhome@gmail.com> wrote:
>
> Input voltage channel enum is compared against iio address instead
> of channel.

the channel

...

I do not see a cover letter, but FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
for all patches except DT binding
Note, some of the comments regarding spelling were given, I believe
you are going to address them in v3.

> Fixes: 7abd9fb64682 ("iio: adc: mp2629: Add support for mp2629 ADC driver")
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> ---
>  drivers/iio/adc/mp2629_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mp2629_adc.c b/drivers/iio/adc/mp2629_adc.c
> index aca084f1e78a..e7fbfe92e884 100644
> --- a/drivers/iio/adc/mp2629_adc.c
> +++ b/drivers/iio/adc/mp2629_adc.c
> @@ -73,7 +73,7 @@ static int mp2629_read_raw(struct iio_dev *indio_dev,
>                 if (ret)
>                         return ret;
>
> -               if (chan->address == MP2629_INPUT_VOLT)
> +               if (chan->channel == MP2629_INPUT_VOLT)
>                         rval &= GENMASK(6, 0);
>                 *val = rval;
>                 return IIO_VAL_INT;
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko