From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Alexandru Lazar <alazar@startmail.com>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: Re: [PATCH v6 2/2] iio: adc: Add MAX1241 driver
Date: Thu, 2 Apr 2020 22:02:05 +0300 [thread overview]
Message-ID: <CAHp75VdeME1Bck2nFSW4r5PUA2mJDewEJZYZXhVhP-L-A-Nhig@mail.gmail.com> (raw)
In-Reply-To: <4431cacc-4af6-a497-5850-20dfceb588c1@metafoo.de>
On Thu, Apr 2, 2020 at 9:55 PM Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 4/2/20 8:45 PM, Andy Shevchenko wrote:
> > On Wed, Apr 1, 2020 at 9:47 PM Alexandru Lazar <alazar@startmail.com> wrote:
> >> Add driver for the Maxim MAX1241 12-bit, single-channel ADC.
> >>
> > Perhaps put data sheet link as Datasheet: tag here?
> >
> >> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> >> Signed-off-by: Alexandru Lazar <alazar@startmail.com>
> > ...
> >
> >> + indio_dev->name = spi_get_device_id(spi)->name;
> > Shouldn't be rather part number?
> > Jonathan?
>
> This is the part number as defined in the spi_device id table :)
Okay!
> +static const struct spi_device_id max1241_id[] = {
> + { "max1241", max1241 },
> + {}
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-02 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 18:51 [PATCH v6 0/2] Maxim MAX1241 driver Alexandru Lazar
2020-04-01 18:51 ` [PATCH v6 1/2] dt-bindings: iio: adc: Add MAX1241 bindings Alexandru Lazar
2020-04-01 18:51 ` [PATCH v6 2/2] iio: adc: Add MAX1241 driver Alexandru Lazar
2020-04-02 18:45 ` Andy Shevchenko
2020-04-02 18:55 ` Lars-Peter Clausen
2020-04-02 19:02 ` Andy Shevchenko [this message]
2020-04-03 12:09 ` Alexandru Lazar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdeME1Bck2nFSW4r5PUA2mJDewEJZYZXhVhP-L-A-Nhig@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alazar@startmail.com \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).