From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v8 0/3] gpio: add DT support for memory-mapped GPIOs Date: Sun, 8 May 2016 16:19:34 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Christian Lamparter Cc: "linux-gpio@vger.kernel.org" , devicetree , "linux-kernel@vger.kernel.org" , linux-arm Mailing List , =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= , Kumar Gala , Alexander Shiyan , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , Alexandre Courbot , Linus Walleij List-Id: devicetree@vger.kernel.org On Sun, May 8, 2016 at 4:08 PM, Christian Lamparter wrote: > This patch series adds device tree support for generic memory-mapped = GPIOs. > The GPIO library already allows drivers and architecture support code= to > reuse generic code for managing a GPIO chip. Currently, a developer h= as > to create a platform device "basic-mmio-gpio" and attach a bgpio_pdat= a > platform data structure to make use of it. However, for architectures > which rely on the device tree to enumerate devices, creating custom > platform devices is another extra step that can be avoided by having > direct support via a device tree binding. > > I initially came across this patch [0] from =C3=81lvaro Fern=C3=A1nde= z Rojas, > while looking for an easy way to add support for the GPIO of my > WD MyBook Live [1] (APM82181). His generic approach patch allowed > me to easily get the GPIO (and the connected LEDs, buttons, gpiohogs) > up and running. Even thought, Mr. Fernandez initially developed it > for his work on the brcm63xx [2]. > > The third patch (which can be applied at a later time) moves gpio-clp= s711x, > gpio-ge, gpio-moxart and gpio-ts4800 into gpio-mmio.c. The old driver= files > and makefile entries have been removed. The Kconfig entries for these > drivers are kept for compatibility reasons. > > And finally, the most important stat about the series: > >>> 336 insertions(+), 380 deletions(-) <<< > It still removes more lines than it adds! > > Thanks! > > [0] > [1] > [2] > =46WIW: Reviewed-by: Andy Shevchenko > changelog: > > v7 -> v8: > - removed ngpio property parser and most flags parsers > - converted clps711x to switch case for GPIO > - retained original Kconfig syms which now select GPIO_GENERI= C_PLATFORM > > v6 -> v7: > - finally made a PATCH series (based on linux-gpio devel bran= ch) > - added Rob Herring's ACK to the dt bindings > - cc'd clps711x, gpio-ge, moxart and ts4800 authors for drive= r > changes. > > v5 -> v6: > - rewrote bindings and driver patch to fit the wd,mbl-gpio > - unified parser code for gpio-ge, gpio-moxart and gpio-ts480= 0 > - fixed gpio chip's base being overwritten with bogus "0" > - fixed compat driver crash when reload gpio-generic.ko modul= e > - dropped already applied patches from the series > - rebased code on linus' devel tree > - moved dt bindings patch to the top of the series > > v4 -> v5: > - reverted rename of gpio-mmio.c back to gpio-generic.c > - fixed Andy Shevchenko's comments > - consolidated changes from clps711x, gpio-ge, gpio-moxart an= d > gpio-ts4800 into one patch. > > v3 -> v4: > - renamed gpio-generic.c to gpio-mmio.c > - changed compat. string to "linux,gpio-mmio" > - integrated Cirrus clps711x driver > - integrated GE FGPA gpio-ge driver > - integrated MOXA ART GPIO driver > - integrated TS4800 gpio driver > - reshuffled patches, reworded commits, fixed spelling errors= , etc. > > Christian Lamparter (2): > gpio: dt-bindings: add wd,mbl-gpio bindings > gpio: move clps711x, moxart, ts4800 and gpio-ge into gpio-mmio > > =C3=81lvaro Fern=C3=A1ndez Rojas (1): > gpio: mmio: add DT support for memory-mapped GPIOs > > .../devicetree/bindings/gpio/wd,mbl-gpio.txt | 38 +++ > drivers/gpio/Kconfig | 16 +- > drivers/gpio/Makefile | 4 - > drivers/gpio/gpio-clps711x.c | 91 ------- > drivers/gpio/gpio-ge.c | 114 -------- > drivers/gpio/gpio-mmio.c | 288 +++++++++++= +++++++++- > drivers/gpio/gpio-moxart.c | 84 ------ > drivers/gpio/gpio-ts4800.c | 81 ------ > 8 files changed, 336 insertions(+), 380 deletions(-) > create mode 100644 Documentation/devicetree/bindings/gpio/wd,mbl-gpi= o.txt > delete mode 100644 drivers/gpio/gpio-clps711x.c > delete mode 100644 drivers/gpio/gpio-ge.c > delete mode 100644 drivers/gpio/gpio-moxart.c > delete mode 100644 drivers/gpio/gpio-ts4800.c > > -- > 2.8.1 > --=20 With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html