From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jakob Hauser <jahau@rocketmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
phone-devel@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,"
<~postmarketos/upstreaming@lists.sr.ht>
Subject: Re: [PATCH v2 7/7] iio: magnetometer: yas530: Add YAS537 variant
Date: Mon, 13 Jun 2022 17:22:53 +0200 [thread overview]
Message-ID: <CAHp75Ve3ydACAQnHR0rgPHEU9kSLYj-t6dU96gxDLPWKfnmP0g@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfFwSQ6bk=TMLiyA1j-AsafjGdVFbTTHJJ67C8zeYfz8Q@mail.gmail.com>
On Mon, Jun 13, 2022 at 5:20 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Jun 13, 2022 at 3:18 AM Jakob Hauser <jahau@rocketmail.com> wrote:
Forgot to add that please try to split even more preparatory patches.
For example, you may convert existing code to stubs / switch-cases /
etc and in the last patch just add the new case or new function /
branch.
...
> > + /*
> > + * Raw temperature value t is number of counts. A product description
the number
> > + * of YAS537 mentions a temperature resulution of 0.05 °C/count.
>
> resolution
>
> > + * A readout of the t value at ca. 20 °C returns approx. 8120 counts.
> > + *
> > + * 8120 counts x 0.05 °C/count corresponds to a range of 406 °C.
> > + * 0 counts would be at theoretical -386 °C.
> > + *
> > + * The formula used for YAS530/532 needs to be adapted to this
> > + * theoretical starting temperature, again calculating with 1/10:s
> > + * of degrees Celsius and finally multiplying by 100 to get milli
> > + * degrees Celsius.
> > + */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-13 18:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1655081082.git.jahau.ref@rocketmail.com>
2022-06-13 1:15 ` [PATCH v2 0/7] Add support for magnetometer Yamaha YAS537 Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 1/7] iio: magnetometer: yas530: Change data type of hard_offsets to signed Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 2/7] iio: magnetometer: yas530: Change range of data in volatile register Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 3/7] iio: magnetometer: yas530: Correct scaling of magnetic axes Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 4/7] iio: magnetometer: yas530: Correct temperature handling Jakob Hauser
2022-06-13 15:01 ` Andy Shevchenko
2022-06-15 21:18 ` Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 5/7] iio: magnetometer: yas530: Change data type of calibration coefficients Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 6/7] iio: magnetometer: yas530: Rename functions and registers Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 7/7] iio: magnetometer: yas530: Add YAS537 variant Jakob Hauser
2022-06-13 15:20 ` Andy Shevchenko
2022-06-13 15:22 ` Andy Shevchenko [this message]
2022-06-15 21:51 ` Jakob Hauser
2022-06-15 21:43 ` Jakob Hauser
2022-06-15 22:00 ` Jakob Hauser
2022-06-18 14:15 ` Jonathan Cameron
2022-06-13 15:23 ` [PATCH v2 0/7] Add support for magnetometer Yamaha YAS537 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Ve3ydACAQnHR0rgPHEU9kSLYj-t6dU96gxDLPWKfnmP0g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jahau@rocketmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).