From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D294FC433EF for ; Tue, 3 May 2022 14:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbiECOIR (ORCPT ); Tue, 3 May 2022 10:08:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236230AbiECOIR (ORCPT ); Tue, 3 May 2022 10:08:17 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F29C521274; Tue, 3 May 2022 07:04:43 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id m20so33617722ejj.10; Tue, 03 May 2022 07:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uXCKqvLKkB4bXBbfle8OmINHHiIG/p2IXITk55h5KgU=; b=nS+pd5b5Y8vYmII3eSWJN2Lpt8idlIk6j+bktKQncl+ZLXprPbsMVnULqAOu0yGVpX Dkxw++aKU56zFZI8aK1HjXdgl98htcgKcO9k0IP+QQUDb5xbIoh0QnYXE3Ncmx4drsZB PSeTk5h8k6bRoJwUEoZV1JVbDGMXuj9D/h3wUXN1DS/XCXb6z8xT0Stf4/EqFW/UKUmJ gssnq9PSR1r34wW/lnkXyUoNvXLZ94idCNt6fY5daulany5zr+YXzrCm7GoH6bLNhDJ8 WRJJINiS/bevITBjvgGsPBPhY0tDuBE8K8R3xzAe7vavl8X+SHxMjwirDdk6ALYhcAJG 6NVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uXCKqvLKkB4bXBbfle8OmINHHiIG/p2IXITk55h5KgU=; b=DEbN9EaP1P6bjv3F8b/sJ6q2Ye9JSj6LBHa9Ge9DYEeWA2L8rH2Sj2K4+cRFq57vSB DwZ54PlaPh8JmnVQVf1qegj+gZZZYlGMQJaaH8Y3ENCVJw7OwE6981bujBEbcBt9JYyc CLtED2gtwTx/VfEFtWeQvjR4b6hoca6PeT57x7F653ISbZ5Dk6Eaz/kKJ4dIm2SQ2Gat IxyapqyCdmWomDQOgu1gDo7seak9w1W/VNKxcUhlrFOJgp6pErrc1aea6jb/1VkfKzXE tjsKfq8/v7WPUPhvyU6iZBlO/Pvez7uOpqkZZ5IzkajLZUcGyjXqrAA2SjML/YF8/l6G BPPw== X-Gm-Message-State: AOAM531D1jaZo2v+lzZr/r3E0auAhZLAKj7LDBECzvOfi6LCGVFSw7Pb vEQ6nZiYxvOR8cohV/Z9ZlrllwsA9G6VPLJ5Gd0= X-Google-Smtp-Source: ABdhPJw5mejn9tBEu18+E0KV5pNN9CQoBPtNOkfQWMp7usK7nHOEoSTTKL2x2iKOTKRWcwLyBQHb6j5LAIQF+H9Y42w= X-Received: by 2002:a17:907:86a1:b0:6f4:63ae:768 with SMTP id qa33-20020a17090786a100b006f463ae0768mr7442763ejc.639.1651586682466; Tue, 03 May 2022 07:04:42 -0700 (PDT) MIME-Version: 1.0 References: <20220426131102.23966-13-andrea.merello@gmail.com> <202204271554.EiuIRNPI-lkp@intel.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 3 May 2022 16:04:06 +0200 Message-ID: Subject: Re: [v5 12/14] iio: imu: add BNO055 serdev driver To: Andrea Merello Cc: kernel test robot , Jonathan Cameron , Mauro Carvalho Chehab , linux-iio , Linux Kernel Mailing List , devicetree , kbuild-all@lists.01.org, Lars-Peter Clausen , Rob Herring , Matt Ranostay , Alexandru Ardelean , jmondi , Andrea Merello Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 3, 2022 at 3:30 PM Andrea Merello wrote: > > Il giorno mar 3 mag 2022 alle ore 09:48 Andrea Merello > ha scritto: > > [...] > > > > You need to add a C-file with the only line > > > > > > #include <..._trace.h> > > > > > > And drop that include from the _core.c. > > > > Hum, I'm a bit confused here: the bno055_ser_core.c file explicitly > > looks for that tracepoints (e.g. it calls trace_send_chunks() and > > friends); dropping the include prevents build here because there would > > be no definition for those tracepoints. > > > > There is already a C file bno055_ser_trace.c that just contains the > > said include and it defines CREATE_TRACE_POINTS; I see other drivers > > like dwc3 do the same.. > > Oops.. it turned out that I just had this almost-empty C file as > untracked in my git tree, and it ended up not being included in > patches also. Being it laying in my src tree caused the build to > succeed. > > I have been misled by the other problem I (still) have (below); I was > focused on the wrong thing, sorry. So, there are two reports: 1) missed C file; 2) possible missed prototype. To solve 1) you need to add the C file to the patch. To solve 2) you need either declare it static or put it into the header file (I haven't checked deeply which one is your case). > > But my problem is that I cannot reproduce the issue found by the bot: > > the compiler that is downloaded by the script doesn't run on my build > > box because it wants a newer libc (I was hoping that those compilers > > were statically linked, but they aren't), while any other attempt I > > did with other older compilers resulted in either successful build or > > failed with other weird, apparently unrelated, errors about relocation > > issues (of course I tried with the arch and config used by the build > > bot). You may use compilers from kernel.org that don't require any libc at all (only good for kernel compilation). > > Is there any build farm publicly available or something like that? Not of my knowledge. -- With Best Regards, Andy Shevchenko