From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Eddie James <eajames@linux.ibm.com>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
vishwa@linux.ibm.com
Subject: Re: [PATCH v2 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip
Date: Mon, 3 Aug 2020 19:42:17 +0300 [thread overview]
Message-ID: <CAHp75VevG65uuE4Vv49tSdvpNnxE7AC7W_QR2s8twCPZ=4da_g@mail.gmail.com> (raw)
In-Reply-To: <20200803145055.5203-3-eajames@linux.ibm.com>
On Mon, Aug 3, 2020 at 5:51 PM Eddie James <eajames@linux.ibm.com> wrote:
>
> IBM created an implementation of the PCA9552 on a PIC16F
> microcontroller. The I2C device addresses are different from the
> hardware PCA9552, so add a new compatible string and associated
> platform data to be able to probe this device.
...
> pca9550,
> pca9551,
> pca9552,
> + ibm_pca9552,
> pca9553,
I would rather not mix like this, but use alpha order, for example.
It's better to read and see which devices are supported by vendor.
...
> },
> + [ibm_pca9552] = {
> + },
> [pca9553] = {
Ditto.
...
> { "pca9550", pca9550 },
> { "pca9551", pca9551 },
> { "pca9552", pca9552 },
> + { "ibm-pca9552", ibm_pca9552 },
> { "pca9553", pca9553 },
Ditto.
...
> { .compatible = "nxp,pca9550", .data = (void *)pca9550 },
> { .compatible = "nxp,pca9551", .data = (void *)pca9551 },
> { .compatible = "nxp,pca9552", .data = (void *)pca9552 },
> + { .compatible = "ibm,pca9552", .data = (void *)ibm_pca9552 },
> { .compatible = "nxp,pca9553", .data = (void *)pca9553 },
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-03 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 14:50 [PATCH v2 0/2] leds: pca955x: Add IBM software implemenation of the PCA9552 chip Eddie James
2020-08-03 14:50 ` [PATCH v2 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James
2020-08-12 19:57 ` Rob Herring
2020-08-17 20:25 ` Pavel Machek
2020-08-03 14:50 ` [PATCH v2 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James
2020-08-03 16:42 ` Andy Shevchenko [this message]
2020-08-03 20:51 ` Pavel Machek
2020-08-07 8:15 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VevG65uuE4Vv49tSdvpNnxE7AC7W_QR2s8twCPZ=4da_g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=eajames@linux.ibm.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=vishwa@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).