From: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Daniel Baluta <daniel.baluta-3arQi8VN3Tc@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
dl-linux-imx <linux-imx-3arQi8VN3Tc@public.gmane.org>,
Cosmin Samoila <cosmin.samoila-3arQi8VN3Tc@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"wakasugi.jb-r6lgfPJHJciWyREYz5tgSuqrae++aQT8@public.gmane.org"
<wakasugi.jb-r6lgfPJHJciWyREYz5tgSuqrae++aQT8@public.gmane.org>,
"mihai.serban-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<mihai.serban-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"S.j. Wang" <shengjiu.wang-3arQi8VN3Tc@public.gmane.org>,
"alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org"
<alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>,
"mihai.serban-3arQi8VN3Tc@public.gmane.org"
<mihai.serban-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver
Date: Thu, 1 Feb 2018 16:46:56 +0200 [thread overview]
Message-ID: <CAHp75VfydH+9ABZRbV++Od3+wnvQdzXyyDFtfi-1FnOUYjOXQQ@mail.gmail.com> (raw)
In-Reply-To: <20180201134840.GA10785-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Thu, Feb 1, 2018 at 3:48 PM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Thu, Feb 01, 2018 at 03:20:38PM +0200, Andy Shevchenko wrote:
>> On Thu, Feb 1, 2018 at 11:05 AM, Daniel Baluta <daniel.baluta-3arQi8VN3Tc@public.gmane.org> wrote:
>
>> >> > Signed-off-by: Junichi Wakasugi <wakasugi.jb-r6lgfPJHJciWyREYz5tgSuqrae++aQT8@public.gmane.org>
>> >> > Signed-off-by: Mihai Serban <mihai.serban-3arQi8VN3Tc@public.gmane.org>
>> >> > Signed-off-by: Shengjiu Wang <shengjiu.wang-3arQi8VN3Tc@public.gmane.org>
>> >> > Signed-off-by: Daniel Baluta <daniel.baluta-3arQi8VN3Tc@public.gmane.org>
>> >> 4 authors of the code?!
>
>> > The code has a very long history. I will add under each SoB the specific
>> > contribution.
>
>> > Mihai got the code from Junichi and reworked it for 4.9. Then Shengjiu and
>> > me added various features and cleanups.
>
>> > Any other suggestion?
>
>> Yes, please, put detailed credits in commit message to not shock
>> people with so many SoB w/o explanation why.
>
> Honestly the signoffs above are nothing unusual for a driver contributed
> by a vendor - things are often bouncing around internally for ages and
> it's good to keep credits for people.
We have Co-developed-by: for the authors.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-01 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 12:57 [PATCH] ASoC: codecs: Add support for AK5558 ADC driver Daniel Baluta
2018-01-31 16:12 ` Andy Shevchenko
2018-02-01 9:05 ` Daniel Baluta
2018-02-01 13:20 ` Andy Shevchenko
2018-02-01 13:48 ` Mark Brown
[not found] ` <20180201134840.GA10785-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-01 14:46 ` Andy Shevchenko [this message]
2018-02-02 15:06 ` Mark Brown
2018-02-02 16:09 ` Andy Shevchenko
[not found] ` <1517403459-6668-1-git-send-email-daniel.baluta-3arQi8VN3Tc@public.gmane.org>
2018-01-31 16:20 ` Fabio Estevam
2018-01-31 16:56 ` Andy Shevchenko
[not found] ` <CAOMZO5BToV0OKEc_f8M1=zSL-X=qSXnokFyEfEEX2tGTUO=a-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-31 17:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfydH+9ABZRbV++Od3+wnvQdzXyyDFtfi-1FnOUYjOXQQ@mail.gmail.com \
--to=andy.shevchenko-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=cosmin.samoila-3arQi8VN3Tc@public.gmane.org \
--cc=daniel.baluta-3arQi8VN3Tc@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
--cc=linux-imx-3arQi8VN3Tc@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mihai.serban-3arQi8VN3Tc@public.gmane.org \
--cc=mihai.serban-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=shengjiu.wang-3arQi8VN3Tc@public.gmane.org \
--cc=wakasugi.jb-r6lgfPJHJciWyREYz5tgSuqrae++aQT8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).