From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABDB1C19F2C for ; Wed, 3 Aug 2022 17:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238358AbiHCRfX (ORCPT ); Wed, 3 Aug 2022 13:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238325AbiHCRfU (ORCPT ); Wed, 3 Aug 2022 13:35:20 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C27DD8A for ; Wed, 3 Aug 2022 10:35:18 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id b96so12058177edf.0 for ; Wed, 03 Aug 2022 10:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t7mzK+VsqxBbknsxZ5Y86hkmSLWbQ885cOUS2ErnhsQ=; b=jNNBA5NQLHsI0JyVIXzvuhIkTOOmyLoWRAHk03bJUHB6YpbpNC0an7pMlGB6lZz/ee o89HDMIE3QpAs55xNUvZxZn1oPl3DF3vvQ+soHxaMVh1mRr4z4dl9iaSx23EpupA6TL7 pJkVZlLM9DMFjHlOyycAlG/aAP0fVcwFY3iQ80PSCCcnV+SZXRIhI9+oEvaBliFe2A91 MPomkiS5rMbCbgHRdkvp4vk4B8hw57pjKD3s6vomjU4Z/xyPMtwZFnB4Mm8TiCUwuIOl tjKGNuEy3b37Edcu42Epg6SU3TtkwZAL3Gdy5Un8TEC5s+ZHtxOVEdVZJSNacV/nYxMf PMXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t7mzK+VsqxBbknsxZ5Y86hkmSLWbQ885cOUS2ErnhsQ=; b=vYMMN1OKHQBokl0XuSab6VFzymjWnvfoVTWikQYLLVnVLsN8s2WIQGnQuWt/8cVWoy lHqheDazrwngkH1WEc6AZOWS18KAZPtvacoehzd5330Sdfjp8gq+f+G/QX9Gct5+1e7p qCYv2DNylXWXk+pQbXiWZHlW3WpLG6eV40LBvFVb/zqUeHQsB6YynrzpcvZorwNNbKQH UmS/WTybIFYIpGAMLSo4Oy6ms2cZQXjJWh/bIdV8uUFFObvj8Rf/ZXc4UQ/IopldSKyf tE191McwjEKt6lEjtPh2nKiUtA1QnkTmQ+gw6LL1/K4GRuy8mAOA5hfBcMkTEPH6YVf2 ++bQ== X-Gm-Message-State: AJIora9cigaoiNfobbZffUc16ruOijjX7oW46KLhUpG+4hU4KK8lfCkv Vo0KeRB0f/8Oqz6zWcBsrWcCVlLKAlPzHp7tcMWIvw== X-Google-Smtp-Source: AGRyM1vinRALJaPLSYSNk3fACJZIJzEkUVcr5c6Q656EARzdy9R6EVN6hz5dbO4THnpK7R2eFuigKb95EoAGwHAFY/0= X-Received: by 2002:a05:6402:430e:b0:43d:1cf6:61ec with SMTP id m14-20020a056402430e00b0043d1cf661ecmr25679481edc.194.1659548117129; Wed, 03 Aug 2022 10:35:17 -0700 (PDT) MIME-Version: 1.0 References: <20220802175755.6530-1-sudip.mukherjee@sifive.com> <20220802175755.6530-5-sudip.mukherjee@sifive.com> In-Reply-To: From: Sudip Mukherjee Date: Wed, 3 Aug 2022 18:35:06 +0100 Message-ID: Subject: Re: [PATCH 04/11] spi: dw: use TMOD_RO to read in enhanced spi modes To: Mark Brown Cc: Serge Semin , Rob Herring , Krzysztof Kozlowski , Greentime Hu , Jude Onyenegecha , William Salmon , Adnan Chowdhury , Ben Dooks , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jeegar Lakhani Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Mark, On Tue, Aug 2, 2022 at 8:13 PM Mark Brown wrote: > > On Tue, Aug 02, 2022 at 06:57:48PM +0100, Sudip Mukherjee wrote: > > When we are using the enhanced spi modes we can not use EEPROM Read. > > The Synopsys datasheet mentions EEPROM Read is not applicable in > > enhanced SPI modes. We will need to use Receive only mode. > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/spi/spi-dw-core.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c > > index 8c84a2e991b5..8e624620864f 100644 > > --- a/drivers/spi/spi-dw-core.c > > +++ b/drivers/spi/spi-dw-core.c > > @@ -727,7 +727,10 @@ static int dw_spi_exec_mem_op(struct spi_mem *mem, const struct spi_mem_op *op) > > cfg.dfs = 8; > > cfg.freq = clamp(mem->spi->max_speed_hz, 0U, dws->max_mem_freq); > > if (op->data.dir == SPI_MEM_DATA_IN) { > > - cfg.tmode = DW_SPI_CTRLR0_TMOD_EPROMREAD; > > + if (enhanced_spi) > > + cfg.tmode = DW_SPI_CTRLR0_TMOD_RO; > > + else > > + cfg.tmode = DW_SPI_CTRLR0_TMOD_EPROMREAD; > > This is fixing the previous commit... This was not actually meant to be a fixup patch. I intentionally made it separate so that "enhanced_spi" is introduced in the previous patch, and then modified the tmode read protocol in this patch based on enhanced_spi. But I can merge it with the previous patch like you have suggested. -- Regards Sudip