* Re: [PATCH] ARM64: dts: imx8mm-evk: Assigned clocks for audio plls
[not found] <20191016103513.13088-1-shengjiu.wang@nxp.com>
@ 2019-10-26 12:46 ` Shawn Guo
2020-05-19 20:29 ` Tim Harvey
1 sibling, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2019-10-26 12:46 UTC (permalink / raw)
To: S.j. Wang
Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
Anson Huang, Jacky Bai, Jun Li, Leonard Crestez, Daniel Baluta,
daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Oct 16, 2019 at 10:36:05AM +0000, S.j. Wang wrote:
> Assign clocks and clock-rates for audio plls, that audio
> drivers can utilize them.
>
> Add dai-tdm-slot-num and dai-tdm-slot-width for sound-wm8524,
> that sai driver can generate correct bit clock.
>
> Fixes: 13f3b9fdef6c ("arm64: dts: imx8mm-evk: Enable audio codec wm8524")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
As a practise, we use prefix 'ARM: ...' for arch/arm/ and 'arm64: ...'
for arch/arm64/ patches.
I fixed up the prefix and applied the patch.
Shawn
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ARM64: dts: imx8mm-evk: Assigned clocks for audio plls
[not found] <20191016103513.13088-1-shengjiu.wang@nxp.com>
2019-10-26 12:46 ` [PATCH] ARM64: dts: imx8mm-evk: Assigned clocks for audio plls Shawn Guo
@ 2020-05-19 20:29 ` Tim Harvey
1 sibling, 0 replies; 2+ messages in thread
From: Tim Harvey @ 2020-05-19 20:29 UTC (permalink / raw)
To: S.j. Wang
Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
dl-linux-imx, Anson Huang, Jacky Bai, Jun Li, Leonard Crestez,
Daniel Baluta, daniel.lezcano@linaro.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Oct 16, 2019 at 3:36 AM S.j. Wang <shengjiu.wang@nxp.com> wrote:
>
> Assign clocks and clock-rates for audio plls, that audio
> drivers can utilize them.
>
> Add dai-tdm-slot-num and dai-tdm-slot-width for sound-wm8524,
> that sai driver can generate correct bit clock.
>
> Fixes: 13f3b9fdef6c ("arm64: dts: imx8mm-evk: Enable audio codec wm8524")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 8 ++++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index f7a15f3904c2..13137451b438 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -62,6 +62,8 @@
>
> cpudai: simple-audio-card,cpu {
> sound-dai = <&sai3>;
> + dai-tdm-slot-num = <2>;
> + dai-tdm-slot-width = <32>;
> };
>
Shengjiu,
Can you explain the why dai-tdm-slot-width here is 32? I noticed when
I assigned that for an imx8mm board I'm working on (that uses a
tlv320aic3x codec) I ended up with the clock being off by a factor of
2 (audio playback was 2x too slow).
Best Regards,
Tim
^ permalink raw reply [flat|nested] 2+ messages in thread