From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6DFC43331 for ; Mon, 28 Dec 2020 16:19:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BCF820867 for ; Mon, 28 Dec 2020 16:19:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732574AbgL1QTL (ORCPT ); Mon, 28 Dec 2020 11:19:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2633217AbgL1QTK (ORCPT ); Mon, 28 Dec 2020 11:19:10 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48E19C0613D6 for ; Mon, 28 Dec 2020 08:18:30 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id b9so14862166ejy.0 for ; Mon, 28 Dec 2020 08:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TOPSXu09PYTsiu/Wdh2HSg+eyyVEEi2NvtnN4/vv3Wg=; b=SAuHeVN65tID5NqatUXbrkPK84oWTgv369sJyXjv6OiZVCwsjkMvIpx6urKsXLjIvA PQnDVKgO3PhNKLa0B0ufpvE0awZxc7LMUvc6WdIy+nHv4t+cl0BMEqVHs/XIWYvjgP4V R+oxDoX5BXorOMNmPZRnt9tb/s+Pya8Xd5R4jLKN4+zgZKmZxQDYg1n8+B4M7+boU1Y0 lkj1lNWzFdiO1rp5Qg0K50xtgz/bmgAttfAWENmENfzfgMBushQR6Xwi59C+dbl5z/gD zoSYtGSUlRyyYPb8xlcLyLQK8ImgQEZx+dnEWNxJMA8sr2Dj3PUTNDXLzp6zznbh5XaT YFAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TOPSXu09PYTsiu/Wdh2HSg+eyyVEEi2NvtnN4/vv3Wg=; b=qTOykatSOnWJnS501Qsp8IcOjodbsDDMKWvSEos4BPRnJVfZT52Bb/7zomr2CNwteX VbtY1RukIAYcAZzGd5O6AKLdVnKwN8+WGAV/lc91d9kLzgDa893gq2jL8ciiG+wW9tSQ weaq2HzYnO/Gdy/lTjCq4IWMGITlDf9HYmtiCVVlfFCpnytfFpGfEBFg3Gfrv5ej2Dte J9ewy8EAMVddbXOJqyDKE/qC75S9z6aDCDxJ1gKqdsAb/A3CaUD4wmQhwrGfZCjOw2Om 2Be5jFvOesOPN2jWKsrv+i9Bs3UK0gYGrBhi25DltqPaZh1LSp7fnV1bvWQv6yl96Alz TfJw== X-Gm-Message-State: AOAM533Mq8BXZU8/aMlK+lmgc8oR5noGzbvJa9NDU99KoCwC23g0Qdsg XInJ1ja4/l0nqjfQFTrjX+TLu4WZFxJZaQmPB3Mm1g== X-Google-Smtp-Source: ABdhPJzpGxgLX1x1kHX5FmBn5e3K0N3tgN2POjPbGkgKYNPn7agrr/SlgWVd+qedEODn+u5XsCI1WNi9lz6D9jhJ8LA= X-Received: by 2002:a17:907:3e23:: with SMTP id hp35mr42624451ejc.254.1609172308970; Mon, 28 Dec 2020 08:18:28 -0800 (PST) MIME-Version: 1.0 References: <1608762196-29871-1-git-send-email-tharvey@gateworks.com> <20201224112335.GA15628@kozik-lap> In-Reply-To: <20201224112335.GA15628@kozik-lap> From: Tim Harvey Date: Mon, 28 Dec 2020 08:18:17 -0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks boards with IMX8MM To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Device Tree Mailing List , open list , Linux ARM Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 24, 2020 at 3:23 AM Krzysztof Kozlowski wrote: > > On Wed, Dec 23, 2020 at 02:23:15PM -0800, Tim Harvey wrote: > > Add bindings for the Gateworks Venice Development kit boards with > > IMX8MM System on Module. > > > > Signed-off-by: Tim Harvey > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 1ca9dfa..705c6e8 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -405,6 +405,9 @@ properties: > > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit > > - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board > > - fsl,imx8mm-evk # i.MX8MM EVK Board > > + - gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit > > + - gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit > > + - gw,imx8mm-gw73xx-0x # i.MX8MM Gateworks Development Kit > > I think you should skip the wildcards in compatible and choose one > specific compatible. What if at some point you would like to add gw,imx8mm-gw7113-0x? > Krzysztof, Thanks for the review. I do want the wildcards as above because they represent model variations that do not affect device-tree such as component subloads. Thanks, Tim