From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gateworks-com.20230601.gappssmtp.com header.i=@gateworks-com.20230601.gappssmtp.com header.b="Zk/tiMBt" Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D8B8B0 for ; Tue, 5 Dec 2023 10:13:36 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-54cfd70b2dcso1952421a12.3 for ; Tue, 05 Dec 2023 10:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20230601.gappssmtp.com; s=20230601; t=1701800014; x=1702404814; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mXq0MfZRsUUXWF9wD5yNB4JShTMDiPdjDXjC0F7taj4=; b=Zk/tiMBtakw5L3FcipK7znbHmefycm8fIrj6JtDEjulBR1qOK/8He7CaAkzszZjWR+ VQ+GpOf/tBRj+PujLs3pwnGHYR++Oi+mD8oqydqQbNoftKvFF9uP1k0ns874PSttsUBA nmGfosSDzXPhZhG01ZbapclY9kjDI8Vg5gQoDQ2q7WraPdijNmLH+/fBAHsjJ7EBqJMP 5vV/ofOm0KMkL08yUMXBqoz0MkGqtpEtooWZrEXwgxvFcg5PLyi5lsSEO14hwXXLt8mx yyF89RVlPbQGc47vsrLV+IWdvjaK4NBABHYszrrkD+FBHeWe0ATJtktTzh5wytw3jQBm Rrgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701800014; x=1702404814; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mXq0MfZRsUUXWF9wD5yNB4JShTMDiPdjDXjC0F7taj4=; b=DjNtF870Je67VwZHYr7YzSM34V9PjFxbXhMWl8K5bXfRFd+fkCE8/IxOainozh9bHf 5Pen+ZWyFNu7OLPNPEZhAnN9RicvBRIxxJMxQPgGHh2tiiqCpedHJIeoifMA0SJ+j93N nCsJFCOMdUf5fvJlbDA0jsVeyZr1/c2jTTo39Ft9xLUkV0+g5Ergf9q+4+lJB7TN3RB2 ffKue46v4U0zZC0+gULjUbYuMpTHR3ASpX09KC2y4UaWYENajgVJq9zoI2AhH3XuaDNH EcVnmqWK/4NjUEjcD8c0iu2pM37+bS8OCdaeURc6KT7/V03+QE5vQzpqPbUHWIsVvLRT oJyw== X-Gm-Message-State: AOJu0YyUxCaa5+ImlIi6++1v8pER05tAdjhegwUw8Y8l6p80h7EJpTCN u/PQAu+rv1GKy1VjXel6o/8HUkMTbUZcnn2VmRTuEw== X-Google-Smtp-Source: AGHT+IFmKwiC4EDFrybnCkMnPFoevOkPdtg4vQBvxBHXLhsCV0BnoZlp1hCTpg2BeuOvGr+igVu2Q9Lq73abUwn5b58= X-Received: by 2002:a17:906:73d1:b0:a19:b93c:d28e with SMTP id n17-20020a17090673d100b00a19b93cd28emr4703493ejl.2.1701800014652; Tue, 05 Dec 2023 10:13:34 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231130191815.2421978-1-robh@kernel.org> In-Reply-To: From: Tim Harvey Date: Tue, 5 Dec 2023 10:13:21 -0800 Message-ID: Subject: Re: [PATCH] arm64: dts: imx8mm-venice: Fix PCI bus nodes To: Rob Herring Cc: Fabio Estevam , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Nov 30, 2023 at 2:33=E2=80=AFPM Rob Herring wrote= : > > On Thu, Nov 30, 2023 at 1:28=E2=80=AFPM Fabio Estevam wrote: > > > > Hi Rob, > > > > On Thu, Nov 30, 2023 at 4:18=E2=80=AFPM Rob Herring w= rote: > > > > > > The imx8mm-venice boards PCI bus nodes are a complete mess. The > > > unit-addresses are wrong. The PCI bridge nodes are incomplete missing > > > "device_type" and "ranges" and just wrong for "#address-cells" and > > > "#size-cells" values. > > > > > > All of these issues are reported warnings if anyone bothered to pay > > > attention. Sigh. Rob, Sorry about that. At the time the dt was submitted there were still so many dt warnings it wasn't very clear what was a legitimate issue and the PCI bindings are not that easy to understand. > > > > The warnings are gone in linux-next: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/com= mit/arch/arm64/boot/dts/freescale?h=3Dnext-20231130&id=3Dd61c5068729a76a618= 3a897bcad4bf26e8d3d674 > > Linux-next is wrong. The ethernet device should have a node name of > 'ethernet'. The 'pcie' node name and 'device_type =3D "pci"' is for PCI > buses/bridges only. So as Fabio has tried to fix this with a patch that landed in linux-next this patch won't apply. I'll submit one that covers your changes. It's always been unfortunate to have to have this level of detail in a device-tree just to allow boot firmware to populate the mac address of a PCI ethernet device. Best Regards, Tim