From: Tim Harvey <tharvey@gateworks.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: imx6qdl-gw5904: add internal mdio nodes
Date: Mon, 5 Dec 2022 11:10:45 -0800 [thread overview]
Message-ID: <CAJ+vNU1M-LEiM2guowP-Ubb8cFnQE+YCFTZ=vL2C79Y0g0v1dQ@mail.gmail.com> (raw)
In-Reply-To: <20221205190214.uy6rn4whd6vndo23@skbuf>
On Mon, Dec 5, 2022 at 11:02 AM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> On Mon, Dec 05, 2022 at 10:01:35AM -0800, Tim Harvey wrote:
> > Vladimir,
> >
> > Yes, this patch resolves the issue. Enabling CONFIG_MARVELL_PHY
> > without this patch still shows the issue.
>
> Yeah, that makes sense considering what the issue is.
>
> > Thanks - please cc me on that and I'll respond (unless you want me to send it).
> >
> > I'll submit a v2 of my dt patch with fec phy-mode = 'rgmii' after this
> > patch lands.
>
> The question is how far to backport this change.
>
> I see that the GW5904 board was introduced in 2017. Which kernels do you
> need to support the complete/unambiguous dt-binding?
before adding the internal PHY nodes it works fine so no backporting
needed. I just don't want to add the complete/unambiguous dt-bindings
until your patch lands as at that point it would otherwise be broken.
Best Regards,
Tim
>
> I'm tempted to submit the patch to the "net" tree (making it a candidate
> for stable releases) but without a Fixes: tag, making it go as far as it
> will. That would be down to kernel 5.18, where the mv88e6xxx_get_caps()
> function was introduced. Further down, and we'd need different patches
> for older stable trees.
next prev parent reply other threads:[~2022-12-05 19:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 0:31 [PATCH 1/2] ARM: dts: imx6qdl-gw5904: add internal mdio nodes Tim Harvey
2022-12-01 0:31 ` [PATCH 2/2] ARM: dts: imx6qdl-gw5904: add dt props for populating eth MAC addrs Tim Harvey
2022-12-02 1:02 ` Fabio Estevam
2022-12-02 1:02 ` [PATCH 1/2] ARM: dts: imx6qdl-gw5904: add internal mdio nodes Fabio Estevam
2022-12-02 13:08 ` Andrew Lunn
2022-12-02 16:48 ` Tim Harvey
2022-12-02 17:30 ` Andrew Lunn
2022-12-02 22:29 ` Tim Harvey
2022-12-04 0:15 ` Andrew Lunn
2022-12-05 17:10 ` Vladimir Oltean
2022-12-05 18:01 ` Tim Harvey
2022-12-05 19:02 ` Vladimir Oltean
2022-12-05 19:10 ` Tim Harvey [this message]
2022-12-05 19:15 ` Vladimir Oltean
2022-12-05 19:24 ` Tim Harvey
2022-12-05 19:37 ` Vladimir Oltean
2022-12-05 17:27 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+vNU1M-LEiM2guowP-Ubb8cFnQE+YCFTZ=vL2C79Y0g0v1dQ@mail.gmail.com' \
--to=tharvey@gateworks.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).