From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8776FC54EE9 for ; Thu, 8 Sep 2022 15:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbiIHPpi (ORCPT ); Thu, 8 Sep 2022 11:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbiIHPph (ORCPT ); Thu, 8 Sep 2022 11:45:37 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F73ABF1B for ; Thu, 8 Sep 2022 08:45:36 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d82so4700004pfd.10 for ; Thu, 08 Sep 2022 08:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=2cXPsEEmqpGjBnsgwBYy/qYjnBkOZjWcTGgc9Qs3P1k=; b=XWke3P1iCAuKHT1QtigkpG28d1MXKN2BF0T2iwIcmo7/sL6blxCmndF8dVnY6nCH5K u1dlJ1I08sc1L4h317dDD+Ey9RKBqK0zkeRocHgjCkHyjocAfqGFYNNpq1d/niqcgSDA NR8BUxRUtxKJ6P3IR5IX4xYXYYMu7HWYuwCoh6eWPQfyVwpwNoE5cp+CKeQBOusznsoU OpHaTkG4qW11y5KsMKJ5dGHuJIonfuZKeLfuz6mWnES++N1hTOYmTHNffrneg8VVJnNB XSYxu9vWegZlVMV2EhOkMKqXxhIs2OcuXjpYqNgyvt0clDbhDXbXNqLm0xRBx8xtHbup IYRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=2cXPsEEmqpGjBnsgwBYy/qYjnBkOZjWcTGgc9Qs3P1k=; b=uGfgwOYAcELzz3KmE6jU1IVp7pNNkBAd7DBPJB7wKr+4oFpa70oH0b1AWH2RifGaxg koVWmNmQsVxXRDPrBNsdcSPx15P+iktbv43XW59RCoOGGN/PIq6189pDVfPkZYPErSPp a3zjGYxgrrrPT/uxonVmjqlhhRlHble6KM96Ga/+4Yz1AnsMhkPROEfhYTjr9Ug7ueap jjS8/cfiiQuKZyWSObcqgpHsil7ShmycV6XMkBAA8gVnH+HPhbamf+dU49yh4NZaVL9S Jyx1NiKNKAt6YDTJDULIe+nXDDJ/86KpxiVfJgm7IIEY4vurjqY3Hj+2PT4vxh5H1mzG Fcrw== X-Gm-Message-State: ACgBeo0aXFI5/bGLmjOm7npvGJ4ClQQJNtMIeNX2Dh1bmMdUpBmgvNkz HsNP0KQq+vNLrb8i75kB6c76f8x10/dzjEHA/4FzhQ== X-Google-Smtp-Source: AA6agR5MSnQiwdnCkNknY/8pzsC6gDsw/OawAUwBq8sjFGwEMGwBRzl2H61BoEmA0jSkLSHyatRfkreEjSN9EynVGqs= X-Received: by 2002:a63:8043:0:b0:434:fe8f:6cd0 with SMTP id j64-20020a638043000000b00434fe8f6cd0mr6366514pgd.115.1662651935822; Thu, 08 Sep 2022 08:45:35 -0700 (PDT) MIME-Version: 1.0 References: <20220812173526.15537-1-tharvey@gateworks.com> <20220812173526.15537-2-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Thu, 8 Sep 2022 08:45:24 -0700 Message-ID: Subject: Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2 To: Shawn Guo , Fabio Estevam , NXP Linux Team , Sascha Hauer , Rob Herring , Krzysztof Kozlowski , Pengutronix Kernel Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Peng Fan (OSS)" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey wrote: > > On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey wrote: > > > > pinctrl_sai2 is not yet used and not properly defined - remove it to > > avoid: > > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert > > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp > > > > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts > > support") > > Signed-off-by: Tim Harvey > > --- > > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > > index de17021df53f..80f0f1aafdbf 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts > > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110 > > >; > > }; > > > > - pinctrl_sai2: sai2grp { > > - fsl,pins = < > > - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC > > - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00 > > - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK > > - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK > > - >; > > - }; > > - > > pinctrl_spi2: spi2grp { > > fsl,pins = < > > MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82 > > -- > > 2.25.1 > > > > Shawn, > > You can drop this. I didn't see Peng's patch commit 706dd9d30d3b > ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which > takes care of this. > > Best Regards, > > Tim Shawn, Did you need me to re-submit the series this patch was in without it? I haven't seen any responses to the rest of the patches in this series. Best Regards, Tim