* [PATCH] ARM: DT: ifc6410: Add board memory range.
@ 2014-09-17 5:36 Srinivas Kandagatla
2014-09-17 6:34 ` Pramod Gurav
0 siblings, 1 reply; 7+ messages in thread
From: Srinivas Kandagatla @ 2014-09-17 5:36 UTC (permalink / raw)
To: Kumar Gala
Cc: linux-arm-kernel, devicetree, linux-arm-msm, Srinivas Kandagatla
This patch adds memory details of IFC6410 as this is necessary to
fix the in-correct memory start comming from ATAGs.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
index 90db8af..3287f12 100644
--- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
@@ -4,6 +4,11 @@
model = "Qualcomm APQ8064/IFC6410";
compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
+ memory{
+ device_type = "memory";
+ reg = <0x80000000 0x80000000>;
+ };
+
soc {
gsbi@16600000 {
status = "ok";
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: DT: ifc6410: Add board memory range.
2014-09-17 5:36 [PATCH] ARM: DT: ifc6410: Add board memory range Srinivas Kandagatla
@ 2014-09-17 6:34 ` Pramod Gurav
2014-09-17 19:03 ` Kumar Gala
0 siblings, 1 reply; 7+ messages in thread
From: Pramod Gurav @ 2014-09-17 6:34 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Kumar Gala, linux-arm-kernel, devicetree, linux-arm-msm
Hi Srini,
Thanks for the patch.
Tested-by: Pramod Gurav <pramod.gurav@smartplayin.com>
A minor nit.
On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote:
> This patch adds memory details of IFC6410 as this is necessary to
> fix the in-correct memory start comming from ATAGs.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> index 90db8af..3287f12 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> @@ -4,6 +4,11 @@
> model = "Qualcomm APQ8064/IFC6410";
> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>
> + memory{
Space before {?
> + device_type = "memory";
> + reg = <0x80000000 0x80000000>;
> + };
> +
> soc {
> gsbi@16600000 {
> status = "ok";
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: DT: ifc6410: Add board memory range.
2014-09-17 6:34 ` Pramod Gurav
@ 2014-09-17 19:03 ` Kumar Gala
2014-09-17 19:18 ` Josh Cartwright
0 siblings, 1 reply; 7+ messages in thread
From: Kumar Gala @ 2014-09-17 19:03 UTC (permalink / raw)
To: Pramod Gurav
Cc: Srinivas Kandagatla, linux-arm-kernel, devicetree, linux-arm-msm
On Sep 16, 2014, at 11:34 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote:
> Hi Srini,
>
> Thanks for the patch.
> Tested-by: Pramod Gurav <pramod.gurav@smartplayin.com>
>
> A minor nit.
> On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote:
>> This patch adds memory details of IFC6410 as this is necessary to
>> fix the in-correct memory start comming from ATAGs.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> index 90db8af..3287f12 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> @@ -4,6 +4,11 @@
>> model = "Qualcomm APQ8064/IFC6410";
>> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>>
>> + memory{
> Space before {?
>> + device_type = "memory";
>> + reg = <0x80000000 0x80000000>;
>> + };
>> +
>> soc {
>> gsbi@16600000 {
>> status = "ok”;
Hmm, this doesn’t seem to work for me.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: DT: ifc6410: Add board memory range.
2014-09-17 19:03 ` Kumar Gala
@ 2014-09-17 19:18 ` Josh Cartwright
2014-09-17 21:49 ` Srinivas Kandagatla
0 siblings, 1 reply; 7+ messages in thread
From: Josh Cartwright @ 2014-09-17 19:18 UTC (permalink / raw)
To: Kumar Gala
Cc: Pramod Gurav, Srinivas Kandagatla, linux-arm-kernel, devicetree,
linux-arm-msm
On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote:
> On Sep 16, 2014, at 11:34 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote:
> > On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote:
> >> This patch adds memory details of IFC6410 as this is necessary to
> >> fix the in-correct memory start comming from ATAGs.
> >>
> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >> ---
> >> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> >> index 90db8af..3287f12 100644
> >> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> >> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> >> @@ -4,6 +4,11 @@
> >> model = "Qualcomm APQ8064/IFC6410";
> >> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
> >>
> >> + memory{
> > Space before {?
> >> + device_type = "memory";
> >> + reg = <0x80000000 0x80000000>;
> >> + };
> >> +
> >> soc {
> >> gsbi@16600000 {
> >> status = "ok?;
>
> Hmm, this doesn?t seem to work for me.
I don't see how it could with qcom_defconfig, as we set
CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: DT: ifc6410: Add board memory range.
2014-09-17 19:18 ` Josh Cartwright
@ 2014-09-17 21:49 ` Srinivas Kandagatla
2014-09-18 4:37 ` Bjorn Andersson
0 siblings, 1 reply; 7+ messages in thread
From: Srinivas Kandagatla @ 2014-09-17 21:49 UTC (permalink / raw)
To: Josh Cartwright, Kumar Gala
Cc: Pramod Gurav, linux-arm-kernel, devicetree, linux-arm-msm
On 17/09/14 20:18, Josh Cartwright wrote:
> On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote:
>> On Sep 16, 2014, at 11:34 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote:
>>> On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote:
>>>> This patch adds memory details of IFC6410 as this is necessary to
>>>> fix the in-correct memory start comming from ATAGs.
>>>>
>>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>>> ---
>>>> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>>>> index 90db8af..3287f12 100644
>>>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>>>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>>>> @@ -4,6 +4,11 @@
>>>> model = "Qualcomm APQ8064/IFC6410";
>>>> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>>>>
>>>> + memory{
>>> Space before {?
>>>> + device_type = "memory";
>>>> + reg = <0x80000000 0x80000000>;
>>>> + };
>>>> +
>>>> soc {
>>>> gsbi@16600000 {
>>>> status = "ok?;
>>
>> Hmm, this doesn?t seem to work for me.
>
> I don't see how it could with qcom_defconfig, as we set
> CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?
No, its not fixing any thing by itself.
However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM"
patch atleast I get to boot my IFC6410 with multi_v7_defconfig.
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: DT: ifc6410: Add board memory range.
2014-09-17 21:49 ` Srinivas Kandagatla
@ 2014-09-18 4:37 ` Bjorn Andersson
2014-09-18 14:16 ` Srinivas Kandagatla
0 siblings, 1 reply; 7+ messages in thread
From: Bjorn Andersson @ 2014-09-18 4:37 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Josh Cartwright, Kumar Gala, Pramod Gurav,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-msm
On Wed, Sep 17, 2014 at 2:49 PM, Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
>
>
> On 17/09/14 20:18, Josh Cartwright wrote:
>>
>> On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote:
[..]
>>> Hmm, this doesn?t seem to work for me.
>>
>>
>> I don't see how it could with qcom_defconfig, as we set
>> CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?
>
> No, its not fixing any thing by itself.
>
> However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM"
> patch atleast I get to boot my IFC6410 with multi_v7_defconfig.
But that patch was rejected by various people.
Instead have a look at [1], it solves the problem for you (and have
reference to the original source).
[1] https://github.com/andersson/kernel/commit/d4c0061cf7be8a341e6d06a97c85ecb69284e74c
Regards,
Bjorn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: DT: ifc6410: Add board memory range.
2014-09-18 4:37 ` Bjorn Andersson
@ 2014-09-18 14:16 ` Srinivas Kandagatla
0 siblings, 0 replies; 7+ messages in thread
From: Srinivas Kandagatla @ 2014-09-18 14:16 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Josh Cartwright, Kumar Gala, Pramod Gurav,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-msm
On 18/09/14 05:37, Bjorn Andersson wrote:
> On Wed, Sep 17, 2014 at 2:49 PM, Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>>
>>
>> On 17/09/14 20:18, Josh Cartwright wrote:
>>>
>>> On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote:
> [..]
>>>> Hmm, this doesn?t seem to work for me.
>>>
>>>
>>> I don't see how it could with qcom_defconfig, as we set
>>> CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?
>>
>> No, its not fixing any thing by itself.
>>
>> However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM"
>> patch atleast I get to boot my IFC6410 with multi_v7_defconfig.
>
> But that patch was rejected by various people.
> Instead have a look at [1], it solves the problem for you (and have
> reference to the original source).
>
> [1] https://github.com/andersson/kernel/commit/d4c0061cf7be8a341e6d06a97c85ecb69284e74c
Looks cool.. I think we can ignore this patch with this fixup.
On IFC6410 now that we have some way to unbrick the board we could even
try to fix this at bootloader level.
Thanks to Kumar and You for redirecting me to this link.
--srini
>
> Regards,
> Bjorn
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-18 14:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 5:36 [PATCH] ARM: DT: ifc6410: Add board memory range Srinivas Kandagatla
2014-09-17 6:34 ` Pramod Gurav
2014-09-17 19:03 ` Kumar Gala
2014-09-17 19:18 ` Josh Cartwright
2014-09-17 21:49 ` Srinivas Kandagatla
2014-09-18 4:37 ` Bjorn Andersson
2014-09-18 14:16 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).