devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn@kryo.se>
To: pramod gurav <pramod.gurav.etc@gmail.com>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding
Date: Wed, 16 Jul 2014 15:20:40 -0700	[thread overview]
Message-ID: <CAJAp7OggtuxPSc0yXzMCs10aQ2R6E+m4Bu8sdLJopvrZ3+5Rmg@mail.gmail.com> (raw)
In-Reply-To: <CAMf-jS=tkBYQ7mXp71F2_rPo6DE3e4C=sFHqg3Q26a08m6NxJQ@mail.gmail.com>

On Wed, Jul 16, 2014 at 3:06 AM, pramod gurav
<pramod.gurav.etc@gmail.com> wrote:
> Hi Bjorn,
>
> RPM breaks on IFC6410 without entry for 'qcom.ipc' node. Please find
> my observations below.
>
> On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson
> <bjorn.andersson@sonymobile.com> wrote:
[...]
>> +       rpm@108000 {
>> +               compatible = "qcom,rpm-msm8960";
>> +               reg = <0x108000 0x1000>;
>> +               qcom,ipc = <&apcs 0x8 2>;
>
> Tried adding this but there is no reference to 'apcs' registers itself
> in any dts.
>
> Without these changes rpm breaks hence not able to test SATA which needs rpm.
>

Hi Pramod,

Unfortunately the ipc bits resides in a block that needs to be
accesses by various device drivers so I had to extract the access; so
you now need to reference it via a syscon handle and offset instead -
as described above.

The apcs node I used for testing this with looks like this:

apcs: syscon@2011000 {
    compatible = "syscon";
    reg = <0x2011000 0x1000>;
};

Enable CONFIG_MFD_SYSCON and put the dt snippet somewhere under soc
and you should be good.

Regards,
Bjorn

  reply	other threads:[~2014-07-16 22:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 23:00 [PATCH v4 0/3] Qualcomm Resource Power Manager driver Bjorn Andersson
2014-07-15 23:00 ` [PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding Bjorn Andersson
     [not found]   ` <1405465241-28684-2-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-07-16 10:06     ` pramod gurav
2014-07-16 22:20       ` Bjorn Andersson [this message]
2014-07-17 16:04         ` pramod gurav
2014-07-15 23:00 ` [PATCH v4 2/3] soc: qcom-rpm: Driver for the Qualcomm RPM Bjorn Andersson
2014-07-17 17:33   ` pramod gurav
2014-07-17 18:17     ` Bjorn Andersson
2014-07-15 23:00 ` [PATCH v4 3/3] regulator: qcom-rpm: Regulator driver " Bjorn Andersson
2014-07-16  0:08   ` Mark Brown
2014-07-16 22:15     ` Bjorn Andersson
2014-07-16 22:30       ` Mark Brown
2014-07-16  7:01   ` pramod gurav
     [not found]     ` <CAMf-jSn2YHF7ihRpXMfkPWYt8pNCj4o395OGha3BHD3K3mUv9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-16 22:17       ` Bjorn Andersson
     [not found]         ` <CAJAp7Oj1R-EkJoSdLEa6SBLbzE_N1MjsystQ9Z+x4L_SjU=56w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-16 22:28           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJAp7OggtuxPSc0yXzMCs10aQ2R6E+m4Bu8sdLJopvrZ3+5Rmg@mail.gmail.com \
    --to=bjorn@kryo.se \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=pramod.gurav.etc@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).