From: Bjorn Andersson <bjorn@kryo.se>
To: Georgi Djakov <gdjakov@mm-sol.com>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
devicetree@vger.kernel.org, mark.rutland@arm.com,
swarren@wwwdotorg.org, ian.campbell@citrix.com, rob@landley.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Asutosh Das <asutoshd@codeaurora.org>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
Sahitya Tummala <stummala@codeaurora.org>,
Subhash Jadavani <subhashj@codeaurora.org>
Subject: Re: [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets
Date: Sat, 5 Oct 2013 22:51:32 -0700 [thread overview]
Message-ID: <CAJAp7OjvU2mi_TDiA5d-ut-Q9fHvKSbW_LfdpQGSTprsyPDU0g@mail.gmail.com> (raw)
In-Reply-To: <1380301041-26405-3-git-send-email-gdjakov@mm-sol.com>
Hi Georgi,
Thanks for working on this, unfortunately it seems like I need to port
the rpm regulators to be able to test this.
But I did find that...
On Fri, Sep 27, 2013 at 9:57 AM, Georgi Djakov <gdjakov@mm-sol.com> wrote:
> ...
> +static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data)
> +{
> + struct sdhci_msm_host *msm_host = (struct sdhci_msm_host *)data;
> ...
> +static int sdhci_msm_probe(struct platform_device *pdev)
> +{
> + struct sdhci_host *host;
> + struct sdhci_msm_host *msm_host;
> ...
> + ret = devm_request_threaded_irq(&pdev->dev, msm_host->pwr_irq, NULL,
> + sdhci_msm_pwr_irq, IRQF_ONESHOT,
> + dev_name(&pdev->dev), host);
> ...
...sdhci_msm_pwr_irq() expects the data pointer to be msm_host, not
sdhci_host, so right now I only get a panic. So I suspect you mean
msm_host as the last param here.
Regards,
Bjorn
next prev parent reply other threads:[~2013-10-06 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 16:57 [PATCH v6 0/2] mmc: sdhci-msm: Add support for MSM chipsets Georgi Djakov
2013-09-27 16:57 ` [PATCH v6 1/2] mmc: sdhci-msm: Initial SDHCI MSM driver documentation Georgi Djakov
2013-09-27 16:57 ` [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets Georgi Djakov
2013-10-06 5:51 ` Bjorn Andersson [this message]
2013-10-06 12:45 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJAp7OjvU2mi_TDiA5d-ut-Q9fHvKSbW_LfdpQGSTprsyPDU0g@mail.gmail.com \
--to=bjorn@kryo.se \
--cc=asutoshd@codeaurora.org \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=gdjakov@mm-sol.com \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=stummala@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).