From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5B5C3DA7A for ; Sat, 31 Dec 2022 11:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231587AbiLaLEq (ORCPT ); Sat, 31 Dec 2022 06:04:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiLaLEp (ORCPT ); Sat, 31 Dec 2022 06:04:45 -0500 Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193C9C771 for ; Sat, 31 Dec 2022 03:04:43 -0800 (PST) Received: by mail-vs1-xe36.google.com with SMTP id 3so23483536vsq.7 for ; Sat, 31 Dec 2022 03:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+8s9I1GFb9vnJYgyzF3LyGBW5PFYtk5cyL1Hz3ZGmM0=; b=uPbAiz2zy95lZywFI2dEhF9ilRfpoGzunGA9KXqogD3RSi1/EWRrzJIM1vxnoNcLG/ wMRaS1tQFpJ7O0CHd/bAPop9GTEtzSq+ihpNxkWVTggDztMR/1EXThpUR0ma8qZJpsuB +5yopTeCpNY32IXV+4QsqVei184W34IOQPvkTMRWarGgU0k+TufPQ88LiZSurlfnqkX6 KRIFSPPBLf6EptkgSOxoFOiyEIMfI/QcBcuaaIWPxbLUpy+3cnBLS+aMbHAYPhmjaAnx npwb2foOdUX54K4VR7+ilQVPV5z+1Xq4kcwyWf9l/m8oVjIevhw4iLAXcvJOe3LN1w60 E41Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+8s9I1GFb9vnJYgyzF3LyGBW5PFYtk5cyL1Hz3ZGmM0=; b=mmISW/VtfsxNdKvFCLBeHM8bmcUuVjqHMoYdya49YjwPi/4TUQtvoGQr33Do4+xpWy OwxzARSGmJiFW4FTtAAcTU8GJM1OYA9LdmddYr5aEKY7tgV3xZssBhs7fJkts87O7bfT gQqJ6k14FqZXTVIe1+aZCt+S6bE1cBNZe0P7vGwh1BGcw5Mq6B2xgee0Yd0WYgmj0N/r PSuwfw1IaQRdQOOW1f2sJT10AgVZEy/vJ+AGTLh6ZMO9B2tuP4xP2/84IjZa9nHpCNtq AGAti++JsbUYcSQZMXP+cFZJ31Xra/xf0PkRcBBxYfGfzqB0IOU8Q5gpbZnhUfqgnmG3 EF1g== X-Gm-Message-State: AFqh2kokk5EPpOtM27EFEEnG6rlJNqdjOVhRMX7bqhRC2QEP6J0XNhup Z6e9ojcQKtYIANIwNpmgiKgRwXmgnmtnqn2SGTHBHQ== X-Google-Smtp-Source: AMrXdXsxTLOmViWobRZ2Cuj/KRsod18koNJDIh7HfLSsbcb9G+N+RMccym1kxCwlWb0RlW42UqAhlI3ZMJlpVGWDkK4= X-Received: by 2002:a67:fad7:0:b0:3b1:5690:a240 with SMTP id g23-20020a67fad7000000b003b15690a240mr3963799vsq.68.1672484682183; Sat, 31 Dec 2022 03:04:42 -0800 (PST) MIME-Version: 1.0 References: <20221230160103.250996-1-krzysztof.kozlowski@linaro.org> In-Reply-To: <20221230160103.250996-1-krzysztof.kozlowski@linaro.org> From: "Bryan O'Donoghue" Date: Sat, 31 Dec 2022 11:04:30 +0000 Message-ID: Subject: Re: [PATCH 1/7] arm64: dts: qcom: sc8280xp: remove GCC from CX power domain To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Dec 30, 2022 at 4:04 PM Krzysztof Kozlowski wrote: > > Bindings do not allow power-domain property in GCC clock controller and > documentation does not indicate that GCC is part of VDD_CX. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Maybe the bindings should be fixed? Maybe this was added as workaround? > Anyway looking at documentation I do not see such relation, except > downstream vdd_cx-supply (which is the same as in other SoCs and we do > not represent it in upstream). > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 1d1420c8720c..d14663c9f34c 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -799,7 +799,6 @@ gcc: clock-controller@100000 { > <&pcie4_phy>, > <0>, > <0>; > - power-domains = <&rpmhpd SC8280XP_CX>; > }; > > ipcc: mailbox@408000 { > -- > 2.34.1 > You'd be better off adding the documentation. The CX rail is required to power the clock controller. If you are pulling this out and finding nothing breaks, its probably because the bootloader left it on. Per my understanding of what dts is though, we ought to be representing the hardware dependency. gcc is a root clock for just about every peripheral so, you can be sure it is on when you boot. Seems to me as if the right thing to do is to retain the dts and update the documentation. --- bod