* [PATCH 0/4] Add imem clock for Exynos 5433 [not found] <CGME20181121120522eucas1p2ecd03f848bc4ea3be3d517b40b78b084@eucas1p2.samsung.com> @ 2018-11-21 12:05 ` Kamil Konieczny [not found] ` <CGME20181121120523eucas1p1e69848a515c713315499e6e21f099cc2@eucas1p1.samsung.com> ` (3 more replies) 0 siblings, 4 replies; 11+ messages in thread From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw) To: k.konieczny, linux-samsung-soc Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski, Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz, Marek Szyprowski Add imem clock for Exynos 5433. This will allow to use SSS and SlimSSS (Security SubSystem) with crypto functions. Kamil Konieczny (4): clk: samsung: exynos5433: fix name typos arm64: dts: bindings: document imem clock arm64: dts: exynos: add imem clock clk: samsung: exynos5433: add imem clock .../bindings/clock/exynos5433-clock.txt | 23 ++++ arch/arm64/boot/dts/exynos/exynos5433.dtsi | 15 ++ drivers/clk/samsung/clk-exynos5433.c | 129 +++++++++++++++++- include/dt-bindings/clock/exynos5433.h | 57 +++++++- 4 files changed, 220 insertions(+), 4 deletions(-) -- 2.19.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CGME20181121120523eucas1p1e69848a515c713315499e6e21f099cc2@eucas1p1.samsung.com>]
* [PATCH 1/4] clk: samsung: exynos5433: fix name typos [not found] ` <CGME20181121120523eucas1p1e69848a515c713315499e6e21f099cc2@eucas1p1.samsung.com> @ 2018-11-21 12:05 ` Kamil Konieczny 2018-11-21 12:23 ` Chanwoo Choi 2018-11-21 13:13 ` Krzysztof Kozlowski 0 siblings, 2 replies; 11+ messages in thread From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw) To: k.konieczny, linux-samsung-soc Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski, Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz, Marek Szyprowski Fix typo in imem sssx name and typo 200 switched with 266. Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> --- drivers/clk/samsung/clk-exynos5433.c | 6 +++--- include/dt-bindings/clock/exynos5433.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index 751e2c4fb65b..24c3360db65b 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -559,7 +559,7 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { /* ENABLE_ACLK_TOP */ GATE(CLK_ACLK_G3D_400, "aclk_g3d_400", "div_aclk_g3d_400", ENABLE_ACLK_TOP, 30, CLK_IS_CRITICAL, 0), - GATE(CLK_ACLK_IMEM_SSX_266, "aclk_imem_ssx_266", + GATE(CLK_ACLK_IMEM_SSSX_266, "aclk_imem_sssx_266", "div_aclk_imem_sssx_266", ENABLE_ACLK_TOP, 29, CLK_IGNORE_UNUSED, 0), GATE(CLK_ACLK_BUS0_400, "aclk_bus0_400", "div_aclk_bus0_400", @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400", ENABLE_ACLK_TOP, 25, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266", + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200", ENABLE_ACLK_TOP, 24, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200", + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266", ENABLE_ACLK_TOP, 23, CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), GATE(CLK_ACLK_PERIC_66, "aclk_peric_66", "div_aclk_peric_66_b", diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h index 98bd85ce1e45..87bb2b017143 100644 --- a/include/dt-bindings/clock/exynos5433.h +++ b/include/dt-bindings/clock/exynos5433.h @@ -156,7 +156,7 @@ #define CLK_ACLK_G2D_266 220 #define CLK_ACLK_G2D_400 221 #define CLK_ACLK_G3D_400 222 -#define CLK_ACLK_IMEM_SSX_266 223 +#define CLK_ACLK_IMEM_SSSX_266 223 #define CLK_ACLK_BUS0_400 224 #define CLK_ACLK_BUS1_400 225 #define CLK_ACLK_IMEM_200 226 -- 2.19.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] clk: samsung: exynos5433: fix name typos 2018-11-21 12:05 ` [PATCH 1/4] clk: samsung: exynos5433: fix name typos Kamil Konieczny @ 2018-11-21 12:23 ` Chanwoo Choi 2018-11-21 13:13 ` Krzysztof Kozlowski 1 sibling, 0 replies; 11+ messages in thread From: Chanwoo Choi @ 2018-11-21 12:23 UTC (permalink / raw) To: Kamil Konieczny, linux-samsung-soc Cc: linux-clk, devicetree, Krzysztof Kozlowski, Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz, Marek Szyprowski Hi, On 2018년 11월 21일 21:05, Kamil Konieczny wrote: > Fix typo in imem sssx name and typo 200 switched with 266. > > Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> Looks good to me. But, You have to add the 'Fixes' information and then send this patch to stable mailing list. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/clk/samsung/clk-exynos5433.c | 6 +++--- > include/dt-bindings/clock/exynos5433.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index 751e2c4fb65b..24c3360db65b 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -559,7 +559,7 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { > /* ENABLE_ACLK_TOP */ > GATE(CLK_ACLK_G3D_400, "aclk_g3d_400", "div_aclk_g3d_400", > ENABLE_ACLK_TOP, 30, CLK_IS_CRITICAL, 0), > - GATE(CLK_ACLK_IMEM_SSX_266, "aclk_imem_ssx_266", > + GATE(CLK_ACLK_IMEM_SSSX_266, "aclk_imem_sssx_266", > "div_aclk_imem_sssx_266", ENABLE_ACLK_TOP, > 29, CLK_IGNORE_UNUSED, 0), > GATE(CLK_ACLK_BUS0_400, "aclk_bus0_400", "div_aclk_bus0_400", > @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { > GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400", > ENABLE_ACLK_TOP, 25, > CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), > - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266", > + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200", > ENABLE_ACLK_TOP, 24, > CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), > - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200", > + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266", > ENABLE_ACLK_TOP, 23, > CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), > GATE(CLK_ACLK_PERIC_66, "aclk_peric_66", "div_aclk_peric_66_b", > diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h > index 98bd85ce1e45..87bb2b017143 100644 > --- a/include/dt-bindings/clock/exynos5433.h > +++ b/include/dt-bindings/clock/exynos5433.h > @@ -156,7 +156,7 @@ > #define CLK_ACLK_G2D_266 220 > #define CLK_ACLK_G2D_400 221 > #define CLK_ACLK_G3D_400 222 > -#define CLK_ACLK_IMEM_SSX_266 223 > +#define CLK_ACLK_IMEM_SSSX_266 223 > #define CLK_ACLK_BUS0_400 224 > #define CLK_ACLK_BUS1_400 225 > #define CLK_ACLK_IMEM_200 226 > -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] clk: samsung: exynos5433: fix name typos 2018-11-21 12:05 ` [PATCH 1/4] clk: samsung: exynos5433: fix name typos Kamil Konieczny 2018-11-21 12:23 ` Chanwoo Choi @ 2018-11-21 13:13 ` Krzysztof Kozlowski 2018-11-26 14:25 ` Kamil Konieczny 1 sibling, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2018-11-21 13:13 UTC (permalink / raw) To: k.konieczny Cc: linux-samsung-soc@vger.kernel.org, linux-clk, Chanwoo Choi, devicetree, kgene, mark.rutland, robh+dt, s.nawrocki, Bartłomiej Żołnierkiewicz, Marek Szyprowski On Wed, 21 Nov 2018 at 13:05, Kamil Konieczny <k.konieczny@partner.samsung.com> wrote: > > Fix typo in imem sssx name and typo 200 switched with 266. These should be two separate patches. Then the one changing parent could go to stable. Best regards, Krzysztof > > Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> > --- > drivers/clk/samsung/clk-exynos5433.c | 6 +++--- > include/dt-bindings/clock/exynos5433.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index 751e2c4fb65b..24c3360db65b 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -559,7 +559,7 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { > /* ENABLE_ACLK_TOP */ > GATE(CLK_ACLK_G3D_400, "aclk_g3d_400", "div_aclk_g3d_400", > ENABLE_ACLK_TOP, 30, CLK_IS_CRITICAL, 0), > - GATE(CLK_ACLK_IMEM_SSX_266, "aclk_imem_ssx_266", > + GATE(CLK_ACLK_IMEM_SSSX_266, "aclk_imem_sssx_266", > "div_aclk_imem_sssx_266", ENABLE_ACLK_TOP, > 29, CLK_IGNORE_UNUSED, 0), > GATE(CLK_ACLK_BUS0_400, "aclk_bus0_400", "div_aclk_bus0_400", > @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { > GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400", > ENABLE_ACLK_TOP, 25, > CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), > - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266", > + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200", > ENABLE_ACLK_TOP, 24, > CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), > - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200", > + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266", > ENABLE_ACLK_TOP, 23, > CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), > GATE(CLK_ACLK_PERIC_66, "aclk_peric_66", "div_aclk_peric_66_b", > diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h > index 98bd85ce1e45..87bb2b017143 100644 > --- a/include/dt-bindings/clock/exynos5433.h > +++ b/include/dt-bindings/clock/exynos5433.h > @@ -156,7 +156,7 @@ > #define CLK_ACLK_G2D_266 220 > #define CLK_ACLK_G2D_400 221 > #define CLK_ACLK_G3D_400 222 > -#define CLK_ACLK_IMEM_SSX_266 223 > +#define CLK_ACLK_IMEM_SSSX_266 223 > #define CLK_ACLK_BUS0_400 224 > #define CLK_ACLK_BUS1_400 225 > #define CLK_ACLK_IMEM_200 226 > -- > 2.19.1 > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] clk: samsung: exynos5433: fix name typos 2018-11-21 13:13 ` Krzysztof Kozlowski @ 2018-11-26 14:25 ` Kamil Konieczny 0 siblings, 0 replies; 11+ messages in thread From: Kamil Konieczny @ 2018-11-26 14:25 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, linux-clk, Chanwoo Choi, devicetree, kgene, mark.rutland, robh+dt, s.nawrocki, Bartłomiej Żołnierkiewicz, Marek Szyprowski On 21.11.2018 14:13, Krzysztof Kozlowski wrote: > On Wed, 21 Nov 2018 at 13:05, Kamil Konieczny > <k.konieczny@partner.samsung.com> wrote: >> >> Fix typo in imem sssx name and typo 200 switched with 266. > > These should be two separate patches. Then the one changing parent > could go to stable. [...] Thank you, I will split it as you suggested. >> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> >> --- >> drivers/clk/samsung/clk-exynos5433.c | 6 +++--- >> include/dt-bindings/clock/exynos5433.h | 2 +- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> [...] >> @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { >> GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400", >> ENABLE_ACLK_TOP, 25, >> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), >> - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266", >> + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200", >> ENABLE_ACLK_TOP, 24, >> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), >> - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200", >> + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266", >> ENABLE_ACLK_TOP, 23, >> [...] -- Best regards, Kamil Konieczny Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CGME20181121120523eucas1p1e8c1ef3d19d0f71bbdc57e2a470c80b0@eucas1p1.samsung.com>]
* [PATCH 2/4] arm64: dts: bindings: document imem clock [not found] ` <CGME20181121120523eucas1p1e8c1ef3d19d0f71bbdc57e2a470c80b0@eucas1p1.samsung.com> @ 2018-11-21 12:05 ` Kamil Konieczny 0 siblings, 0 replies; 11+ messages in thread From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw) To: k.konieczny, linux-samsung-soc Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski, Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz, Marek Szyprowski Document imem clock bindings for SSS (Security SubSystem) and SlimSSS IPs. Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> --- .../bindings/clock/exynos5433-clock.txt | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/Documentation/devicetree/bindings/clock/exynos5433-clock.txt b/Documentation/devicetree/bindings/clock/exynos5433-clock.txt index 50d5897c9849..4e4352bf5a0b 100644 --- a/Documentation/devicetree/bindings/clock/exynos5433-clock.txt +++ b/Documentation/devicetree/bindings/clock/exynos5433-clock.txt @@ -19,6 +19,8 @@ Required Properties: which generates clocks for PMU/TMU/MCT/WDT/RTC/SECKEY/TZPC IPs. - "samsung,exynos5433-cmu-fsys" - clock controller compatible for CMU_FSYS which generates clocks for USB/UFS/SDMMC/TSI/PDMA IPs. + - "samsung,exynos5433-cmu-imem" - clock controller compatible for CMU_IMEM + which generates clocks for SSS (Security SubSystem) and SlimSSS IPs. - "samsung,exynos5433-cmu-g2d" - clock controller compatible for CMU_G2D which generates clocks for G2D/MDMA IPs. - "samsung,exynos5433-cmu-disp" - clock controller compatible for CMU_DISP @@ -88,6 +90,12 @@ Required Properties: - sclk_usbhost30_fsys - sclk_usbdrd30_fsys + Input clocks for imem clock controller: + - oscclk + - aclk_imem_sssx_266 + - aclk_imem_266 + - aclk_imem_200 + Input clocks for g2d clock controller: - oscclk - aclk_g2d_266 @@ -264,6 +272,21 @@ Example 2: Examples of clock controller nodes are listed below. <&cmu_top CLK_SCLK_USBDRD30_FSYS>; }; + cmu_imem: clock-controller@11060000 { + compatible = "samsung,exynos5433-cmu-imem"; + reg = <0x11060000 0x1000>; + #clock-cells = <1>; + + clock-names = "oscclk", + "aclk_imem_sssx_266", + "aclk_imem_266", + "aclk_imem_200"; + clocks = <&xxti>, + <&cmu_top CLK_DIV_ACLK_IMEM_SSSX_266>, + <&cmu_top CLK_DIV_ACLK_IMEM_266>, + <&cmu_top CLK_DIV_ACLK_IMEM_200>; + }; + cmu_g2d: clock-controller@12460000 { compatible = "samsung,exynos5433-cmu-g2d"; reg = <0x12460000 0x0b08>; -- 2.19.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <CGME20181121120524eucas1p2545f7ee0ed4064a10b3bc18f446c288c@eucas1p2.samsung.com>]
* [PATCH 3/4] arm64: dts: exynos: add imem clock [not found] ` <CGME20181121120524eucas1p2545f7ee0ed4064a10b3bc18f446c288c@eucas1p2.samsung.com> @ 2018-11-21 12:05 ` Kamil Konieczny 0 siblings, 0 replies; 11+ messages in thread From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw) To: k.konieczny, linux-samsung-soc Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski, Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz, Marek Szyprowski Add description for imem clock. The users can use compatibility "samsung,exynos5433-cmu-imem". Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 2131f12364cb..34055fa3a9d0 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -340,6 +340,21 @@ <&cmu_top CLK_SCLK_USBDRD30_FSYS>; }; + cmu_imem: clock-controller@11060000 { + compatible = "samsung,exynos5433-cmu-imem"; + reg = <0x11060000 0x1000>; + #clock-cells = <1>; + + clock-names = "oscclk", + "aclk_imem_sssx_266", + "aclk_imem_266", + "aclk_imem_200"; + clocks = <&xxti>, + <&cmu_top CLK_DIV_ACLK_IMEM_SSSX_266>, + <&cmu_top CLK_DIV_ACLK_IMEM_266>, + <&cmu_top CLK_DIV_ACLK_IMEM_200>; + }; + cmu_g2d: clock-controller@12460000 { compatible = "samsung,exynos5433-cmu-g2d"; reg = <0x12460000 0x1000>; -- 2.19.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <CGME20181121120524eucas1p166a26857df78947c9e08f0fb8dbf75e4@eucas1p1.samsung.com>]
* [PATCH 4/4] clk: samsung: exynos5433: add imem clock [not found] ` <CGME20181121120524eucas1p166a26857df78947c9e08f0fb8dbf75e4@eucas1p1.samsung.com> @ 2018-11-21 12:05 ` Kamil Konieczny 2018-11-21 12:39 ` Chanwoo Choi 0 siblings, 1 reply; 11+ messages in thread From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw) To: k.konieczny Cc: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Add imem clock for exynos5433. Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> --- drivers/clk/samsung/clk-exynos5433.c | 123 +++++++++++++++++++++++++ include/dt-bindings/clock/exynos5433.h | 55 +++++++++++ 2 files changed, 178 insertions(+) diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index 24c3360db65b..db29cbd1fbdc 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -2345,6 +2345,129 @@ static const struct samsung_cmu_info fsys_cmu_info __initconst = { .clk_name = "aclk_fsys_200", }; +/* + * Register offset definitions for CMU_IMEM + * + */ + +#define ENABLE_ACLK_IMEM 0x0800 +#define ENABLE_ACLK_IMEM_SSS 0x0808 +#define ENABLE_ACLK_IMEM_SLIMSSS 0x080c +#define ENABLE_PCLK_IMEM 0x0900 +#define ENABLE_PCLK_IMEM_SSS 0x0904 +#define ENABLE_PCLK_IMEM_SLIMSSS 0x0908 + +static const unsigned long imem_clk_regs[] __initconst = { +ENABLE_ACLK_IMEM, +ENABLE_ACLK_IMEM_SSS, +ENABLE_ACLK_IMEM_SLIMSSS, +ENABLE_PCLK_IMEM, +ENABLE_PCLK_IMEM_SSS, +ENABLE_PCLK_IMEM_SLIMSSS, +}; + +static const struct samsung_gate_clock imem_gate_clks[] __initconst = { + /* ENABLE_ACLK_IMEM */ + GATE(CLK_ACLK_AXI2AHB_IMEMH, "aclk_axi2ahb_imemh", "aclk_imem_200", + ENABLE_ACLK_IMEM, 24, 0, 0), + GATE(CLK_ACLK_AXIDS_SROMC, "aclk_axids_sromc", "aclk_imem_200", + ENABLE_ACLK_IMEM, 23, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_SROMC, "aclk_sromc", "aclk_imem_200", + ENABLE_ACLK_IMEM, 22, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_BTS_ARBG_TX, "aclk_bts_arbg_tx", "aclk_imem_266", + ENABLE_ACLK_IMEM, 21, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_ASYNCAXI_IMEMX, "aclk_asyncaxi_imemx", "aclk_imem_266", + ENABLE_ACLK_IMEM, 20, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_AXIUS_IMEMX, "aclk_axius_imemx", "aclk_imem_266", + ENABLE_ACLK_IMEM, 19, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_XIU_IMEMX, "aclk_xiu_imemx", "aclk_imem_266", + ENABLE_ACLK_IMEM, 18, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_ASYNCAXI_SSSX, "aclk_asyncaxi_sssx", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM, 17, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_BTS_SLIMSSS, "aclk_bts_slimsss", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM, 15, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_BTS_SSS_DRAM, "aclk_bts_sss_dram", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM, 14, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_BTS_SSS_CCI, "aclk_bts_sss_cci", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM, 13, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_ALB_IMEM, "aclk_alb_imem", "aclk_imem_266", + ENABLE_ACLK_IMEM, 12, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_AXIDS_PIMEMX_IMEM1P, "aclk_axids_pimemx_imem1p", "aclk_imem_200", + ENABLE_ACLK_IMEM, 11, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_AXIDS_PIMEMX_IMEM0P, "aclk_axids_pimemx_imem0p", "aclk_imem_200", + ENABLE_ACLK_IMEM, 10, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_AXIDS_PIMEMX_GIC, "aclk_axids_pimemx_gic", "aclk_imem_200", + ENABLE_ACLK_IMEM, 9, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_ASYNCAHBM_SSS_ATLAS, "aclk_asyncahbm_sss_atlas", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM, 7, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_ASYNCAXIS_MIF_PIMEMX, "aclk_asyncaxis_mif_pimemx", "aclk_imem_200", + ENABLE_ACLK_IMEM, 6, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_AXI2APB_IMEM1P, "aclk_axi2apb_imem1p", "aclk_imem_200", + ENABLE_ACLK_IMEM, 5, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_AXI2APB_IMEM0P, "aclk_axi2apb_imem0p", "aclk_imem_200", + ENABLE_ACLK_IMEM, 4, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_XIU_SSSX, "aclk_xiu_sssx", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM, 3, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_XIU_PIMEMX, "aclk_xiu_pimemx", "aclk_imem_200", + ENABLE_ACLK_IMEM, 2, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_IMEMND_266, "aclk_imemnd_266", "aclk_imem_266", + ENABLE_ACLK_IMEM, 1, CLK_IGNORE_UNUSED, 0), + GATE(CLK_ACLK_GIC, "aclk_gic", "aclk_imem_200", + ENABLE_ACLK_IMEM, 0, CLK_IGNORE_UNUSED, 0), + + /* ENABLE_ACLK_IMEM_SSS */ + GATE(CLK_ACLK_SSS, "aclk_sss", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM_SSS, 0, CLK_IGNORE_UNUSED, 0), + /* ENABLE_ACLK_IMEM_SLIMSSS */ + GATE(CLK_ACLK_SLIMSSS, "aclk_slimsss", "aclk_imem_sssx_266", + ENABLE_ACLK_IMEM_SLIMSSS, 0, CLK_IGNORE_UNUSED, 0), + + /* ENABLE_PCLK_IMEM */ + GATE(CLK_PCLK_GPIO_IMEM, "pclk_gpio_imem", "aclk_imem_200", + ENABLE_PCLK_IMEM, 17, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_ASYNCAXI_IMEMX, "pclk_asyncaxi_imemx", "aclk_imem_200", + ENABLE_PCLK_IMEM, 16, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_BTS_ARBG_TX, "pclk_bts_arbg_tx", "aclk_imem_200", + ENABLE_PCLK_IMEM, 15, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_ASYNCAPB_ARBG_TX, "pclk_asyncapb_arbg_tx", "aclk_imem_200", + ENABLE_PCLK_IMEM, 14, CLK_IGNORE_UNUSED, 0), + + GATE(CLK_PCLK_BTS_SLIMSSS, "pclk_bts_slimsss", "aclk_imem_200", + ENABLE_PCLK_IMEM, 8, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_BTS_SSS_DRAM, "pclk_bts_sss_dram", "aclk_imem_200", + ENABLE_PCLK_IMEM, 7, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_BTS_SSS_CCI, "pclk_bts_sss_cci", "aclk_imem_200", + ENABLE_PCLK_IMEM, 6, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_ALB_IMEM, "pclk_alb_imem", "aclk_imem_200", + ENABLE_PCLK_IMEM, 5, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_PMU_IMEM, "pclk_pmu_imem", "aclk_imem_200", + ENABLE_PCLK_IMEM, 4, CLK_IGNORE_UNUSED, 0), + GATE(CLK_PCLK_SYSREG_IMEM, "pclk_sysreg_imem", "aclk_imem_200", + ENABLE_PCLK_IMEM, 3, CLK_IGNORE_UNUSED, 0), + /* ENABLE_PCLK_IMEM_SSS */ + GATE(CLK_PCLK_SSS, "pclk_sss", "aclk_imem_200", + ENABLE_PCLK_IMEM, 0, CLK_IGNORE_UNUSED, 0), + /* ENABLE_PCLK_IMEM_SLIMSSS */ + GATE(CLK_PCLK_SLIMSSS, "pclk_slimsss", "aclk_imem_200", + ENABLE_PCLK_IMEM, 0, CLK_IGNORE_UNUSED, 0), +}; + +static const struct samsung_cmu_info imem_cmu_info __initconst = { + .gate_clks = imem_gate_clks, + .nr_gate_clks = ARRAY_SIZE(imem_gate_clks), + .nr_clk_ids = IMEM_NR_CLK, + .clk_regs = imem_clk_regs, + .nr_clk_regs = ARRAY_SIZE(imem_clk_regs), +}; + +static void __init exynos5433_cmu_imem_init(struct device_node *np) +{ + samsung_cmu_register_one(np, &imem_cmu_info); +} + +CLK_OF_DECLARE(exynos5433_cmu_imem, "samsung,exynos5433-cmu-imem", + exynos5433_cmu_imem_init); + /* * Register offset definitions for CMU_G2D */ diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h index 87bb2b017143..312d8810b56d 100644 --- a/include/dt-bindings/clock/exynos5433.h +++ b/include/dt-bindings/clock/exynos5433.h @@ -623,6 +623,61 @@ #define FSYS_NR_CLK 116 +/* CMU_IMEM */ +#define CLK_ACLK_SSS 1 +#define CLK_ACLK_SLIMSSS 2 +#define CLK_ACLK_RTIC 3 +#define CLK_ACLK_XIU_SSSX 4 +#define CLK_ACLK_ASYNCAHBM_SSS_ATLAS 5 +#define CLK_ACLK_ASYNCAXI_SSSX 6 +#define CLK_ACLK_BTS_SSS_CCI 7 +#define CLK_ACLK_BTS_SSS_DRAM 8 +#define CLK_ACLK_BTS_SLIMSSS 9 +#define CLK_ACLK_SMMU_SSS_CCI 10 +#define CLK_ACLK_SMMU_SSS_DRAM 11 +#define CLK_ACLK_SMMU_SLIMSSS 12 +#define CLK_ACLK_SMMU_RTIC 13 +#define CLK_ACLK_IMEMND_266 14 +#define CLK_ACLK_ALB_IMEM 15 +#define CLK_ACLK_XIU_IMEMX 16 +#define CLK_ACLK_AXIUS_IMEMX 17 +#define CLK_ACLK_ASYNCAXI_IMEMX 18 +#define CLK_ACLK_ARBG_TX 19 +#define CLK_ACLK_BTS_ARBG_TX 20 +#define CLK_ACLK_SMMU_ARBG_TX 21 +#define CLK_ACLK_GIC 22 +#define CLK_ACLK_INT_MEM 23 +#define CLK_ACLK_XIU_PIMEMX 24 +#define CLK_ACLK_AXI2APB_IMEM0P 25 +#define CLK_ACLK_AXI2APB_IMEM1P 26 +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX 27 +#define CLK_ACLK_AXIDS_PIMEMX_GIC 28 +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29 +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30 +#define CLK_ACLK_SROMC 31 +#define CLK_ACLK_AXIDS_SROMC 32 +#define CLK_ACLK_AXI2AHB_IMEMH 33 +#define CLK_PCLK_SSS 34 +#define CLK_PCLK_SLIMSSS 35 +#define CLK_PCLK_RTIC 36 +#define CLK_PCLK_SYSREG_IMEM 37 +#define CLK_PCLK_PMU_IMEM 38 +#define CLK_PCLK_ALB_IMEM 39 +#define CLK_PCLK_BTS_SSS_CCI 40 +#define CLK_PCLK_BTS_SSS_DRAM 41 +#define CLK_PCLK_BTS_SLIMSSS 42 +#define CLK_PCLK_SMMU_SSS_CCI 43 +#define CLK_PCLK_SMMU_SSS_DRAM 44 +#define CLK_PCLK_SMMU_SLIMSSS 45 +#define CLK_PCLK_SMMU_RTIC 46 +#define CLK_PCLK_ASYNCAPB_ARBG_TX 47 +#define CLK_PCLK_BTS_ARBG_TX 48 +#define CLK_PCLK_SMMU_ARBG_TX 49 +#define CLK_PCLK_ASYNCAXI_IMEMX 50 +#define CLK_PCLK_GPIO_IMEM 51 + +#define IMEM_NR_CLK 52 + /* CMU_G2D */ #define CLK_MUX_ACLK_G2D_266_USER 1 #define CLK_MUX_ACLK_G2D_400_USER 2 -- 2.19.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] clk: samsung: exynos5433: add imem clock 2018-11-21 12:05 ` [PATCH 4/4] clk: samsung: exynos5433: " Kamil Konieczny @ 2018-11-21 12:39 ` Chanwoo Choi 2018-11-26 15:16 ` Kamil Konieczny 2018-11-28 13:31 ` Kamil Konieczny 0 siblings, 2 replies; 11+ messages in thread From: Chanwoo Choi @ 2018-11-21 12:39 UTC (permalink / raw) To: Kamil Konieczny Cc: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi, On 2018년 11월 21일 21:05, Kamil Konieczny wrote: > Add imem clock for exynos5433. It is diffcult to understand the meaning of 'imem' without the description. Please add more detailed description as the patch2 description. > > Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> > --- > drivers/clk/samsung/clk-exynos5433.c | 123 +++++++++++++++++++++++++ > include/dt-bindings/clock/exynos5433.h | 55 +++++++++++ > 2 files changed, 178 insertions(+) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index 24c3360db65b..db29cbd1fbdc 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -2345,6 +2345,129 @@ static const struct samsung_cmu_info fsys_cmu_info __initconst = { > .clk_name = "aclk_fsys_200", > }; > > +/* > + * Register offset definitions for CMU_IMEM > + * > + */ > + Remove unneeded blank line. > +#define ENABLE_ACLK_IMEM 0x0800 > +#define ENABLE_ACLK_IMEM_SSS 0x0808 > +#define ENABLE_ACLK_IMEM_SLIMSSS 0x080c > +#define ENABLE_PCLK_IMEM 0x0900 > +#define ENABLE_PCLK_IMEM_SSS 0x0904 > +#define ENABLE_PCLK_IMEM_SLIMSSS 0x0908 When I checked the registers of IMEM block, there are more registers as following: Why do you implement the clocks for only six registers? CLK_ENABLE_ACLK_IMEM 0x0800 CLK_ENABLE_ACLK_IMEM_SECURE_INT_MEM 0x0804 CLK_ENABLE_ACLK_IMEM_SECURE_SSS 0x0808 CLK_ENABLE_ACLK_IMEM_SECURE_SLIMSSS 0x080C CLK_ENABLE_ACLK_IMEM_SECURE_RTIC 0x0810 CLK_ENABLE_ACLK_IMEM_SECURE_SMMU_SSS 0x0814 CLK_ENABLE_ACLK_IMEM_SECURE_SMMU_SLIMSSS 0x0818 CLK_ENABLE_ACLK_IMEM_SECURE_SMMU_RTIC 0x081C CLK_ENABLE_ACLK_IMEM_SECURE_ARGB_TX 0x0820 CLK_ENABLE_ACLK_IMEM_SECURE_SMMU_ARGB_TX 0x0824 CLK_ENABLE_PCLK_IMEM 0x0900 CLK_ENABLE_PCLK_IMEM_SECURE_SSS 0x0904 CLK_ENABLE_PCLK_IMEM_SECURE_SLIMSSS 0x0908 CLK_ENABLE_PCLK_IMEM_SECURE_RTIC 0x090C CLK_ENABLE_PCLK_IMEM_SECURE_SMMU_SSS 0x0910 CLK_ENABLE_PCLK_IMEM_SECURE_SMMU_SLIMSSS 0x0914 CLK_ENABLE_PCLK_IMEM_SECURE_SMMU_RTIC 0x0918 CLK_ENABLE_PCLK_IMEM_SECURE_SMMU_ARGB_TX 0x091C CLK_ENABLE_IP_IMEM0 0x0B00 CLK_ENABLE_IP_IMEM1 0x0B04 CLK_ENABLE_IP_IMEM_SECURE_INT_MEM 0x0B08 CLK_ENABLE_IP_IMEM_SECURE_SSS 0x0B0C CLK_ENABLE_IP_IMEM_SECURE_SLIMSSS 0x0B10 CLK_ENABLE_IP_IMEM_SECURE_RTIC 0x0B14 CLK_ENABLE_IP_IMEM_SECURE_SMMU_SSS 0x0B18 CLK_ENABLE_IP_IMEM_SECURE_SMMU_SLIMSSS 0x0B1C CLK_ENABLE_IP_IMEM_SECURE_SMMU_RTIC 0x0B20 CLK_ENABLE_IP_IMEM_SECURE_ARBG_TX 0x0B24 CLK_ENABLE_IP_IMEM_SECURE_SMMU_ARBG_TX 0x0B28 > + > +static const unsigned long imem_clk_regs[] __initconst = { > +ENABLE_ACLK_IMEM, > +ENABLE_ACLK_IMEM_SSS, > +ENABLE_ACLK_IMEM_SLIMSSS, > +ENABLE_PCLK_IMEM, > +ENABLE_PCLK_IMEM_SSS, > +ENABLE_PCLK_IMEM_SLIMSSS, Add a tab in front of registers. > +}; > + > +static const struct samsung_gate_clock imem_gate_clks[] __initconst = { > + /* ENABLE_ACLK_IMEM */ > + GATE(CLK_ACLK_AXI2AHB_IMEMH, "aclk_axi2ahb_imemh", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 24, 0, 0), > + GATE(CLK_ACLK_AXIDS_SROMC, "aclk_axids_sromc", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 23, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_SROMC, "aclk_sromc", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 22, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_BTS_ARBG_TX, "aclk_bts_arbg_tx", "aclk_imem_266", > + ENABLE_ACLK_IMEM, 21, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_ASYNCAXI_IMEMX, "aclk_asyncaxi_imemx", "aclk_imem_266", > + ENABLE_ACLK_IMEM, 20, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_AXIUS_IMEMX, "aclk_axius_imemx", "aclk_imem_266", > + ENABLE_ACLK_IMEM, 19, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_XIU_IMEMX, "aclk_xiu_imemx", "aclk_imem_266", > + ENABLE_ACLK_IMEM, 18, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_ASYNCAXI_SSSX, "aclk_asyncaxi_sssx", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM, 17, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_BTS_SLIMSSS, "aclk_bts_slimsss", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM, 15, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_BTS_SSS_DRAM, "aclk_bts_sss_dram", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM, 14, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_BTS_SSS_CCI, "aclk_bts_sss_cci", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM, 13, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_ALB_IMEM, "aclk_alb_imem", "aclk_imem_266", > + ENABLE_ACLK_IMEM, 12, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_AXIDS_PIMEMX_IMEM1P, "aclk_axids_pimemx_imem1p", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 11, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_AXIDS_PIMEMX_IMEM0P, "aclk_axids_pimemx_imem0p", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 10, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_AXIDS_PIMEMX_GIC, "aclk_axids_pimemx_gic", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 9, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_ASYNCAHBM_SSS_ATLAS, "aclk_asyncahbm_sss_atlas", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM, 7, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_ASYNCAXIS_MIF_PIMEMX, "aclk_asyncaxis_mif_pimemx", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 6, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_AXI2APB_IMEM1P, "aclk_axi2apb_imem1p", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 5, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_AXI2APB_IMEM0P, "aclk_axi2apb_imem0p", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 4, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_XIU_SSSX, "aclk_xiu_sssx", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM, 3, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_XIU_PIMEMX, "aclk_xiu_pimemx", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 2, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_IMEMND_266, "aclk_imemnd_266", "aclk_imem_266", > + ENABLE_ACLK_IMEM, 1, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_ACLK_GIC, "aclk_gic", "aclk_imem_200", > + ENABLE_ACLK_IMEM, 0, CLK_IGNORE_UNUSED, 0), > + > + /* ENABLE_ACLK_IMEM_SSS */ > + GATE(CLK_ACLK_SSS, "aclk_sss", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM_SSS, 0, CLK_IGNORE_UNUSED, 0), > + /* ENABLE_ACLK_IMEM_SLIMSSS */ > + GATE(CLK_ACLK_SLIMSSS, "aclk_slimsss", "aclk_imem_sssx_266", > + ENABLE_ACLK_IMEM_SLIMSSS, 0, CLK_IGNORE_UNUSED, 0), > + > + /* ENABLE_PCLK_IMEM */ > + GATE(CLK_PCLK_GPIO_IMEM, "pclk_gpio_imem", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 17, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_ASYNCAXI_IMEMX, "pclk_asyncaxi_imemx", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 16, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_BTS_ARBG_TX, "pclk_bts_arbg_tx", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 15, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_ASYNCAPB_ARBG_TX, "pclk_asyncapb_arbg_tx", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 14, CLK_IGNORE_UNUSED, 0), > + > + GATE(CLK_PCLK_BTS_SLIMSSS, "pclk_bts_slimsss", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 8, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_BTS_SSS_DRAM, "pclk_bts_sss_dram", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 7, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_BTS_SSS_CCI, "pclk_bts_sss_cci", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 6, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_ALB_IMEM, "pclk_alb_imem", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 5, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_PMU_IMEM, "pclk_pmu_imem", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 4, CLK_IGNORE_UNUSED, 0), > + GATE(CLK_PCLK_SYSREG_IMEM, "pclk_sysreg_imem", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 3, CLK_IGNORE_UNUSED, 0), > + /* ENABLE_PCLK_IMEM_SSS */ > + GATE(CLK_PCLK_SSS, "pclk_sss", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 0, CLK_IGNORE_UNUSED, 0), > + /* ENABLE_PCLK_IMEM_SLIMSSS */ > + GATE(CLK_PCLK_SLIMSSS, "pclk_slimsss", "aclk_imem_200", > + ENABLE_PCLK_IMEM, 0, CLK_IGNORE_UNUSED, 0), > +}; > + > +static const struct samsung_cmu_info imem_cmu_info __initconst = { > + .gate_clks = imem_gate_clks, > + .nr_gate_clks = ARRAY_SIZE(imem_gate_clks), > + .nr_clk_ids = IMEM_NR_CLK, > + .clk_regs = imem_clk_regs, > + .nr_clk_regs = ARRAY_SIZE(imem_clk_regs), > +}; > + > +static void __init exynos5433_cmu_imem_init(struct device_node *np) > +{ > + samsung_cmu_register_one(np, &imem_cmu_info); > +} > + > +CLK_OF_DECLARE(exynos5433_cmu_imem, "samsung,exynos5433-cmu-imem", > + exynos5433_cmu_imem_init); Except for "samsmung,exynos5433-cmu-atlas/apollo", the remained clock blocks were added to exynos5433_cmu_of_match[] table for power management. If there is no any h/w issue, add the new entry to exynos5433_cmu_of_match for imem block. > + > /* > * Register offset definitions for CMU_G2D > */ > diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h > index 87bb2b017143..312d8810b56d 100644 > --- a/include/dt-bindings/clock/exynos5433.h > +++ b/include/dt-bindings/clock/exynos5433.h > @@ -623,6 +623,61 @@ > > #define FSYS_NR_CLK 116 > > +/* CMU_IMEM */ > +#define CLK_ACLK_SSS 1 > +#define CLK_ACLK_SLIMSSS 2 > +#define CLK_ACLK_RTIC 3 > +#define CLK_ACLK_XIU_SSSX 4 > +#define CLK_ACLK_ASYNCAHBM_SSS_ATLAS 5 > +#define CLK_ACLK_ASYNCAXI_SSSX 6 > +#define CLK_ACLK_BTS_SSS_CCI 7 > +#define CLK_ACLK_BTS_SSS_DRAM 8 > +#define CLK_ACLK_BTS_SLIMSSS 9 > +#define CLK_ACLK_SMMU_SSS_CCI 10 > +#define CLK_ACLK_SMMU_SSS_DRAM 11 > +#define CLK_ACLK_SMMU_SLIMSSS 12 > +#define CLK_ACLK_SMMU_RTIC 13 > +#define CLK_ACLK_IMEMND_266 14 > +#define CLK_ACLK_ALB_IMEM 15 > +#define CLK_ACLK_XIU_IMEMX 16 > +#define CLK_ACLK_AXIUS_IMEMX 17 > +#define CLK_ACLK_ASYNCAXI_IMEMX 18 > +#define CLK_ACLK_ARBG_TX 19 > +#define CLK_ACLK_BTS_ARBG_TX 20 > +#define CLK_ACLK_SMMU_ARBG_TX 21 > +#define CLK_ACLK_GIC 22 > +#define CLK_ACLK_INT_MEM 23 > +#define CLK_ACLK_XIU_PIMEMX 24 > +#define CLK_ACLK_AXI2APB_IMEM0P 25 > +#define CLK_ACLK_AXI2APB_IMEM1P 26 > +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX 27 > +#define CLK_ACLK_AXIDS_PIMEMX_GIC 28 > +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29 > +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30 > +#define CLK_ACLK_SROMC 31 > +#define CLK_ACLK_AXIDS_SROMC 32 > +#define CLK_ACLK_AXI2AHB_IMEMH 33 > +#define CLK_PCLK_SSS 34 > +#define CLK_PCLK_SLIMSSS 35 > +#define CLK_PCLK_RTIC 36 > +#define CLK_PCLK_SYSREG_IMEM 37 > +#define CLK_PCLK_PMU_IMEM 38 > +#define CLK_PCLK_ALB_IMEM 39 > +#define CLK_PCLK_BTS_SSS_CCI 40 > +#define CLK_PCLK_BTS_SSS_DRAM 41 > +#define CLK_PCLK_BTS_SLIMSSS 42 > +#define CLK_PCLK_SMMU_SSS_CCI 43 > +#define CLK_PCLK_SMMU_SSS_DRAM 44 > +#define CLK_PCLK_SMMU_SLIMSSS 45 > +#define CLK_PCLK_SMMU_RTIC 46 > +#define CLK_PCLK_ASYNCAPB_ARBG_TX 47 > +#define CLK_PCLK_BTS_ARBG_TX 48 > +#define CLK_PCLK_SMMU_ARBG_TX 49 > +#define CLK_PCLK_ASYNCAXI_IMEMX 50 > +#define CLK_PCLK_GPIO_IMEM 51 > + > +#define IMEM_NR_CLK 52 > + > /* CMU_G2D */ > #define CLK_MUX_ACLK_G2D_266_USER 1 > #define CLK_MUX_ACLK_G2D_400_USER 2 > -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] clk: samsung: exynos5433: add imem clock 2018-11-21 12:39 ` Chanwoo Choi @ 2018-11-26 15:16 ` Kamil Konieczny 2018-11-28 13:31 ` Kamil Konieczny 1 sibling, 0 replies; 11+ messages in thread From: Kamil Konieczny @ 2018-11-26 15:16 UTC (permalink / raw) To: Chanwoo Choi Cc: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi, > On 2018년 11월 21일 21:05, Kamil Konieczny wrote: >> Add imem clock for exynos5433. > > It is diffcult to understand the meaning of 'imem' without the description. > Please add more detailed description as the patch2 description. > [...] Thank you for review, will this be enough for description: Add imem clock for exynos5433. This will enable to use crypto Security SubSystem (in short SSS) and SlimSSS IP blocks. In documentation there is no description of "imem" name origin. I can guess "mem" stand for "memory", and 'i' ? internal ? -- Best regards, Kamil Konieczny Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] clk: samsung: exynos5433: add imem clock 2018-11-21 12:39 ` Chanwoo Choi 2018-11-26 15:16 ` Kamil Konieczny @ 2018-11-28 13:31 ` Kamil Konieczny 1 sibling, 0 replies; 11+ messages in thread From: Kamil Konieczny @ 2018-11-28 13:31 UTC (permalink / raw) To: Chanwoo Choi Cc: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi, Thank you for your review, see below for answers and questions. On 21.11.2018 13:39, Chanwoo Choi wrote: > Hi, > > On 2018년 11월 21일 21:05, Kamil Konieczny wrote: >> Add imem clock for exynos5433. > > It is diffcult to understand the meaning of 'imem' without the description. > Please add more detailed description as the patch2 description. > Will this be enough for description: Add imem clock for exynos5433. This will enable to use crypto Security SubSystem (in short SSS) and SlimSSS IP blocks. What do you think ? >> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> >> --- >> drivers/clk/samsung/clk-exynos5433.c | 123 +++++++++++++++++++++++++ >> include/dt-bindings/clock/exynos5433.h | 55 +++++++++++ >> 2 files changed, 178 insertions(+) >> >> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c >> index 24c3360db65b..db29cbd1fbdc 100644 >> --- a/drivers/clk/samsung/clk-exynos5433.c >> +++ b/drivers/clk/samsung/clk-exynos5433.c >> @@ -2345,6 +2345,129 @@ static const struct samsung_cmu_info fsys_cmu_info __initconst = { >> .clk_name = "aclk_fsys_200", >> }; >> >> +/* >> + * Register offset definitions for CMU_IMEM >> + * >> + */ >> + > > Remove unneeded blank line. ok > >> +#define ENABLE_ACLK_IMEM 0x0800 >> +#define ENABLE_ACLK_IMEM_SSS 0x0808 >> +#define ENABLE_ACLK_IMEM_SLIMSSS 0x080c >> +#define ENABLE_PCLK_IMEM 0x0900 >> +#define ENABLE_PCLK_IMEM_SSS 0x0904 >> +#define ENABLE_PCLK_IMEM_SLIMSSS 0x0908 > > When I checked the registers of IMEM block, there are more registers as following: > Why do you implement the clocks for only six registers? I added only those that will be used by crypto block (aes and hash block). I can add all of them in version 2. > CLK_ENABLE_ACLK_IMEM 0x0800 > > CLK_ENABLE_ACLK_IMEM_SECURE_INT_MEM 0x0804 > > CLK_ENABLE_ACLK_IMEM_SECURE_SSS 0x0808 > > CLK_ENABLE_ACLK_IMEM_SECURE_SLIMSSS 0x080C > > CLK_ENABLE_ACLK_IMEM_SECURE_RTIC 0x0810 > > CLK_ENABLE_ACLK_IMEM_SECURE_SMMU_SSS 0x0814 > [...] > >> + >> +static const unsigned long imem_clk_regs[] __initconst = { >> +ENABLE_ACLK_IMEM, >> +ENABLE_ACLK_IMEM_SSS, >> +ENABLE_ACLK_IMEM_SLIMSSS, >> +ENABLE_PCLK_IMEM, >> +ENABLE_PCLK_IMEM_SSS, >> +ENABLE_PCLK_IMEM_SLIMSSS, > > Add a tab in front of registers. > ok >> [...] >> +static void __init exynos5433_cmu_imem_init(struct device_node *np) >> +{ >> + samsung_cmu_register_one(np, &imem_cmu_info); >> +} >> + >> +CLK_OF_DECLARE(exynos5433_cmu_imem, "samsung,exynos5433-cmu-imem", >> + exynos5433_cmu_imem_init); > > Except for "samsmung,exynos5433-cmu-atlas/apollo", the remained clock blocks > were added to exynos5433_cmu_of_match[] table for power management. > > If there is no any h/w issue, add the new entry to exynos5433_cmu_of_match for imem block. ok, I will add this. >> [...] -- Best regards, Kamil Konieczny Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-11-28 13:31 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20181121120522eucas1p2ecd03f848bc4ea3be3d517b40b78b084@eucas1p2.samsung.com>
2018-11-21 12:05 ` [PATCH 0/4] Add imem clock for Exynos 5433 Kamil Konieczny
[not found] ` <CGME20181121120523eucas1p1e69848a515c713315499e6e21f099cc2@eucas1p1.samsung.com>
2018-11-21 12:05 ` [PATCH 1/4] clk: samsung: exynos5433: fix name typos Kamil Konieczny
2018-11-21 12:23 ` Chanwoo Choi
2018-11-21 13:13 ` Krzysztof Kozlowski
2018-11-26 14:25 ` Kamil Konieczny
[not found] ` <CGME20181121120523eucas1p1e8c1ef3d19d0f71bbdc57e2a470c80b0@eucas1p1.samsung.com>
2018-11-21 12:05 ` [PATCH 2/4] arm64: dts: bindings: document imem clock Kamil Konieczny
[not found] ` <CGME20181121120524eucas1p2545f7ee0ed4064a10b3bc18f446c288c@eucas1p2.samsung.com>
2018-11-21 12:05 ` [PATCH 3/4] arm64: dts: exynos: add " Kamil Konieczny
[not found] ` <CGME20181121120524eucas1p166a26857df78947c9e08f0fb8dbf75e4@eucas1p1.samsung.com>
2018-11-21 12:05 ` [PATCH 4/4] clk: samsung: exynos5433: " Kamil Konieczny
2018-11-21 12:39 ` Chanwoo Choi
2018-11-26 15:16 ` Kamil Konieczny
2018-11-28 13:31 ` Kamil Konieczny
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).