From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver Date: Mon, 9 Mar 2015 12:02:56 +0100 Message-ID: References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-3-git-send-email-jaewon02.kim@samsung.com> <20150307201340.GF5233@earth> <54FCEABE.9000007@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <54FCEABE.9000007@samsung.com> Sender: linux-pm-owner@vger.kernel.org To: Beomho Seo Cc: Lee Jones , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov List-Id: devicetree@vger.kernel.org 2015-03-09 1:35 GMT+01:00 Beomho Seo : > On 03/08/2015 05:13 AM, Sebastian Reichel wrote: >> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote: >>> From: Beomho Seo >>> >>> This patch adds device driver of max77843 charger. This driver provide >>> initialize each charging mode(e.g. fast charge, top-off mode and constant >>> charging mode so on.). Additionally, control charging paramters to use >>> i2c interface. >>> >>> Cc: Sebastian Reichel >>> Signed-off-by: Beomho Seo >> >> Reviewed-By: Sebastian Reichel >> >> I can't take it as is, since it depends on the private header file >> of PATCHv1. >> >> -- Sebastian >> > > This patch reviewed by Sebastian. > Could you Please merge that your git tree ? Hi, ... and again we are adding a new driver for very similar chipset to already supported. I looked at spec and the charger's registers are almost the same as for max77693. Their layout and addresses are the same. I see some minor differences, probably the most important would be different values current (fast-charge, top-off). But still 90% of registers are the same... Do we really have to add new driver? Best regards, Krzysztof