From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries Date: Mon, 24 Apr 2017 10:32:16 +0200 Message-ID: References: <8fd1dcd1bfa2011411dceab82bcd1587fe913cd1.1492685450.git.viresh.kumar@linaro.org> <20170420160930.halyszjunt4q2634@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Masahiro Yamada Cc: Viresh Kumar , arm@kernel.org, Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Javier Martinez Canillas , Rob Herring , Mark Rutland , linaro-kernel@lists.linaro.org, linux-arm-kernel , linux-pm@vger.kernel.org, Rafael Wysocki , Rob Herring , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org On Mon, Apr 24, 2017 at 10:30 AM, Masahiro Yamada wrote: > 2017-04-21 1:09 GMT+09:00 Krzysztof Kozlowski : >> On Thu, Apr 20, 2017 at 04:25:07PM +0530, Viresh Kumar wrote: >>> Compiling the DT file with W=1, DTC warns like follows: >>> >>> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a >>> unit name, but no reg property >>> >>> Fix this by replacing '@' with '-' as the OPP nodes will never have a >>> "reg" property. >>> >>> Reported-by: Krzysztof Kozlowski >>> Reported-by: Masahiro Yamada >>> Suggested-by: Mark Rutland >>> Signed-off-by: Viresh Kumar >>> Reviewed-by: Chanwoo Choi >>> Reviewed-by: Krzysztof Kozlowski >>> Acked-by: Rob Herring >>> --- >>> .../devicetree/bindings/devfreq/exynos-bus.txt | 46 +++++++-------- >>> arch/arm/boot/dts/exynos3250.dtsi | 46 +++++++-------- >>> arch/arm/boot/dts/exynos4210.dtsi | 32 +++++------ >>> arch/arm/boot/dts/exynos4412-prime.dtsi | 4 +- >>> arch/arm/boot/dts/exynos4412.dtsi | 66 +++++++++++----------- >>> arch/arm/boot/dts/exynos5420.dtsi | 40 ++++++------- >>> arch/arm/boot/dts/exynos5800.dtsi | 56 +++++++++--------- >>> arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 48 ++++++++-------- >>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 50 ++++++++-------- >>> 9 files changed, 194 insertions(+), 194 deletions(-) >> >> >> Thanks, split ARM64 from ARM and applied (for v4.12). arm-soc keeps DTS >> separated between ARM architectures. Technically this should require a >> resend but we had way too many resends for this simple patch. >> > > > Minor note: > > For arm64 part, Krzysztof's Signed-off-by is doubled. > (commit 5dccc9873c4af60f4478b3ef54267353f25cc301) Thanks for spotting it. Best regards, Krzysztof