* [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node
@ 2018-07-18 12:59 Anand Moon
2018-07-18 13:55 ` Krzysztof Kozlowski
2018-07-22 15:08 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Anand Moon @ 2018-07-18 12:59 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Anand Moon
Add missing GIC interrupts property for pwm nodes.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Fixed the patch indentation issue with all tabs.
sorry checkpatch could not figure out the error.
---
arch/arm/boot/dts/exynos5.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index 5d2f0a0..f48fb9b 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -169,6 +169,11 @@
pwm: pwm@12dd0000 {
compatible = "samsung,exynos4210-pwm";
reg = <0x12DD0000 0x100>;
+ interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
samsung,pwm-outputs = <0>, <1>, <2>, <3>;
#pwm-cells = <3>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node
2018-07-18 12:59 [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node Anand Moon
@ 2018-07-18 13:55 ` Krzysztof Kozlowski
2018-07-18 17:48 ` Anand Moon
2018-07-22 15:08 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2018-07-18 13:55 UTC (permalink / raw)
To: Anand Moon
Cc: Rob Herring, Mark Rutland, Kukjin Kim, devicetree,
linux-arm-kernel, linux-samsung-soc@vger.kernel.org, linux-kernel
On 18 July 2018 at 14:59, Anand Moon <linux.amoon@gmail.com> wrote:
> Add missing GIC interrupts property for pwm nodes.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Fixed the patch indentation issue with all tabs.
> sorry checkpatch could not figure out the error.
> ---
> arch/arm/boot/dts/exynos5.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
> index 5d2f0a0..f48fb9b 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -169,6 +169,11 @@
> pwm: pwm@12dd0000 {
> compatible = "samsung,exynos4210-pwm";
> reg = <0x12DD0000 0x100>;
> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
OK, thanks for v2. Now only tabs are used but in previous mail I
mentioned which example to use - the rtc node which nicely aligns
continued lines. Why you did not follow this alignment?
I'll fix it when applying, no need to resend.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node
2018-07-18 13:55 ` Krzysztof Kozlowski
@ 2018-07-18 17:48 ` Anand Moon
0 siblings, 0 replies; 4+ messages in thread
From: Anand Moon @ 2018-07-18 17:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, devicetree,
linux-arm-kernel, linux-samsung-soc@vger.kernel.org, Linux Kernel
Hi Krzysztof,
On 18 July 2018 at 19:25, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 18 July 2018 at 14:59, Anand Moon <linux.amoon@gmail.com> wrote:
>> Add missing GIC interrupts property for pwm nodes.
>>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>> Fixed the patch indentation issue with all tabs.
>> sorry checkpatch could not figure out the error.
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
>> index 5d2f0a0..f48fb9b 100644
>> --- a/arch/arm/boot/dts/exynos5.dtsi
>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>> @@ -169,6 +169,11 @@
>> pwm: pwm@12dd0000 {
>> compatible = "samsung,exynos4210-pwm";
>> reg = <0x12DD0000 0x100>;
>> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
>
> OK, thanks for v2. Now only tabs are used but in previous mail I
> mentioned which example to use - the rtc node which nicely aligns
> continued lines. Why you did not follow this alignment?
>
> I'll fix it when applying, no need to resend.
>
> Best regards,
> Krzysztof
Thanks, I follow the tab protocol otherwise checkpatch would have
complained of tab/space issue.
Best Regards
-Anand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node
2018-07-18 12:59 [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node Anand Moon
2018-07-18 13:55 ` Krzysztof Kozlowski
@ 2018-07-22 15:08 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2018-07-22 15:08 UTC (permalink / raw)
To: Anand Moon
Cc: Rob Herring, Mark Rutland, Kukjin Kim, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
On Wed, Jul 18, 2018 at 12:59:27PM +0000, Anand Moon wrote:
> Add missing GIC interrupts property for pwm nodes.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Fixed the patch indentation issue with all tabs.
> sorry checkpatch could not figure out the error.
> ---
> arch/arm/boot/dts/exynos5.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
Thanks, applied with fixed subsystem prefix in subject and indentation.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-22 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 12:59 [PATCHv2] ARM: dts: exynos5: add missing interrupts for pwm node Anand Moon
2018-07-18 13:55 ` Krzysztof Kozlowski
2018-07-18 17:48 ` Anand Moon
2018-07-22 15:08 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).